Patchwork [v2] gsettings-desktop-schemas: add missing elements from meta-gnome

login
register
mail settings
Submitter Constantin Musca
Date Jan. 7, 2013, 12:05 p.m.
Message ID <1357560325-8260-1-git-send-email-constantinx.musca@intel.com>
Download mbox | patch
Permalink /patch/42183/
State New
Headers show

Comments

Constantin Musca - Jan. 7, 2013, 12:05 p.m.
- add postinst using gsettings.bbclass
- modify the recipe according to the meta-gnome variant

Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
---
 meta/recipes-gnome/gnome/gsettings-desktop-schemas_3.7.3.bb | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Richard Purdie - Jan. 7, 2013, 1:34 p.m.
On Mon, 2013-01-07 at 14:05 +0200, Constantin Musca wrote:
> - add postinst using gsettings.bbclass
> - modify the recipe according to the meta-gnome variant
> 
> Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
> ---
>  meta/recipes-gnome/gnome/gsettings-desktop-schemas_3.7.3.bb | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-gnome/gnome/gsettings-desktop-schemas_3.7.3.bb b/meta/recipes-gnome/gnome/gsettings-desktop-schemas_3.7.3.bb
> index 720858a..1242741 100644
> --- a/meta/recipes-gnome/gnome/gsettings-desktop-schemas_3.7.3.bb
> +++ b/meta/recipes-gnome/gnome/gsettings-desktop-schemas_3.7.3.bb
> @@ -4,10 +4,9 @@ BUGTRACKER = "https://bugzilla.gnome.org/"
>  
>  LICENSE = "LGPLv2.1"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
> +PR = "r1"
>  
> -DEPENDS = "glib-2.0"

It doesn't need glib-2.0?

> -
> -inherit gnome pkgconfig autotools gettext
> +inherit gnome gsettings

It doesn't need gettext?

Cheers,

Richard
Constantin Musca - Jan. 7, 2013, 2:48 p.m.
On 01/07/2013 03:34 PM, Richard Purdie wrote:
> On Mon, 2013-01-07 at 14:05 +0200, Constantin Musca wrote:
>> - add postinst using gsettings.bbclass
>> - modify the recipe according to the meta-gnome variant
>>
>> Signed-off-by: Constantin Musca <constantinx.musca@intel.com>
>> ---
>>   meta/recipes-gnome/gnome/gsettings-desktop-schemas_3.7.3.bb | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/recipes-gnome/gnome/gsettings-desktop-schemas_3.7.3.bb b/meta/recipes-gnome/gnome/gsettings-desktop-schemas_3.7.3.bb
>> index 720858a..1242741 100644
>> --- a/meta/recipes-gnome/gnome/gsettings-desktop-schemas_3.7.3.bb
>> +++ b/meta/recipes-gnome/gnome/gsettings-desktop-schemas_3.7.3.bb
>> @@ -4,10 +4,9 @@ BUGTRACKER = "https://bugzilla.gnome.org/"
>>   
>>   LICENSE = "LGPLv2.1"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
>> +PR = "r1"
>>   
>> -DEPENDS = "glib-2.0"
> It doesn't need glib-2.0?
>
>> -
>> -inherit gnome pkgconfig autotools gettext
>> +inherit gnome gsettings
> It doesn't need gettext?
>
> Cheers,
>
> Richard
>
I removed the dependencies because the original recipe from meta-gnome 
didn't contain them and gsettings-desktop-schemas builds OK without 
them. I have checked the gsettings-desktop-schemas autotools files and 
discovered:

PKG_CHECK_EXISTS([gio-2.0 >= $GIO_MIN_VERSION],[],
                  [AC_MSG_ERROR([Minimum Gio requirement 
($GIO_MIN_VERSION) was not met])])


Also I have discovered that the configure script checks for gettext. I 
have sent patch v3 which adds back the dependencies.

Cheers,
Constantin

Patch

diff --git a/meta/recipes-gnome/gnome/gsettings-desktop-schemas_3.7.3.bb b/meta/recipes-gnome/gnome/gsettings-desktop-schemas_3.7.3.bb
index 720858a..1242741 100644
--- a/meta/recipes-gnome/gnome/gsettings-desktop-schemas_3.7.3.bb
+++ b/meta/recipes-gnome/gnome/gsettings-desktop-schemas_3.7.3.bb
@@ -4,10 +4,9 @@  BUGTRACKER = "https://bugzilla.gnome.org/"
 
 LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
+PR = "r1"
 
-DEPENDS = "glib-2.0"
-
-inherit gnome pkgconfig autotools gettext
+inherit gnome gsettings
 
 GNOME_COMPRESS_TYPE = "xz"