Patchwork [2/4] eglibc_2.17: Fix Tibetian locale generation error

login
register
mail settings
Submitter Khem Raj
Date Jan. 5, 2013, midnight
Message ID <449d181c104843ef74cbc1f81a5a58f18051fc14.1357343832.git.raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/42007/
State Accepted
Commit 4b39d90c84b1c1577b6744e7117502069c5bf719
Headers show

Comments

Khem Raj - Jan. 5, 2013, midnight
This is fallout of BZ #13950 fix to glibc

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../eglibc/eglibc-2.17/fix-tibetian-locales.patch  |   38 ++++++++++++++++++++
 meta/recipes-core/eglibc/eglibc_2.17.bb            |    1 +
 2 files changed, 39 insertions(+)
 create mode 100644 meta/recipes-core/eglibc/eglibc-2.17/fix-tibetian-locales.patch
Otavio Salvador - Jan. 5, 2013, 12:33 a.m.
On Fri, Jan 4, 2013 at 10:00 PM, Khem Raj <raj.khem@gmail.com> wrote:
> This is fallout of BZ #13950 fix to glibc
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

Fix doesn't seem as an accurate name here; I'd prefer:

Workaround Tibetian locale generation error

as it better describes what it does; the patch file should be renamed
and updated as well.

What do you think?

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Khem Raj - Jan. 5, 2013, 1:41 a.m.
On 01/04/2013 04:33 PM, Otavio Salvador wrote:
> On Fri, Jan 4, 2013 at 10:00 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> This is fallout of BZ #13950 fix to glibc
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>
> Fix doesn't seem as an accurate name here; I'd prefer:
>
> Workaround Tibetian locale generation error
>
> as it better describes what it does; the patch file should be renamed
> and updated as well.
>
> What do you think?
>

I can change that thanks.

> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
>

Patch

diff --git a/meta/recipes-core/eglibc/eglibc-2.17/fix-tibetian-locales.patch b/meta/recipes-core/eglibc/eglibc-2.17/fix-tibetian-locales.patch
new file mode 100644
index 0000000..25c43a9
--- /dev/null
+++ b/meta/recipes-core/eglibc/eglibc-2.17/fix-tibetian-locales.patch
@@ -0,0 +1,38 @@ 
+cross localedef fails to compile these locales because name_fmt field is empty
+It is not acceptable for cross localedef and it errors out
+
+LC_NAME: field `name_fmt' not defined
+
+We therefore give a dummy string to the format, the real fix needs some native
+tibetian person to define proper name_fmt
+
+Upstream-Status: Pending
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+
+Index: libc/localedata/locales/bo_CN
+===================================================================
+--- libc.orig/localedata/locales/bo_CN	2012-11-17 09:50:14.000000000 -0800
++++ libc/localedata/locales/bo_CN	2013-01-04 08:55:15.593612288 -0800
+@@ -145,7 +145,7 @@
+ LC_NAME
+ % FIXME
+ 
+-name_fmt  ""
++name_fmt  "FIXME"
+ % name_gen	"FIXME"
+ % name_miss	"FIXME"
+ % name_mr	"FIXME"
+Index: libc/localedata/locales/bo_IN
+===================================================================
+--- libc.orig/localedata/locales/bo_IN	2012-11-17 09:50:14.000000000 -0800
++++ libc/localedata/locales/bo_IN	2013-01-04 08:54:12.345609028 -0800
+@@ -70,7 +70,7 @@
+ 
+ LC_NAME
+ % FIXME
+-name_fmt	""
++name_fmt	"FIXME"
+ % name_gen	"FIXME"
+ % name_miss	"FIXME"
+ % name_mr	"FIXME"
diff --git a/meta/recipes-core/eglibc/eglibc_2.17.bb b/meta/recipes-core/eglibc/eglibc_2.17.bb
index 1a9c288..b71af1a 100644
--- a/meta/recipes-core/eglibc/eglibc_2.17.bb
+++ b/meta/recipes-core/eglibc/eglibc_2.17.bb
@@ -26,6 +26,7 @@  SRC_URI = "http://sakrah.dontexist.org/files/eglibc/eglibc-${PV}-svnr22064.tar.b
            file://tzselect-sh.patch \
            file://tzselect-awk.patch \
            file://0001-eglibc-run-libm-err-tab.pl-with-specific-dirs-in-S.patch \
+           file://fix-tibetian-locales.patch \
           "
 SRC_URI[md5sum] = "1464af54779c2c7d1078df9ce2e41791"
 SRC_URI[sha256sum] = "97c3991a3772f513cf704841d20c275ac48895fad2e27802dda557c0196cba6b"