From patchwork Mon May 16 22:26:10 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [RFC,v2,10/15] send-pull-request: verify git sendemail config Date: Mon, 16 May 2011 22:26:10 -0000 From: Darren Hart X-Patchwork-Id: 4193 Message-Id: <317bb4eca14f234d7e85ecd924661941b83d1318.1305584418.git.dvhart@linux.intel.com> To: openembedded-core@lists.openembedded.org Perform a quick sanity check to be able to direct users to configure git.sendemail if they haven't yet. Signed-off-by: Darren Hart --- scripts/send-pull-request | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/scripts/send-pull-request b/scripts/send-pull-request index 5a11d1f..21eb302 100755 --- a/scripts/send-pull-request +++ b/scripts/send-pull-request @@ -41,6 +41,18 @@ harvest_recipients() unset IFS } +check_git_sendemail_config() +{ + GIT_SMTP=$(git config sendemail.smtpserver) + GIT_FROM=$(git config sendemail.from) + if [ -z "$GIT_SMTP" ] || [ -z "$GIT_FROM" ]; then + echo "ERROR: git sendemail is not configured." + echo "Please read GIT-SEND-EMAIL(1) and configure:" + echo " sendemail.smtpserver" + echo " sendemail.from" + exit 1 + fi +} # Parse and verify arguments while getopts "achp:t:" OPT; do @@ -74,6 +86,9 @@ while getopts "achp:t:" OPT; do esac done +# Abort early if git-send-email is not properly configured +check_git_sendemail_config + if [ -z "$PDIR" ]; then echo "ERROR: you must specify a pull-dir." usage