Patchwork [3/3,RFC] archive-*-source.bbclass: Handle package class 'package_ipk'

login
mail settings
Submitter Shakeel, Muhammad
Date Jan. 2, 2013, 11:53 a.m.
Message ID <1357127607-20161-1-git-send-email-muhammad_shakeel@mentor.com>
Download mbox | patch
Permalink /patch/41851/
State New
Headers show

Comments

Shakeel, Muhammad - Jan. 2, 2013, 11:53 a.m.
From: Muhammad Shakeel <muhammad_shakeel@mentor.com>

* Add archiver tasks correctly if 'PACKAGE_CLASSES' is set to 'package_ipk'

[YOCTO #3449]

Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 meta/classes/archive-configured-source.bbclass |    2 ++
 meta/classes/archive-original-source.bbclass   |    2 ++
 meta/classes/archive-patched-source.bbclass    |    2 ++
 3 files changed, 6 insertions(+)
Christopher Larson - Jan. 2, 2013, 2:51 p.m.
On Wed, Jan 2, 2013 at 4:53 AM, Shakeel, Muhammad <
muhammad_shakeel@mentor.com> wrote:

>  addtask do_archive_scripts_logs after do_package_write_rpm
> +addtask do_archive_scripts_logs after do_package_write_ipk
>

This will cause problems for anyone trying to do builds without package_ipk
at all. I'd suggest using anonymous python to add the appropriate package
dependencies based on what tasks actually exist.

-CHris
Otavio Salvador - Jan. 2, 2013, 5:04 p.m.
On Wed, Jan 2, 2013 at 12:51 PM, Christopher Larson
<chris_larson@mentor.com> wrote:
> On Wed, Jan 2, 2013 at 4:53 AM, Shakeel, Muhammad
> <muhammad_shakeel@mentor.com> wrote:
>>
>>  addtask do_archive_scripts_logs after do_package_write_rpm
>> +addtask do_archive_scripts_logs after do_package_write_ipk
>
>
> This will cause problems for anyone trying to do builds without package_ipk
> at all. I'd suggest using anonymous python to add the appropriate package
> dependencies based on what tasks actually exist.

Uh? the only exception for it would be deb, right?

Regards,

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Christopher Larson - Jan. 2, 2013, 5:11 p.m.
On Wed, Jan 2, 2013 at 10:04 AM, Otavio Salvador <otavio@ossystems.com.br>wrote:

> On Wed, Jan 2, 2013 at 12:51 PM, Christopher Larson
> <chris_larson@mentor.com> wrote:
> > On Wed, Jan 2, 2013 at 4:53 AM, Shakeel, Muhammad
> > <muhammad_shakeel@mentor.com> wrote:
> >>
> >>  addtask do_archive_scripts_logs after do_package_write_rpm
> >> +addtask do_archive_scripts_logs after do_package_write_ipk
> >
> >
> > This will cause problems for anyone trying to do builds without
> package_ipk
> > at all. I'd suggest using anonymous python to add the appropriate package
> > dependencies based on what tasks actually exist.
>
> Uh? the only exception for it would be deb, right?


Yes, and?

-Chris
Otavio Salvador - Jan. 3, 2013, 9:13 p.m.
On Wed, Jan 2, 2013 at 3:11 PM, Christopher Larson
<chris_larson@mentor.com> wrote:
>
>
> On Wed, Jan 2, 2013 at 10:04 AM, Otavio Salvador <otavio@ossystems.com.br>
> wrote:
>>
>> On Wed, Jan 2, 2013 at 12:51 PM, Christopher Larson
>> <chris_larson@mentor.com> wrote:
>> > On Wed, Jan 2, 2013 at 4:53 AM, Shakeel, Muhammad
>> > <muhammad_shakeel@mentor.com> wrote:
>> >>
>> >>  addtask do_archive_scripts_logs after do_package_write_rpm
>> >> +addtask do_archive_scripts_logs after do_package_write_ipk
>> >
>> >
>> > This will cause problems for anyone trying to do builds without
>> > package_ipk
>> > at all. I'd suggest using anonymous python to add the appropriate
>> > package
>> > dependencies based on what tasks actually exist.
>>
>> Uh? the only exception for it would be deb, right?
>
>
> Yes, and?

So the first patch changing from pre/post commands should be reworked
and solve it in the right way. I agree about the use of annonymous
python method for it.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Shakeel, Muhammad - Jan. 7, 2013, 7:31 a.m.
Okay, I will fix it by using python function before sending the final patch. Thanks for your feedback.

--Shakeel

-----Original Message-----
From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Otavio Salvador
Sent: Friday, January 04, 2013 2:14 AM
To: Larson, Chris
Cc: Patches and discussions about the oe-core layer
Subject: Re: [OE-core] [PATCH 3/3] [RFC] archive-*-source.bbclass: Handle package class 'package_ipk'

On Wed, Jan 2, 2013 at 3:11 PM, Christopher Larson <chris_larson@mentor.com> wrote:
>
>
> On Wed, Jan 2, 2013 at 10:04 AM, Otavio Salvador 
> <otavio@ossystems.com.br>
> wrote:
>>
>> On Wed, Jan 2, 2013 at 12:51 PM, Christopher Larson 
>> <chris_larson@mentor.com> wrote:
>> > On Wed, Jan 2, 2013 at 4:53 AM, Shakeel, Muhammad 
>> > <muhammad_shakeel@mentor.com> wrote:
>> >>
>> >>  addtask do_archive_scripts_logs after do_package_write_rpm
>> >> +addtask do_archive_scripts_logs after do_package_write_ipk
>> >
>> >
>> > This will cause problems for anyone trying to do builds without 
>> > package_ipk at all. I'd suggest using anonymous python to add the 
>> > appropriate package dependencies based on what tasks actually 
>> > exist.
>>
>> Uh? the only exception for it would be deb, right?
>
>
> Yes, and?

So the first patch changing from pre/post commands should be reworked and solve it in the right way. I agree about the use of annonymous python method for it.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/meta/classes/archive-configured-source.bbclass b/meta/classes/archive-configured-source.bbclass
index 83ee42e..83a77f3 100644
--- a/meta/classes/archive-configured-source.bbclass
+++ b/meta/classes/archive-configured-source.bbclass
@@ -12,9 +12,11 @@  addtask do_archive_configured_sources after do_configure
 
 # Get archiving package with temp(logs) and scripts(.bb and inc files)
 addtask do_archive_scripts_logs after do_package_write_rpm
+addtask do_archive_scripts_logs after do_package_write_ipk
 
 # Get dump date and create diff file 
 addtask do_dumpdata_create_diff_gz after do_package_write_rpm before do_build
+addtask do_dumpdata_create_diff_gz after do_package_write_ipk before do_build
 
 python () {
     if d.getVar('SOURCE_ARCHIVE_PACKAGE_TYPE', True) != 'srpm':
diff --git a/meta/classes/archive-original-source.bbclass b/meta/classes/archive-original-source.bbclass
index 53a3539..10003be 100644
--- a/meta/classes/archive-original-source.bbclass
+++ b/meta/classes/archive-original-source.bbclass
@@ -12,9 +12,11 @@  addtask do_archive_original_sources_patches after do_unpack
 
 # Get archiving package with temp(logs) and scripts(.bb and inc files)
 addtask do_archive_scripts_logs after do_package_write_rpm
+addtask do_archive_scripts_logs after do_package_write_ipk
 
 # Get dump date and create diff file 
 addtask do_dumpdata_create_diff_gz after do_package_write_rpm before do_build
+addtask do_dumpdata_create_diff_gz after do_package_write_ipk before do_build
 
 python () {
     if d.getVar('SOURCE_ARCHIVE_PACKAGE_TYPE', True) != 'srpm':
diff --git a/meta/classes/archive-patched-source.bbclass b/meta/classes/archive-patched-source.bbclass
index a23f4bf..7c94d25 100644
--- a/meta/classes/archive-patched-source.bbclass
+++ b/meta/classes/archive-patched-source.bbclass
@@ -12,9 +12,11 @@  addtask do_archive_patched_sources after do_patch
 
 # Get archiving package with logs(temp) and scripts(.bb and .inc files)
 addtask do_archive_scripts_logs after do_package_write_rpm
+addtask do_archive_scripts_logs after do_package_write_ipk
 
 # Get dump date and create diff file 
 addtask do_dumpdata_create_diff_gz after do_package_write_rpm before do_build
+addtask do_dumpdata_create_diff_gz after do_package_write_ipk before do_build
 
 python () {
     if d.getVar('SOURCE_ARCHIVE_PACKAGE_TYPE', True) != 'srpm':