Patchwork vala-stub: add a stub for vala-native

login
register
mail settings
Submitter Ross Burton
Date Dec. 21, 2012, 12:39 p.m.
Message ID <1356093547-21765-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/41433/
State New
Headers show

Comments

Ross Burton - Dec. 21, 2012, 12:39 p.m.
Some packages have optional support for Vala but require vala.m4 to provide
VALA_PROG_VAPIGEN so that autoreconf works.

vala-stub provides a dummy VALA_PROG_VAPIGEN which doesn't do anything, so the
configure script runs and believes that vala isn't present.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-devtools/vala/files/vala.m4 |    2 ++
 meta/recipes-devtools/vala/vala-stub.bb  |   16 ++++++++++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 meta/recipes-devtools/vala/files/vala.m4
 create mode 100644 meta/recipes-devtools/vala/vala-stub.bb
Martin Jansa - Dec. 21, 2012, 1:12 p.m.
On Fri, Dec 21, 2012 at 12:39:07PM +0000, Ross Burton wrote:
> Some packages have optional support for Vala but require vala.m4 to provide
> VALA_PROG_VAPIGEN so that autoreconf works.
> 
> vala-stub provides a dummy VALA_PROG_VAPIGEN which doesn't do anything, so the
> configure script runs and believes that vala isn't present.

Doesn't this conflict with real vala-native?

> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-devtools/vala/files/vala.m4 |    2 ++
>  meta/recipes-devtools/vala/vala-stub.bb  |   16 ++++++++++++++++
>  2 files changed, 18 insertions(+)
>  create mode 100644 meta/recipes-devtools/vala/files/vala.m4
>  create mode 100644 meta/recipes-devtools/vala/vala-stub.bb
> 
> diff --git a/meta/recipes-devtools/vala/files/vala.m4 b/meta/recipes-devtools/vala/files/vala.m4
> new file mode 100644
> index 0000000..1776c6d
> --- /dev/null
> +++ b/meta/recipes-devtools/vala/files/vala.m4
> @@ -0,0 +1,2 @@
> +# A stub defintion that does nothing
> +AC_DEFUN([VALA_PROG_VAPIGEN],[])
> diff --git a/meta/recipes-devtools/vala/vala-stub.bb b/meta/recipes-devtools/vala/vala-stub.bb
> new file mode 100644
> index 0000000..6d5ff08
> --- /dev/null
> +++ b/meta/recipes-devtools/vala/vala-stub.bb
> @@ -0,0 +1,16 @@
> +SUMMARY = "Stub vala.m4 for building without vala support"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://vala.m4;md5=f38dd167c10adc458a1bcbc96443cdfa"
> +PROVIDES = "vala"
> +
> +SRC_URI = "file://vala.m4"
> +inherit allarch
> +
> +S = "${WORKDIR}"
> +
> +do_install() {
> +	install -d ${D}${datadir}/aclocal
> +	install -m 0644 ${WORKDIR}/vala.m4 ${D}${datadir}/aclocal/
> +}
> +
> +BBCLASSEXTEND = "native"
> -- 
> 1.7.10
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Ross Burton - Dec. 21, 2012, 5:21 p.m.
On 21 December 2012 13:12, Martin Jansa <martin.jansa@gmail.com> wrote:
> Doesn't this conflict with real vala-native?

Discussed with Martin, retracting this patch.

Ross

Patch

diff --git a/meta/recipes-devtools/vala/files/vala.m4 b/meta/recipes-devtools/vala/files/vala.m4
new file mode 100644
index 0000000..1776c6d
--- /dev/null
+++ b/meta/recipes-devtools/vala/files/vala.m4
@@ -0,0 +1,2 @@ 
+# A stub defintion that does nothing
+AC_DEFUN([VALA_PROG_VAPIGEN],[])
diff --git a/meta/recipes-devtools/vala/vala-stub.bb b/meta/recipes-devtools/vala/vala-stub.bb
new file mode 100644
index 0000000..6d5ff08
--- /dev/null
+++ b/meta/recipes-devtools/vala/vala-stub.bb
@@ -0,0 +1,16 @@ 
+SUMMARY = "Stub vala.m4 for building without vala support"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://vala.m4;md5=f38dd167c10adc458a1bcbc96443cdfa"
+PROVIDES = "vala"
+
+SRC_URI = "file://vala.m4"
+inherit allarch
+
+S = "${WORKDIR}"
+
+do_install() {
+	install -d ${D}${datadir}/aclocal
+	install -m 0644 ${WORKDIR}/vala.m4 ${D}${datadir}/aclocal/
+}
+
+BBCLASSEXTEND = "native"