Patchwork Removed undisplayed picture from connman-gnome

login
register
mail settings
Submitter Andrei Dinu
Date Dec. 17, 2012, 3:06 p.m.
Message ID <1355756780-12826-1-git-send-email-andrei.adrianx.dinu@intel.com>
Download mbox | patch
Permalink /patch/41209/
State New
Headers show

Comments

Andrei Dinu - Dec. 17, 2012, 3:06 p.m.
- removed the picture that doesn't display in the
connman-gnome "about" section.
- updated the recipe to use the patch when running bitbake
- created a folder with patches named "connman-gnome",
the same as for connman.

Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
---
 ...oved-icon-from-connman-gnome-about-applet.patch |   33 ++++++++++++++++++++
 .../connman/connman-gnome_0.7.bb                   |    3 +-
 2 files changed, 35 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-connectivity/connman/connman-gnome/0001-Removed-icon-from-connman-gnome-about-applet.patch
Saul Wold - Dec. 17, 2012, 6:03 p.m.
On 12/17/2012 07:06 AM, Andrei Dinu wrote:
> - removed the picture that doesn't display in the
> connman-gnome "about" section.
> - updated the recipe to use the patch when running bitbake
> - created a folder with patches named "connman-gnome",
> the same as for connman.
>
> Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
> ---
>   ...oved-icon-from-connman-gnome-about-applet.patch |   33 ++++++++++++++++++++
>   .../connman/connman-gnome_0.7.bb                   |    3 +-
>   2 files changed, 35 insertions(+), 1 deletion(-)
>   create mode 100644 meta/recipes-connectivity/connman/connman-gnome/0001-Removed-icon-from-connman-gnome-about-applet.patch
>
> diff --git a/meta/recipes-connectivity/connman/connman-gnome/0001-Removed-icon-from-connman-gnome-about-applet.patch b/meta/recipes-connectivity/connman/connman-gnome/0001-Removed-icon-from-connman-gnome-about-applet.patch
> new file mode 100644
> index 0000000..2a05e3c
> --- /dev/null
> +++ b/meta/recipes-connectivity/connman/connman-gnome/0001-Removed-icon-from-connman-gnome-about-applet.patch
> @@ -0,0 +1,33 @@
> +From 5907a23ad2f49702960a33f9e2039552673eabc7 Mon Sep 17 00:00:00 2001
> +From: Andrei Dinu <andrei.adrianx.dinu@intel.com>
> +Date: Mon, 17 Dec 2012 14:01:18 +0200
> +Subject: [PATCH] Removed icon from connman-gnome "about" applet
> +
> +The connman-gnome "about" applet showed a picture that
> +can not be displayed. There is no designated picture
> +in connman-gnome to be used in the about section, so
> +it was removed.
> +
> +[OE-Core #2509]
> +
Missing Upstream-Status: tag here, please add and submit v2

Sau!
> +Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
> +---
> + applet/main.c |    2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/applet/main.c b/applet/main.c
> +index f12d371..c7b3c7f 100644
> +--- a/applet/main.c
> ++++ b/applet/main.c
> +@@ -212,7 +212,7 @@ static void about_callback(GtkWidget *item, gpointer user_data)
> + 			"comments", _("A connection manager for the GNOME desktop"),
> + 			"authors", authors,
> + 			"translator-credits", _("translator-credits"),
> +-			"logo-icon-name", "network-wireless", NULL);
> ++			NULL);
> + }
> +
> + static void settings_callback(GtkWidget *item, gpointer user_data)
> +--
> +1.7.9.5
> +
> diff --git a/meta/recipes-connectivity/connman/connman-gnome_0.7.bb b/meta/recipes-connectivity/connman/connman-gnome_0.7.bb
> index 6cceb2d..1559a9d 100644
> --- a/meta/recipes-connectivity/connman/connman-gnome_0.7.bb
> +++ b/meta/recipes-connectivity/connman/connman-gnome_0.7.bb
> @@ -10,7 +10,8 @@ DEPENDS = "gtk+ dbus-glib"
>
>   # 0.7 tag
>   SRCREV = "cf3c325b23dae843c5499a113591cfbc98acb143"
> -SRC_URI = "git://github.com/connectivity/connman-gnome.git;protocol=git"
> +SRC_URI = "git://github.com/connectivity/connman-gnome.git;protocol=git \
> +	   file://0001-Removed-icon-from-connman-gnome-about-applet.patch"
>
>   S = "${WORKDIR}/git"
>
>

Patch

diff --git a/meta/recipes-connectivity/connman/connman-gnome/0001-Removed-icon-from-connman-gnome-about-applet.patch b/meta/recipes-connectivity/connman/connman-gnome/0001-Removed-icon-from-connman-gnome-about-applet.patch
new file mode 100644
index 0000000..2a05e3c
--- /dev/null
+++ b/meta/recipes-connectivity/connman/connman-gnome/0001-Removed-icon-from-connman-gnome-about-applet.patch
@@ -0,0 +1,33 @@ 
+From 5907a23ad2f49702960a33f9e2039552673eabc7 Mon Sep 17 00:00:00 2001
+From: Andrei Dinu <andrei.adrianx.dinu@intel.com>
+Date: Mon, 17 Dec 2012 14:01:18 +0200
+Subject: [PATCH] Removed icon from connman-gnome "about" applet
+
+The connman-gnome "about" applet showed a picture that
+can not be displayed. There is no designated picture
+in connman-gnome to be used in the about section, so
+it was removed.
+
+[OE-Core #2509]
+
+Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
+---
+ applet/main.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/applet/main.c b/applet/main.c
+index f12d371..c7b3c7f 100644
+--- a/applet/main.c
++++ b/applet/main.c
+@@ -212,7 +212,7 @@ static void about_callback(GtkWidget *item, gpointer user_data)
+ 			"comments", _("A connection manager for the GNOME desktop"),
+ 			"authors", authors,
+ 			"translator-credits", _("translator-credits"),
+-			"logo-icon-name", "network-wireless", NULL);
++			NULL);
+ }
+ 
+ static void settings_callback(GtkWidget *item, gpointer user_data)
+-- 
+1.7.9.5
+
diff --git a/meta/recipes-connectivity/connman/connman-gnome_0.7.bb b/meta/recipes-connectivity/connman/connman-gnome_0.7.bb
index 6cceb2d..1559a9d 100644
--- a/meta/recipes-connectivity/connman/connman-gnome_0.7.bb
+++ b/meta/recipes-connectivity/connman/connman-gnome_0.7.bb
@@ -10,7 +10,8 @@  DEPENDS = "gtk+ dbus-glib"
 
 # 0.7 tag
 SRCREV = "cf3c325b23dae843c5499a113591cfbc98acb143"
-SRC_URI = "git://github.com/connectivity/connman-gnome.git;protocol=git"
+SRC_URI = "git://github.com/connectivity/connman-gnome.git;protocol=git \
+	   file://0001-Removed-icon-from-connman-gnome-about-applet.patch"
 
 S = "${WORKDIR}/git"