| Submitter | Ciprian Ciubotariu |
|---|---|
| Date | Dec. 15, 2012, 12:50 a.m. |
| Message ID | <1355532614-5923-1-git-send-email-cheepeero@gmx.net> |
| Download | mbox | patch |
| Permalink | /patch/41083/ |
| State | New |
| Headers | show |
Comments
On Sat, Dec 15, 2012 at 02:50:14AM +0200, Ciprian Ciubotariu wrote: > This makes it consistent with packagegroup-core-base, and also avoids > unneeded dependencies towards sysvinit packages. > --- > .../packagegroups/packagegroup-base.bb | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb b/meta/recipes-core/packagegroups/packagegroup-base.bb > index 347a7e1..3e75190 100644 > --- a/meta/recipes-core/packagegroups/packagegroup-base.bb > +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb > @@ -141,7 +141,7 @@ RRECOMMENDS_packagegroup-machine-base = "${MACHINE_EXTRA_RRECOMMENDS}" > > SUMMARY_packagegroup-base-keyboard = "Keyboard support" > RDEPENDS_packagegroup-base-keyboard = "\ > - keymaps" > + ${VIRTUAL-RUNTIME_keymaps}" > > SUMMARY_packagegroup-base-pci = "PCI bus support" > RDEPENDS_packagegroup-base-pci = "\ Same comment as last time: http://patchwork.openembedded.org/patch/40649/ Cheers,
Please note that packagegroup-base also contains references to VIRTUAL-RUNTIME_apm and VIRTUAL-RUNTIME_alsa-state, which are not defined within the same recipe (I did a search to find a good place to add my own weak definition for keymaps).
On Tue, Dec 18, 2012 at 09:04:14AM +0200, Ciprian Ciubotariu wrote:
> Please note that packagegroup-base also contains references to VIRTUAL-RUNTIME_apm and VIRTUAL-RUNTIME_alsa-state, which are not defined within the same recipe (I did a search to find a good place to add my own weak definition for keymaps).
Those 2 have default values set in
meta/conf/distro/include/default-providers.inc
VIRTUAL-RUNTIME_keymaps has not.
Cheers,
Patch
diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb b/meta/recipes-core/packagegroups/packagegroup-base.bb index 347a7e1..3e75190 100644 --- a/meta/recipes-core/packagegroups/packagegroup-base.bb +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb @@ -141,7 +141,7 @@ RRECOMMENDS_packagegroup-machine-base = "${MACHINE_EXTRA_RRECOMMENDS}" SUMMARY_packagegroup-base-keyboard = "Keyboard support" RDEPENDS_packagegroup-base-keyboard = "\ - keymaps" + ${VIRTUAL-RUNTIME_keymaps}" SUMMARY_packagegroup-base-pci = "PCI bus support" RDEPENDS_packagegroup-base-pci = "\