Patchwork matchbox-keyboard: fix the build with libpng15

login
register
mail settings
Submitter Ross Burton
Date Dec. 12, 2012, 11:53 a.m.
Message ID <1355313237-32367-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/40809/
State Accepted
Commit db07a94e0fe400390e3bbe49a5be10aff1ea3619
Headers show

Comments

Ross Burton - Dec. 12, 2012, 11:53 a.m.
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 .../matchbox-keyboard/files/png-fix.patch          |   49 ++++++++++++++++++++
 .../matchbox-keyboard/matchbox-keyboard_git.bb     |    5 +-
 2 files changed, 52 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-sato/matchbox-keyboard/files/png-fix.patch

Patch

diff --git a/meta/recipes-sato/matchbox-keyboard/files/png-fix.patch b/meta/recipes-sato/matchbox-keyboard/files/png-fix.patch
new file mode 100644
index 0000000..e3834f5
--- /dev/null
+++ b/meta/recipes-sato/matchbox-keyboard/files/png-fix.patch
@@ -0,0 +1,49 @@ 
+Change matchbox-keyboard to look for "libpng" instead of "libpng12", and fix the
+code so that it works with the 1.2 and 1.5 API.
+
+Upstream-Status: Backport
+Signed-off-by: Ross Burton <ross.burton@intel.com>
+
+diff --git a/configure.ac b/configure.ac
+index 9678cf7..9bbbd76 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -171,24 +171,7 @@ dnl ------ Expat ------------------------------------------------------------
+ 
+ dnl ------ Check for PNG ---------------------------------------------------
+ 
+-AC_MSG_CHECKING(for libpng12)
+-
+-if $PKG_CONFIG --exists libpng12; then
+-        AC_MSG_RESULT(yes)
+-        PNG_LIBS=`$PKG_CONFIG --libs libpng12`
+-        PNG_CFLAGS=`$PKG_CONFIG --cflags libpng12`
+-else
+-        AC_MSG_RESULT(no)
+-        AC_CHECK_LIB([png], [png_create_read_struct],
+-                      [have_png="yes"], [have_png="no"])
+-
+-        if test x$have_png=xyes && test x$have_png_h=xyes; then
+-            PNG_LIBS="-lpng -lz"
+-        else
+-            AC_MSG_ERROR([*** Cannot find libpng12 ****])
+-        fi
+-fi
+-
++PKG_CHECK_MODULES(PNG, libpng)
+ 
+ dnl ------ Debug Build ------------------------------------------------------
+ 
+diff --git a/src/matchbox-keyboard-image.c b/src/matchbox-keyboard-image.c
+index 8accc3e..6b4b0e8 100644
+--- a/src/matchbox-keyboard-image.c
++++ b/src/matchbox-keyboard-image.c
+@@ -65,7 +65,7 @@ png_file_load (const char *file,
+     return NULL;
+   }
+ 
+-  if ( setjmp( png_ptr->jmpbuf ) ) {
++  if (setjmp (png_jmpbuf (png_ptr))) {
+     png_destroy_read_struct( &png_ptr, &info_ptr, NULL);
+     fclose(fd);
+     return NULL;
diff --git a/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb b/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb
index 430e343..adde25b 100644
--- a/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb
+++ b/meta/recipes-sato/matchbox-keyboard/matchbox-keyboard_git.bb
@@ -12,12 +12,13 @@  RDEPENDS_${PN} = "formfactor dbus-wait"
 SECTION = "x11"
 SRCREV = "b38f24036cff3be6c2fbcf9ca9881803e69003ac"
 PV = "0.0+git${SRCPV}"
-PR = "r3"
+PR = "r4"
 
 SRC_URI = "git://git.yoctoproject.org/${BPN};protocol=git \
            file://configure_fix.patch;maxrev=1819 \
            file://single-instance.patch \
-	   file://80matchboxkeyboard.shbg"
+           file://80matchboxkeyboard.shbg \
+           file://png-fix.patch"
 
 S = "${WORKDIR}/git"