Patchwork perf: kill -Werror

login
register
mail settings
Submitter Fahad Usman
Date Dec. 12, 2012, 7:08 a.m.
Message ID <1355296117-6980-1-git-send-email-fahad_usman@mentor.com>
Download mbox | patch
Permalink /patch/40781/
State Accepted
Commit dce7918a818bf86fcc11f561af3eacaf281403d4
Headers show

Comments

Fahad Usman - Dec. 12, 2012, 7:08 a.m.
this fails to build using a recent sourcery toolchain due to
unused-but-set-variable

Signed-off-by: Christopher Larson <chris_larson@mentor.com>

the patch was imported from meta-mentor layer on yoctoproject git server
http://git.yoctoproject.org/cgit/cgit.cgi/meta-mentor as of commit ids
82e96b3baa1c64d03412871fce56d496a338f167 and
ae325d011bd50501fe677c8b37295ae83030c526

Signed-off-by: Fahad Usman <fahad_usman@mentor.com>
---
 meta/recipes-kernel/perf/perf_3.4.bb |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Bruce Ashfield - Dec. 12, 2012, 12:42 p.m.
On Wed, Dec 12, 2012 at 2:08 AM, Fahad Usman <fahad_usman@mentor.com> wrote:

> this fails to build using a recent sourcery toolchain due to
> unused-but-set-variable
>
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
>
> the patch was imported from meta-mentor layer on yoctoproject git server
> http://git.yoctoproject.org/cgit/cgit.cgi/meta-mentor as of commit ids
> 82e96b3baa1c64d03412871fce56d496a338f167 and
> ae325d011bd50501fe677c8b37295ae83030c526
>
> Signed-off-by: Fahad Usman <fahad_usman@mentor.com>
> ---
>  meta/recipes-kernel/perf/perf_3.4.bb |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/perf/perf_3.4.bbb/meta/recipes-kernel/perf/
> perf_3.4.bb
> index b094362..4e6d03d 100644
> --- a/meta/recipes-kernel/perf/perf_3.4.bb
> +++ b/meta/recipes-kernel/perf/perf_3.4.bb
> @@ -9,7 +9,7 @@ as well."
>  LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
>
> -PR = "r5"
> +PR = "r6"
>
>  require perf.inc
>
> @@ -79,6 +79,10 @@ do_install() {
>         fi
>  }
>
> +do_configure_prepend () {
> +    sed -i 's,-Werror ,,' ${S}/tools/perf/Makefile
> +}
>

Is this still an outstanding issue in the latest kernel with perf ?
I don't mean the removal of the -Werror, but the unused variable ?
I'm just trying to make sure that a patch is going upstream to the source,
so
we can eventually drop something like this from the perf build.

Cheers,

Bruce


> +
>  PACKAGE_ARCH = "${MACHINE_ARCH}"
>
>  FILES_${PN} += "${libexecdir}/perf-core"
> --
> 1.7.9.5
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf_3.4.bb
index b094362..4e6d03d 100644
--- a/meta/recipes-kernel/perf/perf_3.4.bb
+++ b/meta/recipes-kernel/perf/perf_3.4.bb
@@ -9,7 +9,7 @@  as well."
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
 
-PR = "r5"
+PR = "r6"
 
 require perf.inc
 
@@ -79,6 +79,10 @@  do_install() {
 	fi
 }
 
+do_configure_prepend () {
+    sed -i 's,-Werror ,,' ${S}/tools/perf/Makefile
+}
+
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
 FILES_${PN} += "${libexecdir}/perf-core"