| Message ID | 20240311111359.1556157-1-u-kumar1@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | export ov10635 camera device tree overlay | expand |
Hi, Let's ensure we follow the subject prefix format. Target branch seems missing in subject. FYR, the format is - [meta-ti][list-of-branches-separated-by-slash][PATCH] title. Regards, Chirag On 11/03/24 16:44, Udit Kumar via lists.yoctoproject.org wrote: > Adding ov10635 camera overlay in default build Signed-off-by: Udit > Kumar <u-kumar1@ ti. com> --- > meta-ti-bsp/conf/machine/am57xx-evm. conf | 1 + 1 file changed, 1 > insertion(+) diff --git a/meta-ti-bsp/conf/machine/am57xx-evm. conf > b/meta-ti-bsp/conf/machine/am57xx-evm. conf > ZjQcmQRYFpfptBannerStart > This message was sent from outside of Texas Instruments. > Do not click links or open attachments unless you recognize the source > of this email and know the content is safe. > ZjQcmQRYFpfptBannerEnd > Adding ov10635 camera overlay in default build > > > Signed-off-by: Udit Kumar <u-kumar1@ti.com> > --- > meta-ti-bsp/conf/machine/am57xx-evm.conf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-ti-bsp/conf/machine/am57xx-evm.conf b/meta-ti-bsp/conf/machine/am57xx-evm.conf > index 43a6a833..9a06e801 100644 > --- a/meta-ti-bsp/conf/machine/am57xx-evm.conf > +++ b/meta-ti-bsp/conf/machine/am57xx-evm.conf > @@ -29,6 +29,7 @@ KERNEL_DEVICETREE = " \ > am57xx-beagle-x15-revc.dtb \ > am5729-beagleboneai.dtb \ > am571x-idk.dtb \ > + ov10635.dtbo \ > am572x-idk.dtb \ > am574x-idk.dtb \ > " > -- > 2.34.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#17505): https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-ti/message/17505__;!!G3vK!TADdqMpn2H5YJ-b59xsqjJuIel2SjGihTSatWzdgi2cIolJLVgzxURY9OBbPxyLLX05uu4SgMUsQEbYY8DdTwTWIPXQD9qpXifw$ > Mute This Topic: https://urldefense.com/v3/__https://lists.yoctoproject.org/mt/104860956/7030289__;!!G3vK!TADdqMpn2H5YJ-b59xsqjJuIel2SjGihTSatWzdgi2cIolJLVgzxURY9OBbPxyLLX05uu4SgMUsQEbYY8DdTwTWIPXQDmKciEdE$ > Group Owner: meta-ti+owner@lists.yoctoproject.org > Unsubscribe: https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-ti/unsub__;!!G3vK!TADdqMpn2H5YJ-b59xsqjJuIel2SjGihTSatWzdgi2cIolJLVgzxURY9OBbPxyLLX05uu4SgMUsQEbYY8DdTwTWIPXQDRlUJJP4$ [c-shilwant@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- >
We typically put the file grouping of the change in the commit message. For example: conf: machine: am57xx: export ov10635 camera device tree overlay On 3/11/2024 6:14 AM, Udit Kumar via lists.yoctoproject.org wrote: > Adding ov10635 camera overlay in default build > > > Signed-off-by: Udit Kumar <u-kumar1@ti.com> > --- > meta-ti-bsp/conf/machine/am57xx-evm.conf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-ti-bsp/conf/machine/am57xx-evm.conf b/meta-ti-bsp/conf/machine/am57xx-evm.conf > index 43a6a833..9a06e801 100644 > --- a/meta-ti-bsp/conf/machine/am57xx-evm.conf > +++ b/meta-ti-bsp/conf/machine/am57xx-evm.conf > @@ -29,6 +29,7 @@ KERNEL_DEVICETREE = " \ > am57xx-beagle-x15-revc.dtb \ > am5729-beagleboneai.dtb \ > am571x-idk.dtb \ > + ov10635.dtbo \ This change is not needed to get this overlay into the TI kernels. This is already included in the KERNEL_DEVICETREE_PREFIX variable and is part of the builds. The KERNEL_DEVICETREE is used to reference files that are upstreamed, which is seems on quick glance, that this overlay is not upstreamed. Were you seeing a problem that this patch is seeking to resolve? > am572x-idk.dtb \ > am574x-idk.dtb \ > " > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#17505): https://lists.yoctoproject.org/g/meta-ti/message/17505 > Mute This Topic: https://lists.yoctoproject.org/mt/104860956/6551054 > Group Owner: meta-ti+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [reatmon@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Hi Ryan On 3/11/2024 6:05 PM, Ryan Eatmon wrote: > > We typically put the file grouping of the change in the commit > message. For example: > > conf: machine: am57xx: export ov10635 camera device tree overlay > > > On 3/11/2024 6:14 AM, Udit Kumar via lists.yoctoproject.org wrote: >> Adding ov10635 camera overlay in default build >> >> >> Signed-off-by: Udit Kumar <u-kumar1@ti.com> >> --- >> meta-ti-bsp/conf/machine/am57xx-evm.conf | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/meta-ti-bsp/conf/machine/am57xx-evm.conf >> b/meta-ti-bsp/conf/machine/am57xx-evm.conf >> index 43a6a833..9a06e801 100644 >> --- a/meta-ti-bsp/conf/machine/am57xx-evm.conf >> +++ b/meta-ti-bsp/conf/machine/am57xx-evm.conf >> @@ -29,6 +29,7 @@ KERNEL_DEVICETREE = " \ >> am57xx-beagle-x15-revc.dtb \ >> am5729-beagleboneai.dtb \ >> am571x-idk.dtb \ >> + ov10635.dtbo \ > > This change is not needed to get this overlay into the TI kernels. > This is already included in the KERNEL_DEVICETREE_PREFIX variable and > is part of the builds. The KERNEL_DEVICETREE is used to reference > files that are upstreamed, which is seems on quick glance, that this > overlay is not upstreamed. > Yes, this overlay is not upstreamed and present in ti kernels > Were you seeing a problem that this patch is seeking to resolve? I am not able to get this overlay as part of yocto build. So I am planning to export this dtbo into build > > >> am572x-idk.dtb \ >> am574x-idk.dtb \ >> " >> >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#17505): >> https://lists.yoctoproject.org/g/meta-ti/message/17505 >> Mute This Topic: https://lists.yoctoproject.org/mt/104860956/6551054 >> Group Owner: meta-ti+owner@lists.yoctoproject.org >> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub >> [reatmon@ti.com] >> -=-=-=-=-=-=-=-=-=-=-=- >> >
Hi Ryan On 3/11/2024 8:35 PM, Udit Kumar via lists.yoctoproject.org wrote: > Hi Ryan > > On 3/11/2024 6:05 PM, Ryan Eatmon wrote: >> >> We typically put the file grouping of the change in the commit >> message. For example: >> >> conf: machine: am57xx: export ov10635 camera device tree overlay >> >> >> On 3/11/2024 6:14 AM, Udit Kumar via lists.yoctoproject.org wrote: >>> Adding ov10635 camera overlay in default build >>> >>> >>> Signed-off-by: Udit Kumar <u-kumar1@ti.com> >>> --- >>> meta-ti-bsp/conf/machine/am57xx-evm.conf | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/meta-ti-bsp/conf/machine/am57xx-evm.conf >>> b/meta-ti-bsp/conf/machine/am57xx-evm.conf >>> index 43a6a833..9a06e801 100644 >>> --- a/meta-ti-bsp/conf/machine/am57xx-evm.conf >>> +++ b/meta-ti-bsp/conf/machine/am57xx-evm.conf >>> @@ -29,6 +29,7 @@ KERNEL_DEVICETREE = " \ >>> am57xx-beagle-x15-revc.dtb \ >>> am5729-beagleboneai.dtb \ >>> am571x-idk.dtb \ >>> + ov10635.dtbo \ >> >> This change is not needed to get this overlay into the TI kernels. >> This is already included in the KERNEL_DEVICETREE_PREFIX variable and >> is part of the builds. The KERNEL_DEVICETREE is used to reference >> files that are upstreamed, which is seems on quick glance, that this >> overlay is not upstreamed. >> > Yes, this overlay is not upstreamed and present in ti kernels are you ok to accept ti specific files , if yes I will send v2. Thanks Udit > > >> Were you seeing a problem that this patch is seeking to resolve? > > > I am not able to get this overlay as part of yocto build. So I am > planning to export this dtbo into build > > >> >> >>> am572x-idk.dtb \ >>> am574x-idk.dtb \ >>> " >>> >>> >>> >>> >>> >> > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#17508): https://lists.yoctoproject.org/g/meta-ti/message/17508 > Mute This Topic: https://lists.yoctoproject.org/mt/104860956/7571657 > Group Owner: meta-ti+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [u-kumar1@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta-ti-bsp/conf/machine/am57xx-evm.conf b/meta-ti-bsp/conf/machine/am57xx-evm.conf index 43a6a833..9a06e801 100644 --- a/meta-ti-bsp/conf/machine/am57xx-evm.conf +++ b/meta-ti-bsp/conf/machine/am57xx-evm.conf @@ -29,6 +29,7 @@ KERNEL_DEVICETREE = " \ am57xx-beagle-x15-revc.dtb \ am5729-beagleboneai.dtb \ am571x-idk.dtb \ + ov10635.dtbo \ am572x-idk.dtb \ am574x-idk.dtb \ "
Adding ov10635 camera overlay in default build Signed-off-by: Udit Kumar <u-kumar1@ti.com> --- meta-ti-bsp/conf/machine/am57xx-evm.conf | 1 + 1 file changed, 1 insertion(+)