Patchwork [meta-xfce] xfce4-session: Add depends to iceauth-native

login
register
mail settings
Submitter Samuel Stirtzel
Date Dec. 11, 2012, 10:49 a.m.
Message ID <1355222976-14461-1-git-send-email-s.stirtzel@googlemail.com>
Download mbox | patch
Permalink /patch/40743/
State Superseded, archived
Headers show

Comments

Samuel Stirtzel - Dec. 11, 2012, 10:49 a.m.
xfce4-session depends on iceauth for do_configure

This fixes:
checking for iceauth... /usr/bin/iceauth

And it fixes for X-less systems:
checking for iceauth... no
configure: error: iceauth missing, please check your X11 installation

Signed-off-by: Samuel Stirtzel <s.stirtzel@googlemail.com>
---
 .../xfce4-session/xfce4-session_4.10.0.bb          |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Andreas Müller - Dec. 11, 2012, 5:58 p.m.
On Tue, Dec 11, 2012 at 11:49 AM, Samuel Stirtzel
<s.stirtzel@googlemail.com> wrote:
> xfce4-session depends on iceauth for do_configure
>
> This fixes:
> checking for iceauth... /usr/bin/iceauth
>
> And it fixes for X-less systems:
> checking for iceauth... no
> configure: error: iceauth missing, please check your X11 installation
>
> Signed-off-by: Samuel Stirtzel <s.stirtzel@googlemail.com>
> ---
>  .../xfce4-session/xfce4-session_4.10.0.bb          |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.0.bb b/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.0.bb
> index 4df9894..136e928 100644
> --- a/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.0.bb
> +++ b/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.0.bb
> @@ -2,9 +2,11 @@ DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment
>  SECTION = "x11"
>  LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=9ac2e7cff1ddaf48b6eab6028f23ef88"
> -DEPENDS = "virtual/libx11 libsm libxfce4util libxfce4ui gtk+ libwnck dbus dbus-glib xfconf gnome-keyring"
> +DEPENDS = "virtual/libx11 libsm libxfce4util libxfce4ui gtk+ libwnck dbus dbus-glib xfconf gnome-keyring iceauth-native"
>  RDEPENDS_${PN} = "netbase xinit dbus-x11 iceauth consolekit upower"
>
> +PR = "r1"
> +
>  inherit xfce
>
>  SRC_URI[md5sum] = "4768e1a41a0287af6aad18b329a0f230"
> --
> 1.7.9.5
Acked-by: Andreas Müller <schnitzeltony@googlemail.com>
Andreas Müller - Dec. 13, 2012, 5:50 p.m.
On Tue, Dec 11, 2012 at 6:58 PM, Andreas Müller
<schnitzeltony@googlemail.com> wrote:
> On Tue, Dec 11, 2012 at 11:49 AM, Samuel Stirtzel
> <s.stirtzel@googlemail.com> wrote:
>> xfce4-session depends on iceauth for do_configure
>>
>> This fixes:
>> checking for iceauth... /usr/bin/iceauth
>>
>> And it fixes for X-less systems:
>> checking for iceauth... no
>> configure: error: iceauth missing, please check your X11 installation
>>
>> Signed-off-by: Samuel Stirtzel <s.stirtzel@googlemail.com>
>> ---
>>  .../xfce4-session/xfce4-session_4.10.0.bb          |    4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.0.bb b/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.0.bb
>> index 4df9894..136e928 100644
>> --- a/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.0.bb
>> +++ b/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.0.bb
>> @@ -2,9 +2,11 @@ DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment
>>  SECTION = "x11"
>>  LICENSE = "GPLv2"
>>  LIC_FILES_CHKSUM = "file://COPYING;md5=9ac2e7cff1ddaf48b6eab6028f23ef88"
>> -DEPENDS = "virtual/libx11 libsm libxfce4util libxfce4ui gtk+ libwnck dbus dbus-glib xfconf gnome-keyring"
>> +DEPENDS = "virtual/libx11 libsm libxfce4util libxfce4ui gtk+ libwnck dbus dbus-glib xfconf gnome-keyring iceauth-native"
>>  RDEPENDS_${PN} = "netbase xinit dbus-x11 iceauth consolekit upower"
>>
>> +PR = "r1"
>> +
>>  inherit xfce
>>
>>  SRC_URI[md5sum] = "4768e1a41a0287af6aad18b329a0f230"
>> --
>> 1.7.9.5
> Acked-by: Andreas Müller <schnitzeltony@googlemail.com>
Sorry, but my ACK  was too early and turns into NAK. It now tries to
run a command in native sysroot ( do a grep for ICEAUTH_CMD in
sourcedir ).

Andreas

Patch

diff --git a/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.0.bb b/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.0.bb
index 4df9894..136e928 100644
--- a/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.0.bb
+++ b/meta-xfce/recipes-xfce/xfce4-session/xfce4-session_4.10.0.bb
@@ -2,9 +2,11 @@  DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment
 SECTION = "x11"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=9ac2e7cff1ddaf48b6eab6028f23ef88"
-DEPENDS = "virtual/libx11 libsm libxfce4util libxfce4ui gtk+ libwnck dbus dbus-glib xfconf gnome-keyring"
+DEPENDS = "virtual/libx11 libsm libxfce4util libxfce4ui gtk+ libwnck dbus dbus-glib xfconf gnome-keyring iceauth-native"
 RDEPENDS_${PN} = "netbase xinit dbus-x11 iceauth consolekit upower"
 
+PR = "r1"
+
 inherit xfce
 
 SRC_URI[md5sum] = "4768e1a41a0287af6aad18b329a0f230"