Patchwork wireless-tools: Remove QA warning: No GNU_HASH in the elf binary

login
register
mail settings
Submitter Shakeel, Muhammad
Date Dec. 11, 2012, 10:08 a.m.
Message ID <1355220496-8878-1-git-send-email-muhammad_shakeel@mentor.com>
Download mbox | patch
Permalink /patch/40737/
State New
Headers show

Comments

Shakeel, Muhammad - Dec. 11, 2012, 10:08 a.m.
From: Muhammad Shakeel <muhammad_shakeel@mentor.com>

Handle LDFLAGS properly in the Makefile to remove warning:
QA Issue: No GNU_HASH in the elf binary

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
---
 .../wireless-tools/wireless-tools/ldflags.patch    |   15 +++++++++++++++
 .../wireless-tools/wireless-tools_29.bb            |    3 ++-
 2 files changed, 17 insertions(+), 1 deletion(-)
Saul Wold - Dec. 11, 2012, 6:48 p.m.
On 12/11/2012 02:08 AM, Shakeel, Muhammad wrote:
> From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
>
> Handle LDFLAGS properly in the Makefile to remove warning:
> QA Issue: No GNU_HASH in the elf binary
>
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> ---
>   .../wireless-tools/wireless-tools/ldflags.patch    |   15 +++++++++++++++
>   .../wireless-tools/wireless-tools_29.bb            |    3 ++-
>   2 files changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/wireless-tools/wireless-tools/ldflags.patch b/meta/recipes-connectivity/wireless-tools/wireless-tools/ldflags.patch
> new file mode 100644
> index 0000000..84144ac
> --- /dev/null
> +++ b/meta/recipes-connectivity/wireless-tools/wireless-tools/ldflags.patch
> @@ -0,0 +1,15 @@

No patch header

Please add a Signed-off-by: and Upstream-Status: tags

Thanks
	Sau!

> +---
> + Makefile |    2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +--- wireless_tools.29.orig/Makefile
> ++++ wireless_tools.29/Makefile
> +@@ -144,7 +144,7 @@ wireless.h:
> +
> + # Compilation of the dynamic library
> + $(DYNAMIC): $(OBJS:.o=.so)
> +-	$(CC) -shared -o $@ -Wl,-soname,$@ $(STRIPFLAGS) $(LIBS) -lc $^
> ++	$(CC) -shared -o $@ -Wl,-soname,$@ $(LDFLAGS) $(STRIPFLAGS) $(LIBS) -lc $^
> +
> + # Compilation of the static library
> + $(STATIC): $(OBJS:.o=.so)
> diff --git a/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb b/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb
> index 209f29a..b4d34bb 100644
> --- a/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb
> +++ b/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb
> @@ -14,7 +14,8 @@ SRC_URI = "http://www.hpl.hp.com/personal/Jean_Tourrilhes/Linux/wireless_tools.2
>   	   file://man.patch \
>   	   file://wireless-tools.if-pre-up \
>   	   file://zzz-wireless.if-pre-up \
> -	   file://avoid_strip.patch"
> +	   file://avoid_strip.patch \
> +	   file://ldflags.patch"
>
>   SRC_URI[md5sum] = "e06c222e186f7cc013fd272d023710cb"
>   SRC_URI[sha256sum] = "6fb80935fe208538131ce2c4178221bab1078a1656306bce8909c19887e2e5a1"
>

Patch

diff --git a/meta/recipes-connectivity/wireless-tools/wireless-tools/ldflags.patch b/meta/recipes-connectivity/wireless-tools/wireless-tools/ldflags.patch
new file mode 100644
index 0000000..84144ac
--- /dev/null
+++ b/meta/recipes-connectivity/wireless-tools/wireless-tools/ldflags.patch
@@ -0,0 +1,15 @@ 
+---
+ Makefile |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- wireless_tools.29.orig/Makefile
++++ wireless_tools.29/Makefile
+@@ -144,7 +144,7 @@ wireless.h:
+ 
+ # Compilation of the dynamic library
+ $(DYNAMIC): $(OBJS:.o=.so)
+-	$(CC) -shared -o $@ -Wl,-soname,$@ $(STRIPFLAGS) $(LIBS) -lc $^
++	$(CC) -shared -o $@ -Wl,-soname,$@ $(LDFLAGS) $(STRIPFLAGS) $(LIBS) -lc $^
+ 
+ # Compilation of the static library
+ $(STATIC): $(OBJS:.o=.so)
diff --git a/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb b/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb
index 209f29a..b4d34bb 100644
--- a/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb
+++ b/meta/recipes-connectivity/wireless-tools/wireless-tools_29.bb
@@ -14,7 +14,8 @@  SRC_URI = "http://www.hpl.hp.com/personal/Jean_Tourrilhes/Linux/wireless_tools.2
 	   file://man.patch \
 	   file://wireless-tools.if-pre-up \
 	   file://zzz-wireless.if-pre-up \
-	   file://avoid_strip.patch"
+	   file://avoid_strip.patch \
+	   file://ldflags.patch"
 
 SRC_URI[md5sum] = "e06c222e186f7cc013fd272d023710cb"
 SRC_URI[sha256sum] = "6fb80935fe208538131ce2c4178221bab1078a1656306bce8909c19887e2e5a1"