| Submitter | Laurentiu Palcu |
|---|---|
| Date | Dec. 10, 2012, 4:09 p.m. |
| Message ID | <d5c9acb38b6e2d962818f15119bb6748d1320dff.1355154246.git.laurentiu.palcu@intel.com> |
| Download | mbox | patch |
| Permalink | /patch/40701/ |
| State | Accepted |
| Commit | 06151c34f4f4cb669b2f93ebb2f78cfecf698355 |
| Headers | show |
Comments
On Mon, Dec 10, 2012 at 2:09 PM, Laurentiu Palcu <laurentiu.palcu@intel.com>wrote: > In order for the postinstall scripts to have access to the recent > improvements when generating the target SDK sysroot, export these > variables in populate_sdk. > > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com> > ... + export NATIVE_ROOT=${STAGING_DIR_NATIVE} > ... > Why you don't use STAGING_DIR_NATIVE directly? This seems to have no good reason for a variable with same content of a well known variable. Regards,
On 12/10/2012 08:19 AM, Otavio Salvador wrote: > > > > On Mon, Dec 10, 2012 at 2:09 PM, Laurentiu Palcu > <laurentiu.palcu@intel.com <mailto:laurentiu.palcu@intel.com>> wrote: > > In order for the postinstall scripts to have access to the recent > improvements when generating the target SDK sysroot, export these > variables in populate_sdk. > > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com > <mailto:laurentiu.palcu@intel.com>> > ... > > + export NATIVE_ROOT=${STAGING_DIR_NATIVE} > ... > > > Why you don't use STAGING_DIR_NATIVE directly? This seems to have no > good reason for a variable with same content of a well known variable. > I believe that Richard already commented on this naming and agrees that we need both. Sau! > Regards, > > -- > Otavio Salvador O.S. Systems > E-mail: otavio@ossystems.com.br <mailto:otavio@ossystems.com.br> > http://www.ossystems.com.br > Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >
Patch
diff --git a/meta/classes/populate_sdk_deb.bbclass b/meta/classes/populate_sdk_deb.bbclass index f2d0621..1e28b61 100644 --- a/meta/classes/populate_sdk_deb.bbclass +++ b/meta/classes/populate_sdk_deb.bbclass @@ -34,6 +34,8 @@ populate_sdk_deb () { export INSTALL_PACKAGES_ATTEMPTONLY_DEB="${TOOLCHAIN_TARGET_TASK_ATTEMPTONLY}" export PACKAGES_LINGUAS_DEB="" export INSTALL_TASK_DEB="populate_sdk-target" + export INTERCEPT_DIR=${WORKDIR}/intercept_scripts + export NATIVE_ROOT=${STAGING_DIR_NATIVE} package_install_internal_deb diff --git a/meta/classes/populate_sdk_ipk.bbclass b/meta/classes/populate_sdk_ipk.bbclass index 65a95e7..3a5ecda 100644 --- a/meta/classes/populate_sdk_ipk.bbclass +++ b/meta/classes/populate_sdk_ipk.bbclass @@ -26,6 +26,8 @@ populate_sdk_ipk() { export OFFLINE_ROOT=${INSTALL_ROOTFS_IPK} export IPKG_OFFLINE_ROOT=${INSTALL_ROOTFS_IPK} export OPKG_OFFLINE_ROOT=${IPKG_OFFLINE_ROOT} + export INTERCEPT_DIR=${WORKDIR}/intercept_scripts + export NATIVE_ROOT=${STAGING_DIR_NATIVE} package_install_internal_ipk diff --git a/meta/classes/populate_sdk_rpm.bbclass b/meta/classes/populate_sdk_rpm.bbclass index 1c54049..b5aa601 100644 --- a/meta/classes/populate_sdk_rpm.bbclass +++ b/meta/classes/populate_sdk_rpm.bbclass @@ -40,6 +40,8 @@ populate_sdk_rpm () { export INSTALL_PROVIDENAME_RPM="/bin/sh /bin/bash /usr/bin/env /usr/bin/perl pkgconfig pkgconfig(pkg-config)" export INSTALL_TASK_RPM="populate_sdk-target" export INSTALL_COMPLEMENTARY_RPM="" + export INTERCEPT_DIR=${WORKDIR}/intercept_scripts + export NATIVE_ROOT=${STAGING_DIR_NATIVE} # Setup base system configuration mkdir -p ${INSTALL_ROOTFS_RPM}/etc/rpm/
In order for the postinstall scripts to have access to the recent improvements when generating the target SDK sysroot, export these variables in populate_sdk. Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com> --- meta/classes/populate_sdk_deb.bbclass | 2 ++ meta/classes/populate_sdk_ipk.bbclass | 2 ++ meta/classes/populate_sdk_rpm.bbclass | 2 ++ 3 files changed, 6 insertions(+)