Patchwork documentation-audit.sh: Add/fix checks for skipped lines.

login
register
mail settings
Submitter Robert P. J. Day
Date Dec. 9, 2012, 12:39 p.m.
Message ID <alpine.DEB.2.02.1212090736560.4965@oneiric>
Download mbox | patch
Permalink /patch/40671/
State New
Headers show

Comments

Robert P. J. Day - Dec. 9, 2012, 12:39 p.m.
Have the script skip:

  * "Recipe" lines.
  * Lines with 11 "=", not 12.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  if scott wants to adjust this differently, it's all his.
Scott Garman - Dec. 9, 2012, 7:42 p.m.
On 12/09/2012 04:39 AM, Robert P. J. Day wrote:
>
> Have the script skip:
>
>    * "Recipe" lines.
>    * Lines with 11 "=", not 12.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

Yeah, I haven't run this script since we switched to the knotty2 
interface. If you've tested this, I'm okay with the changes.

Scott

>
> ---
>
>    if scott wants to adjust this differently, it's all his.
>
> diff --git a/scripts/contrib/documentation-audit.sh b/scripts/contrib/documentation-audit.sh
> index a2c4586..2144aac 100755
> --- a/scripts/contrib/documentation-audit.sh
> +++ b/scripts/contrib/documentation-audit.sh
> @@ -30,9 +30,10 @@ echo " you'll get false positives.  For example, LICENSE_FLAGS_WHITELIST = \"Com
>
>   for pkg in `bitbake -s | awk '{ print \$1 }'`; do
>   	if [[ "$pkg" == "Loading" || "$pkg" == "Loaded" ||
> +	  "$pkg" == "Recipe"  ||
>             "$pkg" == "Parsing" || "$pkg" == "Package" ||
>             "$pkg" == "NOTE:"   || "$pkg" == "WARNING:" ||
> -          "$pkg" == "done."   || "$pkg" == "============" ]]
> +          "$pkg" == "done."   || "$pkg" == "===========" ]]
>   	then
>   		# Skip initial bitbake output
>   		continue
>
Robert P. J. Day - Dec. 9, 2012, 7:44 p.m.
On Sun, 9 Dec 2012, Scott Garman wrote:

> On 12/09/2012 04:39 AM, Robert P. J. Day wrote:
> >
> > Have the script skip:
> >
> >    * "Recipe" lines.
> >    * Lines with 11 "=", not 12.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> Yeah, I haven't run this script since we switched to the knotty2
> interface. If you've tested this, I'm okay with the changes.

  as far as i can tell, its only effect is to remove those two lines
that shouldn't be there, that's what i verified.

rday

Patch

diff --git a/scripts/contrib/documentation-audit.sh b/scripts/contrib/documentation-audit.sh
index a2c4586..2144aac 100755
--- a/scripts/contrib/documentation-audit.sh
+++ b/scripts/contrib/documentation-audit.sh
@@ -30,9 +30,10 @@  echo " you'll get false positives.  For example, LICENSE_FLAGS_WHITELIST = \"Com

 for pkg in `bitbake -s | awk '{ print \$1 }'`; do
 	if [[ "$pkg" == "Loading" || "$pkg" == "Loaded" ||
+	  "$pkg" == "Recipe"  ||
           "$pkg" == "Parsing" || "$pkg" == "Package" ||
           "$pkg" == "NOTE:"   || "$pkg" == "WARNING:" ||
-          "$pkg" == "done."   || "$pkg" == "============" ]]
+          "$pkg" == "done."   || "$pkg" == "===========" ]]
 	then
 		# Skip initial bitbake output
 		continue