Patchwork packagroup-base: use virtual runtime instead of keymap

login
register
mail settings
Submitter Ciprian Ciubotariu
Date Dec. 7, 2012, 2:44 p.m.
Message ID <1354891455-6846-1-git-send-email-cheepeero@gmx.net>
Download mbox | patch
Permalink /patch/40649/
State New
Headers show

Comments

Ciprian Ciubotariu - Dec. 7, 2012, 2:44 p.m.
---
 .../packagegroups/packagegroup-base.bb             |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Martin Jansa - Dec. 11, 2012, 9:18 a.m.
On Fri, Dec 07, 2012 at 04:44:15PM +0200, Ciprian Ciubotariu wrote:
> ---
>  .../packagegroups/packagegroup-base.bb             |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb b/meta/recipes-core/packagegroups/packagegroup-base.bb
> index 347a7e1..3e75190 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> @@ -141,7 +141,7 @@ RRECOMMENDS_packagegroup-machine-base = "${MACHINE_EXTRA_RRECOMMENDS}"
>  
>  SUMMARY_packagegroup-base-keyboard = "Keyboard support"
>  RDEPENDS_packagegroup-base-keyboard = "\
> -    keymaps"
> +    ${VIRTUAL-RUNTIME_keymaps}"

you need to specify default value with weak assignment like
packagegroup-core-boot.bb does

Cheers,

>  
>  SUMMARY_packagegroup-base-pci = "PCI bus support"
>  RDEPENDS_packagegroup-base-pci = "\
> -- 
> 1.7.8.6
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Paul Eggleton - Dec. 11, 2012, 9:28 a.m.
On Tuesday 11 December 2012 10:18:41 Martin Jansa wrote:
> On Fri, Dec 07, 2012 at 04:44:15PM +0200, Ciprian Ciubotariu wrote:
> > ---
> > 
> >  .../packagegroups/packagegroup-base.bb             |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > b/meta/recipes-core/packagegroups/packagegroup-base.bb index
> > 347a7e1..3e75190 100644
> > --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> > @@ -141,7 +141,7 @@ RRECOMMENDS_packagegroup-machine-base =
> > "${MACHINE_EXTRA_RRECOMMENDS}"> 
> >  SUMMARY_packagegroup-base-keyboard = "Keyboard support"
> >  RDEPENDS_packagegroup-base-keyboard = "\
> > 
> > -    keymaps"
> > +    ${VIRTUAL-RUNTIME_keymaps}"
> 
> you need to specify default value with weak assignment like
> packagegroup-core-boot.bb does

Also, could you please include a commit message explaining why this is needed?

Thanks,
Paul
Paul Eggleton - Dec. 11, 2012, 9:30 a.m.
On Tuesday 11 December 2012 09:28:47 Paul Eggleton wrote:
> On Tuesday 11 December 2012 10:18:41 Martin Jansa wrote:
> > On Fri, Dec 07, 2012 at 04:44:15PM +0200, Ciprian Ciubotariu wrote:
> > > ---
> > > 
> > >  .../packagegroups/packagegroup-base.bb             |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > > b/meta/recipes-core/packagegroups/packagegroup-base.bb index
> > > 347a7e1..3e75190 100644
> > > --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > > +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> > > @@ -141,7 +141,7 @@ RRECOMMENDS_packagegroup-machine-base =
> > > "${MACHINE_EXTRA_RRECOMMENDS}">
> > > 
> > >  SUMMARY_packagegroup-base-keyboard = "Keyboard support"
> > >  RDEPENDS_packagegroup-base-keyboard = "\
> > > 
> > > -    keymaps"
> > > +    ${VIRTUAL-RUNTIME_keymaps}"
> > 
> > you need to specify default value with weak assignment like
> > packagegroup-core-boot.bb does
> 
> Also, could you please include a commit message explaining why this is
> needed?

Ah, well; not so much why this is needed but explaining that this makes it 
consistent with packagegroup-core-boot.

Cheers,
Paul

Patch

diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb b/meta/recipes-core/packagegroups/packagegroup-base.bb
index 347a7e1..3e75190 100644
--- a/meta/recipes-core/packagegroups/packagegroup-base.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
@@ -141,7 +141,7 @@  RRECOMMENDS_packagegroup-machine-base = "${MACHINE_EXTRA_RRECOMMENDS}"
 
 SUMMARY_packagegroup-base-keyboard = "Keyboard support"
 RDEPENDS_packagegroup-base-keyboard = "\
-    keymaps"
+    ${VIRTUAL-RUNTIME_keymaps}"
 
 SUMMARY_packagegroup-base-pci = "PCI bus support"
 RDEPENDS_packagegroup-base-pci = "\