From patchwork Thu Dec 6 11:11:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: buildhistory_analysis: fix broken list length checks Date: Thu, 06 Dec 2012 11:11:51 -0000 From: Paul Eggleton X-Patchwork-Id: 40561 Message-Id: <1354792311-17216-1-git-send-email-paul.eggleton@linux.intel.com> To: openembedded-core@lists.openembedded.org Fix erroneous use of .count instead of len(), which unfortunately is not reported by Python as an error in a numeric comparison. Signed-off-by: Paul Eggleton --- meta/lib/oe/buildhistory_analysis.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/lib/oe/buildhistory_analysis.py b/meta/lib/oe/buildhistory_analysis.py index ad57f00..7b5ee45 100644 --- a/meta/lib/oe/buildhistory_analysis.py +++ b/meta/lib/oe/buildhistory_analysis.py @@ -185,7 +185,7 @@ def blob_to_dict(blob): adict = {} for line in alines: splitv = [i.strip() for i in line.split('=',1)] - if splitv.count > 1: + if len(splitv) > 1: adict[splitv[0]] = splitv[1] return adict @@ -231,7 +231,7 @@ def compare_file_lists(alines, blines): filechanges.append(FileChange(path, FileChange.changetype_ownergroup, oldvalue, newvalue)) # Check symlink target if newsplitv[0][0] == 'l': - if splitv.count > 3: + if len(splitv) > 3: oldvalue = splitv[3] else: oldvalue = None