Patchwork [v2,1/1] create-pull-request: detect trailing white space

login
mail settings
Submitter Nitin A Kamble
Date Dec. 5, 2012, 11:47 p.m.
Message ID <5dd4b0df68ba17cf9cc6892040f8ab90b66dd911.1354751008.git.nitin.a.kamble@intel.com>
Download mbox | patch
Permalink /patch/40537/
State New
Headers show

Comments

Nitin A Kamble - Dec. 5, 2012, 11:47 p.m.
From: Nitin A Kamble <nitin.a.kamble@intel.com>

Add logic in the create-pull-request to detect the trailing white space
inserted by patches.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 scripts/create-pull-request |   13 ++++++++++++-
 1 files changed, 12 insertions(+), 1 deletions(-)

Patch

diff --git a/scripts/create-pull-request b/scripts/create-pull-request
index 9a8913d..58e7df1 100755
--- a/scripts/create-pull-request
+++ b/scripts/create-pull-request
@@ -173,7 +173,6 @@  mkdir $ODIR
 # Generate the patches and cover letter
 git format-patch -M40 --subject-prefix="$PREFIX" -n -o $ODIR --thread=shallow --cover-letter $RELATIVE_TO..$COMMIT_ID > /dev/null
 
-
 # Customize the cover letter
 CL="$ODIR/0000-cover-letter.patch"
 PM="$ODIR/pull-msg"
@@ -229,3 +228,15 @@  Review their content, especially the summary mail:
 When you are satisfied, you can send them with:
     send-pull-request -a -p $ODIR
 EOM
+
+# Check the patches for trailing white space
+echo
+egrep -nH -e "^\+.*\s+$" $ODIR/* > /dev/null
+if [ $? -ne 1 ]; then
+	echo "WARNING: Trailing white space detected at these locations"
+	egrep -nH -e "^\+.*\s+$" $ODIR/*
+else
+	echo "Note: No trailing white space is detected in these patches :)"
+fi
+
+