From patchwork Tue Mar 5 15:27:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoann CONGAL X-Patchwork-Id: 40479 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 599E9C54E41 for ; Tue, 5 Mar 2024 15:28:25 +0000 (UTC) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mx.groups.io with SMTP id smtpd.web11.26303.1709652495050209939 for ; Tue, 05 Mar 2024 07:28:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@smile-fr.20230601.gappssmtp.com header.s=20230601 header.b=0q2z3gsd; spf=pass (domain: smile.fr, ip: 209.85.128.44, mailfrom: yoann.congal@smile.fr) Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-412ecc1064cso6450465e9.2 for ; Tue, 05 Mar 2024 07:28:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smile-fr.20230601.gappssmtp.com; s=20230601; t=1709652492; x=1710257292; darn=lists.openembedded.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MctOoIBJ4EJUSM63PM914+RdyOPtyB9mWo9oOcGiDe0=; b=0q2z3gsdz6oDccbMrIe3cNOflybAtP77LiUBxWjnO6i9SEXffVK4JAyCL0Rvk4o63N O2ZGiD9CjW3gVDrmpeRx/3KKzF5JxN+y6Tv6dZSUPCFo+H0Bc6/o4aETFAsJEYAiOP72 ahh0zUdr4RxQVbpYTNbj/lF7PVMgICLhyy5hY/1m49Ny4Mcy6XQHE83peyx62WGVzQH6 eJyp29FHNd6VO/RtN3BrynpkYLSv+HjU6i2du9nuAdYgmxRK/bFeNdCi71f6iD6F2to2 kZlncA2fUSHWn3viabYx0TjUT+nv+VnB1LiTbuAD7miGfLO7sLyKFVCiyB3E+MZk52vM jQeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709652492; x=1710257292; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MctOoIBJ4EJUSM63PM914+RdyOPtyB9mWo9oOcGiDe0=; b=lfG/N8U8wHxybpWocXNqpJsl9VJfJ10x7eqfYgtQH05L7KDaxJv5xYbTlRC6Bgpd5P XlS6rQ5NOBu59eHRRGe2dr5OAwwensSoYUQaVDg8BUi1dxHsAc4UQgVZijgY6jN4FLdn aBEWAKoQU2n3YrQZkKBkTLg0CvvtvFK6RbesuVECo6jtRCxhS440oyuSDTZqvoGIz7TB gS9rxAVg+fsXtQ0ntWk/kYRQmHENYTioji0ILxFq3PHR4U4ocsncILyJDaqYnLdSprP7 cCI4W+ywuUjGgjf2me6U3//VNFMTwcvX9jXUDjXwhHiGKo5BmOymwK7Ngz+02dRaAau4 Lmaw== X-Gm-Message-State: AOJu0YzzLCgTR/TG9ofZnruZ9efSI7coAjUkDmWeg5fo7CUE321QhZSy pK90erB4OswQzXDlLV9xxrxKZvJLq4Z846i+LgBXkICrqKcOaE7kfiCzwYDzTlY/b3bc+pc+C5V CIC8= X-Google-Smtp-Source: AGHT+IH+3m6unG933kwnTUgNjd3A3vU7ynfi3/37hnA4JFWynXT8q9D6E8zPKqECtd1kc1qHuIh25Q== X-Received: by 2002:a05:600c:548e:b0:412:e4f6:75ae with SMTP id iv14-20020a05600c548e00b00412e4f675aemr3491202wmb.32.1709652492294; Tue, 05 Mar 2024 07:28:12 -0800 (PST) Received: from P-ASN-ECS-830T8C3.numericable.fr ([89.159.1.53]) by smtp.gmail.com with ESMTPSA id w15-20020a05600c474f00b00412f0592e0bsm559873wmo.47.2024.03.05.07.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 07:28:12 -0800 (PST) From: Yoann Congal To: openembedded-devel@lists.openembedded.org Cc: Yoann Congal Subject: [meta-oe][PATCH] toybox-inittab: Fix serial getty reproducibility Date: Tue, 5 Mar 2024 16:27:59 +0100 Message-Id: <20240305152759.1702540-1-yoann.congal@smile.fr> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 05 Mar 2024 15:28:25 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/109121 The enable_getty test uses a bash-only syntax "[[ ... ]]". On /bin/sh==bash hosts, it enables the serial getty. On /bin/sh!=bash hosts, it does not enable it. Fix this non-reproducibility by using the standard shell "[ ... ]" syntax which should work in any POSIX shell[0]. [0]: https://www.shellcheck.net/wiki/SC3010 Signed-off-by: Yoann Congal --- meta-oe/recipes-core/toybox/toybox-inittab_0.8.2.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta-oe/recipes-core/toybox/toybox-inittab_0.8.2.bb b/meta-oe/recipes-core/toybox/toybox-inittab_0.8.2.bb index 603f365cf3..4cad7dce11 100644 --- a/meta-oe/recipes-core/toybox/toybox-inittab_0.8.2.bb +++ b/meta-oe/recipes-core/toybox/toybox-inittab_0.8.2.bb @@ -34,7 +34,7 @@ do_configure() { cp orig/* . for config in ${PACKAGECONFIG_CONFARGS}; do - if [[ ${config} == "enable_getty" ]]; then + if [ "${config}" = "enable_getty" ]; then echo "# generated by bitbake recipe ${PN}" >> ${S}/inittab for console in "${SERIAL_CONSOLES}"; do param=$(echo ${console} | sed s/\;/\ /g)