Patchwork [1/4] gst-meta-base: pull in X11 plugins when using X11

login
mail settings
Submitter Saul Wold
Date Dec. 4, 2012, 11:29 p.m.
Message ID <1354663759-20022-2-git-send-email-sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/40365/
State New
Headers show

Comments

Saul Wold - Dec. 4, 2012, 11:29 p.m.
From: Ross Burton <ross.burton@intel.com>

The splitting out of X11 plugins wasn't complete, which lead to no X11 plugins
being installed.

If the X11 distro feature is present, make gst-meta-base depend on
gst-meta-x11-base.  Also make -x11-base RDEPEND on xvimagesink for video
playback performance.

[ YOCTO #3458 ]

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Saul Wold - Dec. 4, 2012, 11:31 p.m.
My bad, I send mulitple copies due to sheer stupidity today.  Sorry 
about that.

Ingore this whole thread, will resent a v2!

Sau!


On 12/04/2012 03:29 PM, Saul Wold wrote:
> From: Ross Burton <ross.burton@intel.com>
>
> The splitting out of X11 plugins wasn't complete, which lead to no X11 plugins
> being installed.
>
> If the X11 distro feature is present, make gst-meta-base depend on
> gst-meta-x11-base.  Also make -x11-base RDEPEND on xvimagesink for video
> playback performance.
>
> [ YOCTO #3458 ]
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>   meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> index 2fb39d5..21243c6 100644
> --- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> +++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> @@ -5,7 +5,7 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
>                       file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>
>
> -PR = "r11"
> +PR = "r12"
>
>   PACKAGES = "\
>       gst-meta-base \
> @@ -17,6 +17,7 @@ PACKAGES = "\
>   ALLOW_EMPTY = "1"
>
>   RDEPENDS_gst-meta-base = "\
> +    ${@base_contains('DISTRO_FEATURES', 'x11', 'gst-meta-x11-base', '', d)} \
>       gstreamer \
>       gst-plugins-base-playbin \
>       gst-plugins-base-decodebin \
> @@ -32,7 +33,9 @@ RDEPENDS_gst-meta-base = "\
>       gst-plugins-good-autodetect \
>       gst-plugins-good-souphttpsrc"
>
> -RDEPENDS_gst-meta-x11-base = "${@base_contains('DISTRO_FEATURES', 'x11', 'gst-plugins-base-ximagesink', '', d)}"
> +RDEPENDS_gst-meta-x11-base = "\
> +    gst-plugins-base-ximagesink \
> +    gst-plugins-base-xvimagesink"
>
>   RDEPENDS_gst-meta-audio = "\
>       gst-meta-base \
>

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
index 2fb39d5..21243c6 100644
--- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
+++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
@@ -5,7 +5,7 @@  LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
                     file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
 
 
-PR = "r11"
+PR = "r12"
 
 PACKAGES = "\
     gst-meta-base \
@@ -17,6 +17,7 @@  PACKAGES = "\
 ALLOW_EMPTY = "1"
 
 RDEPENDS_gst-meta-base = "\
+    ${@base_contains('DISTRO_FEATURES', 'x11', 'gst-meta-x11-base', '', d)} \
     gstreamer \
     gst-plugins-base-playbin \
     gst-plugins-base-decodebin \
@@ -32,7 +33,9 @@  RDEPENDS_gst-meta-base = "\
     gst-plugins-good-autodetect \
     gst-plugins-good-souphttpsrc"
 
-RDEPENDS_gst-meta-x11-base = "${@base_contains('DISTRO_FEATURES', 'x11', 'gst-plugins-base-ximagesink', '', d)}"
+RDEPENDS_gst-meta-x11-base = "\
+    gst-plugins-base-ximagesink \
+    gst-plugins-base-xvimagesink"
 
 RDEPENDS_gst-meta-audio = "\
     gst-meta-base \