Patchwork gst-meta-base: pull in X11 plugins when using X11

login
register
mail settings
Submitter Ross Burton
Date Dec. 4, 2012, 8:58 p.m.
Message ID <1354654683-16793-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/40359/
State Accepted
Commit 5b027d041ae994d02e22302dbbf3685484aa9b48
Headers show

Comments

Ross Burton - Dec. 4, 2012, 8:58 p.m.
The splitting out of X11 plugins wasn't complete, which lead to no X11 plugins
being installed.

If the X11 distro feature is present, make gst-meta-base depend on
gst-meta-x11-base.  Also make -x11-base RDEPEND on xvimagesink for video
playback performance.

[ YOCTO #3458 ]

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Otavio Salvador - Dec. 4, 2012, 9:38 p.m.
On Tue, Dec 4, 2012 at 6:58 PM, Ross Burton <ross.burton@intel.com> wrote:

> The splitting out of X11 plugins wasn't complete, which lead to no X11
> plugins
> being installed.
>
> If the X11 distro feature is present, make gst-meta-base depend on
> gst-meta-x11-base.  Also make -x11-base RDEPEND on xvimagesink for video
> playback performance.
>
> [ YOCTO #3458 ]
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
>

Would be better to use a RRECOMMENDS on xvimagesink? It makes more sense.
Ross Burton - Dec. 5, 2012, 3:16 p.m.
On 4 December 2012 21:38, Otavio Salvador <otavio@ossystems.com.br> wrote:
> Would be better to use a RRECOMMENDS on xvimagesink? It makes more sense.

None of the other dependencies are recommends, so are you suggesting
they all become recommends or just that xvimagesink in particular?

Ross
Otavio Salvador - Dec. 5, 2012, 3:52 p.m.
On Wed, Dec 5, 2012 at 1:16 PM, Burton, Ross <ross.burton@intel.com> wrote:

> On 4 December 2012 21:38, Otavio Salvador <otavio@ossystems.com.br> wrote:
> > Would be better to use a RRECOMMENDS on xvimagesink? It makes more sense.
>
> None of the other dependencies are recommends, so are you suggesting
> they all become recommends or just that xvimagesink in particular?
>

Just xvimagesink as this is an improvement, not a requirement.
Ross Burton - Dec. 5, 2012, 3:55 p.m.
On 5 December 2012 15:52, Otavio Salvador <otavio@ossystems.com.br> wrote:
> Just xvimagesink as this is an improvement, not a requirement.

That's an interesting definition of improvement.  Video playback over
X11 without using Xvideo is crazy.

Ross
Otavio Salvador - Dec. 5, 2012, 4 p.m.
On Wed, Dec 5, 2012 at 1:55 PM, Burton, Ross <ross.burton@intel.com> wrote:

> On 5 December 2012 15:52, Otavio Salvador <otavio@ossystems.com.br> wrote:
> > Just xvimagesink as this is an improvement, not a requirement.
>
> That's an interesting definition of improvement.  Video playback over
> X11 without using Xvideo is crazy.
>

Well, dependencies means it cannot be used without it. Recommends is
something which is important and makes sense to be used with it (most users
do) but not a requirement.

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
index 2fb39d5..21243c6 100644
--- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
+++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
@@ -5,7 +5,7 @@  LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
                     file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
 
 
-PR = "r11"
+PR = "r12"
 
 PACKAGES = "\
     gst-meta-base \
@@ -17,6 +17,7 @@  PACKAGES = "\
 ALLOW_EMPTY = "1"
 
 RDEPENDS_gst-meta-base = "\
+    ${@base_contains('DISTRO_FEATURES', 'x11', 'gst-meta-x11-base', '', d)} \
     gstreamer \
     gst-plugins-base-playbin \
     gst-plugins-base-decodebin \
@@ -32,7 +33,9 @@  RDEPENDS_gst-meta-base = "\
     gst-plugins-good-autodetect \
     gst-plugins-good-souphttpsrc"
 
-RDEPENDS_gst-meta-x11-base = "${@base_contains('DISTRO_FEATURES', 'x11', 'gst-plugins-base-ximagesink', '', d)}"
+RDEPENDS_gst-meta-x11-base = "\
+    gst-plugins-base-ximagesink \
+    gst-plugins-base-xvimagesink"
 
 RDEPENDS_gst-meta-audio = "\
     gst-meta-base \