Patchwork qa.py: Modify the env for the child process only

login
mail settings
Submitter Shakeel, Muhammad
Date Dec. 4, 2012, 10:19 a.m.
Message ID <1354616390-14949-1-git-send-email-muhammad_shakeel@mentor.com>
Download mbox | patch
Permalink /patch/40239/
State Accepted
Commit cb3b046450b47739daf441a0b964823aff2472e6
Headers show

Comments

Shakeel, Muhammad - Dec. 4, 2012, 10:19 a.m.
From: Muhammad Shakeel <muhammad_shakeel@mentor.com>

Modified environment is only required for new subprocess to execute
objdump command and not for the current process. We should only
modify the copy of env to pass it on to the child.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
---
 meta/lib/oe/qa.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/meta/lib/oe/qa.py b/meta/lib/oe/qa.py
index 12dcd1f..2c51141 100644
--- a/meta/lib/oe/qa.py
+++ b/meta/lib/oe/qa.py
@@ -99,7 +99,7 @@  class ELFFile:
         objdump = d.getVar('OBJDUMP', True)
         staging_dir = d.getVar('STAGING_BINDIR_TOOLCHAIN', True)
 
-        env = os.environ
+        env = os.environ.copy()
         env["LC_ALL"] = "C"
 
         try: