| Message ID | 20240227170902.3718203-1-ejo@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] kernel.bbclass: slightly fix wording, case, and spaces in version check | expand |
On Tue, Feb 27, 2024 at 12:09 PM Enrico Jörns <ejo@pengutronix.de> wrote: > > * Version -> version > * match of kernel -> match the kernel > * Add missing spaces around "=" sign There's nothing technically wrong with the missing spaces. Putting the assignment in a recipe with or without the spaces should work. Bruce > > Signed-off-by: Enrico Jörns <ejo@pengutronix.de> > --- > meta/classes-recipe/kernel.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes-recipe/kernel.bbclass b/meta/classes-recipe/kernel.bbclass > index 31e4a683d1..837064cef7 100644 > --- a/meta/classes-recipe/kernel.bbclass > +++ b/meta/classes-recipe/kernel.bbclass > @@ -509,7 +509,7 @@ do_kernel_version_sanity_check() { > reg="${reg}${EXTRAVERSION}" > > if [ -z `echo ${PV} | grep -E "${reg}"` ]; then > - bbfatal "Package Version (${PV}) does not match of kernel being built (${vers}). Please update the PV variable to match the kernel source or set KERNEL_VERSION_SANITY_SKIP=\"1\" in your recipe." > + bbfatal "Package version (${PV}) does not match the kernel being built (${vers}). Please update the PV variable to match the kernel source or set KERNEL_VERSION_SANITY_SKIP = \"1\" in your recipe." > fi > exit 0 > } > -- > 2.39.2 >
Am Dienstag, dem 27.02.2024 um 12:37 -0500 schrieb Bruce Ashfield: > On Tue, Feb 27, 2024 at 12:09 PM Enrico Jörns <ejo@pengutronix.de> wrote: > > > > * Version -> version > > * match of kernel -> match the kernel > > * Add missing spaces around "=" sign > > There's nothing technically wrong with the missing spaces. Putting the > assignment in a recipe with or without the spaces should work. Right, it's more about being consistent with the oe 'coding style' of assigning variables
diff --git a/meta/classes-recipe/kernel.bbclass b/meta/classes-recipe/kernel.bbclass index 31e4a683d1..837064cef7 100644 --- a/meta/classes-recipe/kernel.bbclass +++ b/meta/classes-recipe/kernel.bbclass @@ -509,7 +509,7 @@ do_kernel_version_sanity_check() { reg="${reg}${EXTRAVERSION}" if [ -z `echo ${PV} | grep -E "${reg}"` ]; then - bbfatal "Package Version (${PV}) does not match of kernel being built (${vers}). Please update the PV variable to match the kernel source or set KERNEL_VERSION_SANITY_SKIP=\"1\" in your recipe." + bbfatal "Package version (${PV}) does not match the kernel being built (${vers}). Please update the PV variable to match the kernel source or set KERNEL_VERSION_SANITY_SKIP = \"1\" in your recipe." fi exit 0 }
* Version -> version * match of kernel -> match the kernel * Add missing spaces around "=" sign Signed-off-by: Enrico Jörns <ejo@pengutronix.de> --- meta/classes-recipe/kernel.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)