Patchwork [RFC,08/10] send-pull-request: fix greedy auto-cc regex

login
register
mail settings
Submitter Darren Hart
Date May 13, 2011, 11:38 p.m.
Message ID <2bcca2da6cb16866886a329d7f7a74edde7ebabf.1305329659.git.dvhart@linux.intel.com>
Download mbox | patch
Permalink /patch/4015/
State New, archived
Headers show

Comments

Darren Hart - May 13, 2011, 11:38 p.m.
A greedy regular expression caused emails to be harvested from patches
that were quoted in the commit message. Ensure only tags that start at the
beginning of the line are considered for harvesting.

NOTE: users are still responsible for verifying the recipients list and to
      ensure they do not spam people!

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Saul Wold <sgw@linux.intel.com>
Cc: Bruce Ashfield <bruce.ashfield@windriver.com>
---
 scripts/send-pull-request |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Bruce Ashfield - May 14, 2011, 5:41 a.m.
On Fri, May 13, 2011 at 7:38 PM, Darren Hart <dvhart@linux.intel.com> wrote:
> A greedy regular expression caused emails to be harvested from patches
> that were quoted in the commit message. Ensure only tags that start at the
> beginning of the line are considered for harvesting.
>
> NOTE: users are still responsible for verifying the recipients list and to
>      ensure they do not spam people!

This is key!

But a change for the better.

Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>

Bruce

>
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
> Cc: Saul Wold <sgw@linux.intel.com>
> Cc: Bruce Ashfield <bruce.ashfield@windriver.com>
> ---
>  scripts/send-pull-request |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/send-pull-request b/scripts/send-pull-request
> index d265c47..b294d35 100755
> --- a/scripts/send-pull-request
> +++ b/scripts/send-pull-request
> @@ -90,7 +90,7 @@ done
>  if [ $AUTO -eq 1 ]; then
>        harvest_recipients TO "^[Tt][Oo]: *"
>        harvest_recipients CC "^[Cc][Cc]: *"
> -       harvest_recipients CC "^.*-[Bb][Yy]: *"
> +       harvest_recipients CC "^[A-Z][A-Za-z-]*-[Bb][Yy]: *"
>  fi
>
>  AUTO_TO="$(git config sendemail.to)"
> --
> 1.7.1
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/scripts/send-pull-request b/scripts/send-pull-request
index d265c47..b294d35 100755
--- a/scripts/send-pull-request
+++ b/scripts/send-pull-request
@@ -90,7 +90,7 @@  done
 if [ $AUTO -eq 1 ]; then
 	harvest_recipients TO "^[Tt][Oo]: *"
 	harvest_recipients CC "^[Cc][Cc]: *"
-	harvest_recipients CC "^.*-[Bb][Yy]: *"
+	harvest_recipients CC "^[A-Z][A-Za-z-]*-[Bb][Yy]: *"
 fi
 
 AUTO_TO="$(git config sendemail.to)"