Patchwork [3/3] libcgroup: Fix QA error about .so symlink

login
register
mail settings
Submitter Khem Raj
Date Dec. 2, 2012, 8:45 p.m.
Message ID <8db2a8dab66febf2844ac62cd207e9e40edec11c.1354480962.git.raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/40025/
State New
Headers show

Comments

Khem Raj - Dec. 2, 2012, 8:45 p.m.
ERROR: QA Issue: non -dev/-dbg/-nativesdk package contains symlink .so:
cgroups-pam-plugin path
'/work/x86_64-angstrom-linux/libcgroup/0.37.1-r1/packages-split/cgroups-pam-plugin/lib/security/pam_cgroup.so'
ERROR: QA run found fatal errors. Please consider fixing them.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-core/libcgroup/libcgroup_0.37.1.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Paul Eggleton - Dec. 2, 2012, 11:26 p.m.
On Sunday 02 December 2012 12:45:07 Khem Raj wrote:
> ERROR: QA Issue: non -dev/-dbg/-nativesdk package contains symlink .so:
> cgroups-pam-plugin path
> '/work/x86_64-angstrom-linux/libcgroup/0.37.1-r1/packages-split/cgroups-pam-
> plugin/lib/security/pam_cgroup.so' ERROR: QA run found fatal errors. Please
> consider fixing them.
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-core/libcgroup/libcgroup_0.37.1.bb |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb
> b/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb index 3ef1dad..7ac782b
> 100644
> --- a/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb
> +++ b/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb
> @@ -24,4 +24,4 @@ FILES_${PN}-dbg += "${base_libdir}/security/.debug"
>  FILES_${PN}-dev += "${base_libdir}/security/*.la"
> 
>  # We really need the symlink so :(
> -INSANE_SKIP_${PN} = "dev-so"
> +INSANE_SKIP_cgroups-pam-plugin = "dev-so"

FWIW, Martin already sent this patch.

Cheers,
Paul
Saul Wold - Dec. 3, 2012, 4:36 a.m.
On 12/02/2012 03:26 PM, Paul Eggleton wrote:
> On Sunday 02 December 2012 12:45:07 Khem Raj wrote:
>> ERROR: QA Issue: non -dev/-dbg/-nativesdk package contains symlink .so:
>> cgroups-pam-plugin path
>> '/work/x86_64-angstrom-linux/libcgroup/0.37.1-r1/packages-split/cgroups-pam-
>> plugin/lib/security/pam_cgroup.so' ERROR: QA run found fatal errors. Please
>> consider fixing them.
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>   meta/recipes-core/libcgroup/libcgroup_0.37.1.bb |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb
>> b/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb index 3ef1dad..7ac782b
>> 100644
>> --- a/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb
>> +++ b/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb
>> @@ -24,4 +24,4 @@ FILES_${PN}-dbg += "${base_libdir}/security/.debug"
>>   FILES_${PN}-dev += "${base_libdir}/security/*.la"
>>
>>   # We really need the symlink so :(
>> -INSANE_SKIP_${PN} = "dev-so"
>> +INSANE_SKIP_cgroups-pam-plugin = "dev-so"
>
> FWIW, Martin already sent this patch.
>
Patch is pending.

Sau!

> Cheers,
> Paul
>
Khem Raj - Dec. 3, 2012, 5:59 a.m.
On Sun, Dec 2, 2012 at 3:26 PM, Paul Eggleton <paul.eggleton@linux.intel.com
> wrote:

> FWIW, Martin already sent this patch.


OK as long as it gets fixed.

Patch

diff --git a/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb b/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb
index 3ef1dad..7ac782b 100644
--- a/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb
+++ b/meta/recipes-core/libcgroup/libcgroup_0.37.1.bb
@@ -24,4 +24,4 @@  FILES_${PN}-dbg += "${base_libdir}/security/.debug"
 FILES_${PN}-dev += "${base_libdir}/security/*.la"
 
 # We really need the symlink so :(
-INSANE_SKIP_${PN} = "dev-so"
+INSANE_SKIP_cgroups-pam-plugin = "dev-so"