| Message ID | 20240221184624.3000696-1-jan.vermaete@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [meta-webserver] netdata: version bump 1.43.2 -> 1.44.3 | expand |
On Wed, Feb 21, 2024 at 10:46 AM Jan Vermaete <jan.vermaete@gmail.com> wrote: > > And fixed a few minor oelint-adv warnings in the recipe. > > Tested on Raspberry PI 4 > > Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com> > --- > .../netdata/{netdata_1.43.2.bb => netdata_1.44.3.bb} | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > rename meta-webserver/recipes-webadmin/netdata/{netdata_1.43.2.bb => netdata_1.44.3.bb} (92%) > > diff --git a/meta-webserver/recipes-webadmin/netdata/netdata_1.43.2.bb b/meta-webserver/recipes-webadmin/netdata/netdata_1.44.3.bb > similarity index 92% > rename from meta-webserver/recipes-webadmin/netdata/netdata_1.43.2.bb > rename to meta-webserver/recipes-webadmin/netdata/netdata_1.44.3.bb > index 28e82dac3..8eeb61f66 100644 > --- a/meta-webserver/recipes-webadmin/netdata/netdata_1.43.2.bb > +++ b/meta-webserver/recipes-webadmin/netdata/netdata_1.44.3.bb > @@ -5,17 +5,17 @@ HOMEPAGE = "https://github.com/netdata/netdata/" > LICENSE = "GPL-3.0-only" > LIC_FILES_CHKSUM = "file://LICENSE;md5=fc9b848046ef54b5eaee6071947abd24" > > -DEPENDS += "libuv util-linux zlib libyaml json-c" > +DEPENDS += "json-c libuv libyaml util-linux zlib " > > -SRC_URI = "https://github.com/${BPN}/${BPN}/releases/download/v${PV}/${BPN}-v${PV}.tar.gz \ > -" > -SRC_URI[sha256sum] = "d4a7ea2717ac7c8f04865f18e13aeaa0a36784156059f1b5ced75a44f74afc4d" > +SRC_URI = "https://github.com/${BPN}/${BPN}/releases/download/v${PV}/${BPN}-v${PV}.tar.gz" > + > +SRC_URI[sha256sum] = "50df30a9aaf60d550eb8e607230d982827e04194f7df3eba0e83ff7919270ad2" > > # default netdata.conf for netdata configuration > -SRC_URI += "file://netdata.conf" > +SRC_URI:append = " file://netdata.conf" > > # file for providing systemd service support > -SRC_URI += "file://netdata.service" > +SRC_URI:append = " file://netdata.service" why do we need to change += to append here ? > > UPSTREAM_CHECK_URI = "https://github.com/${BPN}/${BPN}/tags" > UPSTREAM_CHECK_REGEX = "${BPN}/releases/tag/v(?P<pver>\d+(?:\.\d+)*)" > -- > 2.39.2 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#108968): https://lists.openembedded.org/g/openembedded-devel/message/108968 > Mute This Topic: https://lists.openembedded.org/mt/104494299/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Hi Khem, I was using the latest version of oelint-adv to check the recipe. I had this warnings: netdata_1.43.2.bb:15:error:oelint.vars.srcuriappend:Use SRC_URI:append otherwise this will override weak defaults by inherit netdata_1.43.2.bb:18:error:oelint.vars.srcuriappend:Use SRC_URI:append otherwise this will override weak defaults by inherit If you prefer I can make a v2 of the patch without it. On Wed, Feb 21, 2024 at 8:47 PM Khem Raj <raj.khem@gmail.com> wrote: > > On Wed, Feb 21, 2024 at 10:46 AM Jan Vermaete <jan.vermaete@gmail.com> wrote: > > > > And fixed a few minor oelint-adv warnings in the recipe. > > > > Tested on Raspberry PI 4 > > > > Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com> > > --- > > .../netdata/{netdata_1.43.2.bb => netdata_1.44.3.bb} | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > rename meta-webserver/recipes-webadmin/netdata/{netdata_1.43.2.bb => netdata_1.44.3.bb} (92%) > > > > diff --git a/meta-webserver/recipes-webadmin/netdata/netdata_1.43.2.bb b/meta-webserver/recipes-webadmin/netdata/netdata_1.44.3.bb > > similarity index 92% > > rename from meta-webserver/recipes-webadmin/netdata/netdata_1.43.2.bb > > rename to meta-webserver/recipes-webadmin/netdata/netdata_1.44.3.bb > > index 28e82dac3..8eeb61f66 100644 > > --- a/meta-webserver/recipes-webadmin/netdata/netdata_1.43.2.bb > > +++ b/meta-webserver/recipes-webadmin/netdata/netdata_1.44.3.bb > > @@ -5,17 +5,17 @@ HOMEPAGE = "https://github.com/netdata/netdata/" > > LICENSE = "GPL-3.0-only" > > LIC_FILES_CHKSUM = "file://LICENSE;md5=fc9b848046ef54b5eaee6071947abd24" > > > > -DEPENDS += "libuv util-linux zlib libyaml json-c" > > +DEPENDS += "json-c libuv libyaml util-linux zlib " > > > > -SRC_URI = "https://github.com/${BPN}/${BPN}/releases/download/v${PV}/${BPN}-v${PV}.tar.gz \ > > -" > > -SRC_URI[sha256sum] = "d4a7ea2717ac7c8f04865f18e13aeaa0a36784156059f1b5ced75a44f74afc4d" > > +SRC_URI = "https://github.com/${BPN}/${BPN}/releases/download/v${PV}/${BPN}-v${PV}.tar.gz" > > + > > +SRC_URI[sha256sum] = "50df30a9aaf60d550eb8e607230d982827e04194f7df3eba0e83ff7919270ad2" > > > > # default netdata.conf for netdata configuration > > -SRC_URI += "file://netdata.conf" > > +SRC_URI:append = " file://netdata.conf" > > > > # file for providing systemd service support > > -SRC_URI += "file://netdata.service" > > +SRC_URI:append = " file://netdata.service" > > why do we need to change += to append here ? > > > > > UPSTREAM_CHECK_URI = "https://github.com/${BPN}/${BPN}/tags" > > UPSTREAM_CHECK_REGEX = "${BPN}/releases/tag/v(?P<pver>\d+(?:\.\d+)*)" > > -- > > 2.39.2 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#108968): https://lists.openembedded.org/g/openembedded-devel/message/108968 > > Mute This Topic: https://lists.openembedded.org/mt/104494299/1997914 > > Group Owner: openembedded-devel+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > > -=-=-=-=-=-=-=-=-=-=-=- > >
On Wed, Feb 21, 2024 at 12:34 PM jan vermaete <jan.vermaete@gmail.com> wrote: > > Hi Khem, > > I was using the latest version of oelint-adv to check the recipe. > I had this warnings: > netdata_1.43.2.bb:15:error:oelint.vars.srcuriappend:Use > SRC_URI:append otherwise this will override weak defaults by inherit > netdata_1.43.2.bb:18:error:oelint.vars.srcuriappend:Use > SRC_URI:append otherwise this will override weak defaults by inherit > > If you prefer I can make a v2 of the patch without it. > lets consolidate all under one SRC_URI, I don't see a pressing reason to have each file added individually to SRC_URI here. > On Wed, Feb 21, 2024 at 8:47 PM Khem Raj <raj.khem@gmail.com> wrote: > > > > On Wed, Feb 21, 2024 at 10:46 AM Jan Vermaete <jan.vermaete@gmail.com> wrote: > > > > > > And fixed a few minor oelint-adv warnings in the recipe. > > > > > > Tested on Raspberry PI 4 > > > > > > Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com> > > > --- > > > .../netdata/{netdata_1.43.2.bb => netdata_1.44.3.bb} | 12 ++++++------ > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > rename meta-webserver/recipes-webadmin/netdata/{netdata_1.43.2.bb => netdata_1.44.3.bb} (92%) > > > > > > diff --git a/meta-webserver/recipes-webadmin/netdata/netdata_1.43.2.bb b/meta-webserver/recipes-webadmin/netdata/netdata_1.44.3.bb > > > similarity index 92% > > > rename from meta-webserver/recipes-webadmin/netdata/netdata_1.43.2.bb > > > rename to meta-webserver/recipes-webadmin/netdata/netdata_1.44.3.bb > > > index 28e82dac3..8eeb61f66 100644 > > > --- a/meta-webserver/recipes-webadmin/netdata/netdata_1.43.2.bb > > > +++ b/meta-webserver/recipes-webadmin/netdata/netdata_1.44.3.bb > > > @@ -5,17 +5,17 @@ HOMEPAGE = "https://github.com/netdata/netdata/" > > > LICENSE = "GPL-3.0-only" > > > LIC_FILES_CHKSUM = "file://LICENSE;md5=fc9b848046ef54b5eaee6071947abd24" > > > > > > -DEPENDS += "libuv util-linux zlib libyaml json-c" > > > +DEPENDS += "json-c libuv libyaml util-linux zlib " > > > > > > -SRC_URI = "https://github.com/${BPN}/${BPN}/releases/download/v${PV}/${BPN}-v${PV}.tar.gz \ > > > -" > > > -SRC_URI[sha256sum] = "d4a7ea2717ac7c8f04865f18e13aeaa0a36784156059f1b5ced75a44f74afc4d" > > > +SRC_URI = "https://github.com/${BPN}/${BPN}/releases/download/v${PV}/${BPN}-v${PV}.tar.gz" > > > + > > > +SRC_URI[sha256sum] = "50df30a9aaf60d550eb8e607230d982827e04194f7df3eba0e83ff7919270ad2" > > > > > > # default netdata.conf for netdata configuration > > > -SRC_URI += "file://netdata.conf" > > > +SRC_URI:append = " file://netdata.conf" > > > > > > # file for providing systemd service support > > > -SRC_URI += "file://netdata.service" > > > +SRC_URI:append = " file://netdata.service" > > > > why do we need to change += to append here ? > > > > > > > > UPSTREAM_CHECK_URI = "https://github.com/${BPN}/${BPN}/tags" > > > UPSTREAM_CHECK_REGEX = "${BPN}/releases/tag/v(?P<pver>\d+(?:\.\d+)*)" > > > -- > > > 2.39.2 > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > > Links: You receive all messages sent to this group. > > > View/Reply Online (#108968): https://lists.openembedded.org/g/openembedded-devel/message/108968 > > > Mute This Topic: https://lists.openembedded.org/mt/104494299/1997914 > > > Group Owner: openembedded-devel+owner@lists.openembedded.org > > > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > > > -=-=-=-=-=-=-=-=-=-=-=- > > > > > > > -- > Jan Vermaete > “Success is a self-correcting phenomenom.” -- Gary Hamel
diff --git a/meta-webserver/recipes-webadmin/netdata/netdata_1.43.2.bb b/meta-webserver/recipes-webadmin/netdata/netdata_1.44.3.bb similarity index 92% rename from meta-webserver/recipes-webadmin/netdata/netdata_1.43.2.bb rename to meta-webserver/recipes-webadmin/netdata/netdata_1.44.3.bb index 28e82dac3..8eeb61f66 100644 --- a/meta-webserver/recipes-webadmin/netdata/netdata_1.43.2.bb +++ b/meta-webserver/recipes-webadmin/netdata/netdata_1.44.3.bb @@ -5,17 +5,17 @@ HOMEPAGE = "https://github.com/netdata/netdata/" LICENSE = "GPL-3.0-only" LIC_FILES_CHKSUM = "file://LICENSE;md5=fc9b848046ef54b5eaee6071947abd24" -DEPENDS += "libuv util-linux zlib libyaml json-c" +DEPENDS += "json-c libuv libyaml util-linux zlib " -SRC_URI = "https://github.com/${BPN}/${BPN}/releases/download/v${PV}/${BPN}-v${PV}.tar.gz \ -" -SRC_URI[sha256sum] = "d4a7ea2717ac7c8f04865f18e13aeaa0a36784156059f1b5ced75a44f74afc4d" +SRC_URI = "https://github.com/${BPN}/${BPN}/releases/download/v${PV}/${BPN}-v${PV}.tar.gz" + +SRC_URI[sha256sum] = "50df30a9aaf60d550eb8e607230d982827e04194f7df3eba0e83ff7919270ad2" # default netdata.conf for netdata configuration -SRC_URI += "file://netdata.conf" +SRC_URI:append = " file://netdata.conf" # file for providing systemd service support -SRC_URI += "file://netdata.service" +SRC_URI:append = " file://netdata.service" UPSTREAM_CHECK_URI = "https://github.com/${BPN}/${BPN}/tags" UPSTREAM_CHECK_REGEX = "${BPN}/releases/tag/v(?P<pver>\d+(?:\.\d+)*)"
And fixed a few minor oelint-adv warnings in the recipe. Tested on Raspberry PI 4 Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com> --- .../netdata/{netdata_1.43.2.bb => netdata_1.44.3.bb} | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) rename meta-webserver/recipes-webadmin/netdata/{netdata_1.43.2.bb => netdata_1.44.3.bb} (92%)