Patchwork [meta-intel,0/3] Fixes for rescent X breakages in meta-intel layer

login
register
mail settings
Submitter Nitin A Kamble
Date Nov. 28, 2012, 6:21 p.m.
Message ID <cover.1354126748.git.nitin.a.kamble@intel.com>
Download mbox
Permalink /patch/39817/
State New
Headers show

Pull-request

git://git.yoctoproject.org/meta-intel-contrib nitin/misc

Comments

Nitin A Kamble - Nov. 28, 2012, 6:21 p.m.
From: Nitin A Kamble <nitin.a.kamble@intel.com>

This commits are for meta-intel layer. And Ross'es patch tries to achieve the same 
from the oecore layer.

Thanks,
Nitin


The following changes since commit 154156a4db56f7b33fb1765cf6b87e683d027af9:

  emgd-driver-bin: add further needed soft links (2012-11-26 18:02:11 -0600)

are available in the git repository at:
  git://git.yoctoproject.org/meta-intel-contrib nitin/misc
  http://git.yoctoproject.org/cgit.cgi/meta-intel-contrib/log/?h=nitin/misc

Nitin A Kamble (3):
  xserver-xorg-1.9.3: fix packaging issues
  xserver-psb: fix packaging issues
  xserver-xorg-video-psb: fix packaging issues

 .../xorg-xserver/xserver-xorg-1.9.3.inc            |    2 +-
 .../recipes-graphics/xorg-xserver/xserver-xorg.inc |  160 ++++++++++++++++++++
 .../xorg-xserver/xserver-xorg_1.9.3.bb             |    2 +-
 conf/machine/include/meta-intel.inc                |   10 +-
 .../xorg-xserver/xserver-psb-1.7.99.2.inc          |    2 +-
 .../xorg-xserver/xserver-psb_1.7.99.2.bb           |    2 +-
 .../xserver-xorg-video-psb_0.32.1.bb               |    8 +-
 7 files changed, 180 insertions(+), 6 deletions(-)
 create mode 100644 common/recipes-graphics/xorg-xserver/xserver-xorg.inc
Tom Zanussi - Nov. 28, 2012, 8:07 p.m.
On Wed, 2012-11-28 at 10:21 -0800, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> This commits are for meta-intel layer. And Ross'es patch tries to achieve the same 
> from the oecore layer.
> 

Hi Nitin,

So does this conflict with Ross's patch, which seems simpler...

Tom

> Thanks,
> Nitin
> 
> 
> The following changes since commit 154156a4db56f7b33fb1765cf6b87e683d027af9:
> 
>   emgd-driver-bin: add further needed soft links (2012-11-26 18:02:11 -0600)
> 
> are available in the git repository at:
>   git://git.yoctoproject.org/meta-intel-contrib nitin/misc
>   http://git.yoctoproject.org/cgit.cgi/meta-intel-contrib/log/?h=nitin/misc
> 
> Nitin A Kamble (3):
>   xserver-xorg-1.9.3: fix packaging issues
>   xserver-psb: fix packaging issues
>   xserver-xorg-video-psb: fix packaging issues
> 
>  .../xorg-xserver/xserver-xorg-1.9.3.inc            |    2 +-
>  .../recipes-graphics/xorg-xserver/xserver-xorg.inc |  160 ++++++++++++++++++++
>  .../xorg-xserver/xserver-xorg_1.9.3.bb             |    2 +-
>  conf/machine/include/meta-intel.inc                |   10 +-
>  .../xorg-xserver/xserver-psb-1.7.99.2.inc          |    2 +-
>  .../xorg-xserver/xserver-psb_1.7.99.2.bb           |    2 +-
>  .../xserver-xorg-video-psb_0.32.1.bb               |    8 +-
>  7 files changed, 180 insertions(+), 6 deletions(-)
>  create mode 100644 common/recipes-graphics/xorg-xserver/xserver-xorg.inc
>
Ross Burton - Nov. 29, 2012, 11:27 a.m.
On 28 November 2012 20:07, Tom Zanussi <tom.zanussi@intel.com> wrote:
> So does this conflict with Ross's patch, which seems simpler...

I do prefer my patch as the same breakage will occur for anyone else
using oe-core master but also building their own older X server.
Whilst the delta is so minimal, I don't see the problem in supporting
both in oe-core.

Ross
Tom Zanussi - Nov. 29, 2012, 2:21 p.m.
On Thu, 2012-11-29 at 11:27 +0000, Burton, Ross wrote:
> On 28 November 2012 20:07, Tom Zanussi <tom.zanussi@intel.com> wrote:
> > So does this conflict with Ross's patch, which seems simpler...
> 
> I do prefer my patch as the same breakage will occur for anyone else
> using oe-core master but also building their own older X server.
> Whilst the delta is so minimal, I don't see the problem in supporting
> both in oe-core.
> 

I'll second that...

Tom

> Ross
Nitin A Kamble - Nov. 29, 2012, 4:49 p.m.
> -----Original Message-----
> From: Zanussi, Tom
> Sent: Thursday, November 29, 2012 6:22 AM
> To: Burton, Ross
> Cc: Kamble, Nitin A; meta-intel@yoctoproject.org; Openembedded-
> core@lists.openembedded.org; Hart, Darren
> Subject: Re: [meta-intel patch 0/3] Fixes for rescent X breakages in meta-
> intel layer
> 
> On Thu, 2012-11-29 at 11:27 +0000, Burton, Ross wrote:
> > On 28 November 2012 20:07, Tom Zanussi <tom.zanussi@intel.com> wrote:
> > > So does this conflict with Ross's patch, which seems simpler...
> >
> > I do prefer my patch as the same breakage will occur for anyone else
> > using oe-core master but also building their own older X server.
> > Whilst the delta is so minimal, I don't see the problem in supporting
> > both in oe-core.
> >
> 
> I'll second that...
> 
> Tom
> 
> > Ross
> 

I am fine with either approach for fixing the breakages. I will take Ross's patch and see if it fixes the issue I saw.

Nitin
Nitin A Kamble - Dec. 1, 2012, 12:09 a.m.
Ross,
  I tried applying your patch from here with git am, and it is failing. http://patches.openembedded.org/patch/39801/
Can you send me link to your contrib branch for the patch?

Thanks,
Nitin


> -----Original Message-----
> From: Kamble, Nitin A
> Sent: Thursday, November 29, 2012 8:50 AM
> To: Zanussi, Tom; Burton, Ross
> Cc: meta-intel@yoctoproject.org; Openembedded-
> core@lists.openembedded.org; Hart, Darren
> Subject: RE: [meta-intel patch 0/3] Fixes for rescent X breakages in meta-
> intel layer
> 
> > -----Original Message-----
> > From: Zanussi, Tom
> > Sent: Thursday, November 29, 2012 6:22 AM
> > To: Burton, Ross
> > Cc: Kamble, Nitin A; meta-intel@yoctoproject.org; Openembedded-
> > core@lists.openembedded.org; Hart, Darren
> > Subject: Re: [meta-intel patch 0/3] Fixes for rescent X breakages in
> > meta- intel layer
> >
> > On Thu, 2012-11-29 at 11:27 +0000, Burton, Ross wrote:
> > > On 28 November 2012 20:07, Tom Zanussi <tom.zanussi@intel.com>
> wrote:
> > > > So does this conflict with Ross's patch, which seems simpler...
> > >
> > > I do prefer my patch as the same breakage will occur for anyone else
> > > using oe-core master but also building their own older X server.
> > > Whilst the delta is so minimal, I don't see the problem in
> > > supporting both in oe-core.
> > >
> >
> > I'll second that...
> >
> > Tom
> >
> > > Ross
> >
> 
> I am fine with either approach for fixing the breakages. I will take Ross's
> patch and see if it fixes the issue I saw.
> 
> Nitin
>
Nitin A Kamble - Dec. 1, 2012, 2:22 a.m.
I finally got the Ross's patch working in my env. I need to add one more patch in meta-intel to get it fully working. 

So I Ack for Ross's patch in oecore, and I will send a small patch for meta-intel.

Thanks,
Nitin



> -----Original Message-----
> From: Kamble, Nitin A
> Sent: Friday, November 30, 2012 4:09 PM
> To: Zanussi, Tom; Burton, Ross
> Cc: 'meta-intel@yoctoproject.org'; 'Openembedded-
> core@lists.openembedded.org'; Hart, Darren
> Subject: RE: [meta-intel patch 0/3] Fixes for rescent X breakages in meta-
> intel layer
> 
> Ross,
>   I tried applying your patch from here with git am, and it is failing.
> http://patches.openembedded.org/patch/39801/
> Can you send me link to your contrib branch for the patch?
> 
> Thanks,
> Nitin
> 
> 
> > -----Original Message-----
> > From: Kamble, Nitin A
> > Sent: Thursday, November 29, 2012 8:50 AM
> > To: Zanussi, Tom; Burton, Ross
> > Cc: meta-intel@yoctoproject.org; Openembedded-
> > core@lists.openembedded.org; Hart, Darren
> > Subject: RE: [meta-intel patch 0/3] Fixes for rescent X breakages in
> > meta- intel layer
> >
> > > -----Original Message-----
> > > From: Zanussi, Tom
> > > Sent: Thursday, November 29, 2012 6:22 AM
> > > To: Burton, Ross
> > > Cc: Kamble, Nitin A; meta-intel@yoctoproject.org; Openembedded-
> > > core@lists.openembedded.org; Hart, Darren
> > > Subject: Re: [meta-intel patch 0/3] Fixes for rescent X breakages in
> > > meta- intel layer
> > >
> > > On Thu, 2012-11-29 at 11:27 +0000, Burton, Ross wrote:
> > > > On 28 November 2012 20:07, Tom Zanussi <tom.zanussi@intel.com>
> > wrote:
> > > > > So does this conflict with Ross's patch, which seems simpler...
> > > >
> > > > I do prefer my patch as the same breakage will occur for anyone
> > > > else using oe-core master but also building their own older X server.
> > > > Whilst the delta is so minimal, I don't see the problem in
> > > > supporting both in oe-core.
> > > >
> > >
> > > I'll second that...
> > >
> > > Tom
> > >
> > > > Ross
> > >
> >
> > I am fine with either approach for fixing the breakages. I will take
> > Ross's patch and see if it fixes the issue I saw.
> >
> > Nitin
> >
Tom Zanussi - Dec. 2, 2012, 11:10 p.m.
On Thu, 2012-11-29 at 08:21 -0600, Tom Zanussi wrote:
> On Thu, 2012-11-29 at 11:27 +0000, Burton, Ross wrote:
> > On 28 November 2012 20:07, Tom Zanussi <tom.zanussi@intel.com> wrote:
> > > So does this conflict with Ross's patch, which seems simpler...
> > 
> > I do prefer my patch as the same breakage will occur for anyone else
> > using oe-core master but also building their own older X server.
> > Whilst the delta is so minimal, I don't see the problem in supporting
> > both in oe-core.
> > 
> 
> I'll second that...
> 

Did anyone test this?  I'm getting:

1558733.206] (WW) Warning, couldn't open module dri
[1558733.206] (II) UnloadModule: "dri"
[1558733.206] (EE) Failed to load module "dri" (module does not exist,
0)
[1558733.206] (II) LoadModule: "dri2"
[1558733.207] (WW) Warning, couldn't open module dri2
[1558733.207] (II) UnloadModule: "dri2"


> Tom
> 
> > Ross
>