Patchwork [0/2] eglibc: move the fix code for optimization isssue to .inc

login
register
mail settings
Submitter jackie huang
Date Nov. 28, 2012, 6:11 a.m.
Message ID <cover.1354081123.git.jackie.huang@windriver.com>
Download mbox
Permalink /patch/39767/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib jhuang0/d_eglibc_1128_1

Comments

jackie huang - Nov. 28, 2012, 6:11 a.m.
From: Jackie Huang <jackie.huang@windriver.com>

I made a patch against the eglibc_2.16.bb for the optimization issue two weeks ago,
but it's not a version specific issue and we still keep the versions 2.13 and 2.15
(and not having the 2.16 yet), so it would be more appropriate to move the code to
the .inc file. 
And we also want to cherry-pick this commit to our oe-core branch so I revert the
previous one and make a new commit against the .inc file but I'm not sure if it is
proper to do that. Please correct me if it is not, thanks!

* Test info:
1) MACHINE=qemux86-64/qemuppc/qemumips
$ bitbake core-image-sato 
$ bitbake eglibc

2) MACHINE=qemux86-64/qemuppc/qemumips
   DEBUG_OPTIMIZATION = "-O0 -fno-omit-frame-pointer ${DEBUG_FLAGS} -pipe"
   DEBUG_BUILD = "1" or SELECTED_OPTIMIZATION = "${DEBUG_OPTIMIZATION}"
$ bitbake core-image-sato
$ bitbake eglibc

The following changes since commit 764cc1eb3043c84121f597d2271108b91052095e:

  bitbake.conf: Change build output message to list BUILD_SYS, TARGET_SYS and NATIVELSBSTRING (2012-11-27 08:57:39 +0000)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib jhuang0/d_eglibc_1128_1
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/d_eglibc_1128_1

Jackie Huang (2):
  Revert "eglibc: always compile with optimization."
  eglibc: always compile with optimization.

 meta/recipes-core/eglibc/eglibc.inc     |   11 +++++++++++
 meta/recipes-core/eglibc/eglibc_2.16.bb |   11 -----------
 2 files changed, 11 insertions(+), 11 deletions(-)
Richard Purdie - Nov. 28, 2012, 7:42 a.m.
On Wed, 2012-11-28 at 14:11 +0800, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
> 
> I made a patch against the eglibc_2.16.bb for the optimization issue two weeks ago,
> but it's not a version specific issue and we still keep the versions 2.13 and 2.15
> (and not having the 2.16 yet), so it would be more appropriate to move the code to
> the .inc file. 
> And we also want to cherry-pick this commit to our oe-core branch so I revert the
> previous one and make a new commit against the .inc file but I'm not sure if it is
> proper to do that. Please correct me if it is not, thanks!
> 
> * Test info:
> 1) MACHINE=qemux86-64/qemuppc/qemumips
> $ bitbake core-image-sato 
> $ bitbake eglibc
> 
> 2) MACHINE=qemux86-64/qemuppc/qemumips
>    DEBUG_OPTIMIZATION = "-O0 -fno-omit-frame-pointer ${DEBUG_FLAGS} -pipe"
>    DEBUG_BUILD = "1" or SELECTED_OPTIMIZATION = "${DEBUG_OPTIMIZATION}"
> $ bitbake core-image-sato
> $ bitbake eglibc
> 
> The following changes since commit 764cc1eb3043c84121f597d2271108b91052095e:
> 
>   bitbake.conf: Change build output message to list BUILD_SYS, TARGET_SYS and NATIVELSBSTRING (2012-11-27 08:57:39 +0000)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib jhuang0/d_eglibc_1128_1
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/d_eglibc_1128_1
> 
> Jackie Huang (2):
>   Revert "eglibc: always compile with optimization."
>   eglibc: always compile with optimization.

I've queued this on master-next. I changed it from two commits to one
commit which just moves the code for the reason you describe.

Cheers,

Richard