Patchwork [bitbake-devel] hob: when BBLAYERS_NON_REMOVABLE is not set hob shows an error

login
register
mail settings
Submitter Cristiana Voicu
Date Nov. 27, 2012, 2:41 p.m.
Message ID <1354027291-9341-1-git-send-email-cristiana.voicu@intel.com>
Download mbox | patch
Permalink /patch/39695/
State New
Headers show

Comments

Cristiana Voicu - Nov. 27, 2012, 2:41 p.m.
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
---
 bitbake/lib/bb/ui/crumbs/hobeventhandler.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Richard Purdie - Nov. 28, 2012, 9:28 a.m.
On Tue, 2012-11-27 at 16:41 +0200, Cristiana Voicu wrote:
> Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
> ---
>  bitbake/lib/bb/ui/crumbs/hobeventhandler.py |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
> index ae1cefc..8a2ac5f 100644
> --- a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
> +++ b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
> @@ -435,7 +435,7 @@ class HobHandler(gobject.GObject):
>          params["core_base"] = self.runCommand(["getVariable", "COREBASE"]) or ""
>          hob_layer = params["core_base"] + "/meta-hob"
>          params["layer"] = self.runCommand(["getVariable", "BBLAYERS"]) or ""
> -        params["layers_non_removable"] = self.runCommand(["getVariable", "BBLAYERS_NON_REMOVABLE"])
> +        params["layers_non_removable"] = self.runCommand(["getVariable", "BBLAYERS_NON_REMOVABLE"]) or ""
>          if hob_layer not in params["layer"].split():
>              params["layer"] += (" " + hob_layer)
>          if hob_layer not in params["layers_non_removable"].split():

Merged to master, thanks.

Richard

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
index ae1cefc..8a2ac5f 100644
--- a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
+++ b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py
@@ -435,7 +435,7 @@  class HobHandler(gobject.GObject):
         params["core_base"] = self.runCommand(["getVariable", "COREBASE"]) or ""
         hob_layer = params["core_base"] + "/meta-hob"
         params["layer"] = self.runCommand(["getVariable", "BBLAYERS"]) or ""
-        params["layers_non_removable"] = self.runCommand(["getVariable", "BBLAYERS_NON_REMOVABLE"])
+        params["layers_non_removable"] = self.runCommand(["getVariable", "BBLAYERS_NON_REMOVABLE"]) or ""
         if hob_layer not in params["layer"].split():
             params["layer"] += (" " + hob_layer)
         if hob_layer not in params["layers_non_removable"].split():