Patchwork [v2] barebox: added recipe for barebox v 2010.10

login
register
mail settings
Submitter sujak.marek
Date Jan. 28, 2011, 1:07 p.m.
Message ID <1296220046-14636-1-git-send-email-sujak.marek@gmail.com>
Download mbox | patch
Permalink /patch/396/
State Superseded
Headers show

Comments

sujak.marek - Jan. 28, 2011, 1:07 p.m.
* included path for vmx25

Signed-off-by: sujak.marek <sujak.marek@gmail.com>
---
 recipes/barebox/barebox_2010.10.bb |   25 +++++++++++++++++++++++++
 1 files changed, 25 insertions(+), 0 deletions(-)
 create mode 100644 recipes/barebox/barebox_2010.10.bb
Petr Štetiar - Jan. 29, 2011, 2:07 p.m.
sujak.marek <sujak.marek@gmail.com> [2011-01-28 14:07:26]:

> +DEFAULT_PREFERENCE = "-1"
> +
> +# Mark archs/machines that this kernel supports
> +DEFAULT_PREFERENCE = "-1"

Duplicate DP=-1 and you can drop the comment also, it's wrong anyway.

-- ynezz
sujak.marek - Jan. 31, 2011, 8:43 a.m.
>
> Duplicate DP=-1 and you can drop the comment also, it's wrong anyway.
>

Done.  Should be removed in Patch v3. I was unable to git cherry-pick ... so
i rather cloned whole repository and make patch again.

Thanks
Marek
Petr Štetiar - Jan. 31, 2011, 9:21 p.m.
Marek Sujak <sujak.marek@gmail.com> [2011-01-31 09:43:58]:

> > Duplicate DP=-1 and you can drop the comment also, it's wrong anyway.
> 
> Done.  Should be removed in Patch v3. I was unable to git cherry-pick ... so
> i rather cloned whole repository and make patch again.

And that's why you've made it wrong again :-)

Yes, you've sent two patches, but with wrong content. It should be two patches,
but first one should add generic support for Barebox 2010.10 as Eric suggested
and the second one should contain support for your vmx25 machine for Barebox:

[patch v4] barebox: add recipe for 2010.10 release
[patch v4] barebox: add support for vmx25 machine

-- ynezz
Eric BENARD - Feb. 1, 2011, 7:32 a.m.
Hi,

On 01/02/2011 07:38, Marek Sujak wrote:
>> Yes i did that, i forgot to merge machine support patches. And after first
> commit it was to late for me to fix it.
>   At least "[Patch v3] barebox: added recipe for barebox v 2010.10" should be
> ok.
> Just machine support are divided to (1=patches + 2=recipe update)
> [PATCH v3] barebox: patches for barebox 2010.10 to support vmx25
> [PATCH v3] barebox: update barebox 2010.10 to support vmx25
>
> It is partially acceptable or should i rework it again?
>
I pushed your patches yesterday :
http://cgit.openembedded.net/cgit.cgi/openembedded/log/

Eric
sujak.marek - Feb. 1, 2011, 8:33 a.m.
Hi Eric

I pushed your patches yesterday :
> http://cgit.openembedded.net/cgit.cgi/openembedded/log/
>
> Thank you. There is one missing file "
http://permalink.gmane.org/gmane.comp.handhelds.openembedded/42041" which
seems to disappear by my mistake. That file should be merged in single patch
with previous one as Petr said (and it was not because i thought that my
arguing with git will not be conclusive enough).

I will post missing commit today as "patch v5". I'm sorry for troubles.

Best regards,
Marek

Patch

diff --git a/recipes/barebox/barebox_2010.10.bb b/recipes/barebox/barebox_2010.10.bb
new file mode 100644
index 0000000..b079a7c
--- /dev/null
+++ b/recipes/barebox/barebox_2010.10.bb
@@ -0,0 +1,25 @@ 
+require barebox.inc
+
+PR = "r0"
+
+DEFAULT_PREFERENCE = "-1"
+
+# Mark archs/machines that this kernel supports
+DEFAULT_PREFERENCE = "-1"
+DEFAULT_PREFERENCE_vmx25 = "1"
+
+BAREBOX_REVISION ?= "0"
+
+S = "${WORKDIR}/barebox-${PV}.${BAREBOX_REVISION}"
+
+SRC_URI = "\
+	http://barebox.org/download/barebox-${PV}.${BAREBOX_REVISION}.tar.bz2;name=barebox-${PV}.${BAREBOX_REVISION} \
+	file://defconfig \
+	"
+
+SRC_URI_append_vmx25 = "\
+	file://barebox_2010.10-vmx25-20110112.patch; \
+	"
+
+SRC_URI[barebox-2010.10.0.md5sum] = "60c208f86333430804d6e2ed40e4ff33"
+SRC_URI[barebox-2010.10.0.sha256sum] = "4ba3b6aa4cb0ad91dcf3c4f15951dc5f642ed86e5297bfd79d842cc1ad0b7841"