Patchwork [meta-networking] ntp: fix checksum

login
register
mail settings
Submitter Eric BENARD
Date Nov. 25, 2012, 11:13 p.m.
Message ID <1353885218-5623-1-git-send-email-eric@eukrea.com>
Download mbox | patch
Permalink /patch/39591/
State Superseded
Headers show

Comments

Eric BENARD - Nov. 25, 2012, 11:13 p.m.
commit e15543f05bb2c321cd649b90de50d1a3d8cd1199 upgrade the recipe to
a newer version but didn't update the checksum so fetch is failing.

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Paul Eggleton - Nov. 26, 2012, 10:34 a.m.
On Monday 26 November 2012 00:13:38 Eric Bénard wrote:
> commit e15543f05bb2c321cd649b90de50d1a3d8cd1199 upgrade the recipe to
> a newer version but didn't update the checksum so fetch is failing.
> 
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
>  meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
> b/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb index f7c5b68..0fce5ce
> 100644
> --- a/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
> +++ b/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
> @@ -8,8 +8,8 @@ SRC_URI =
> "http://www.eecis.udel.edu/~ntp/ntp_spool/ntp4/ntp-4.2/ntp-${PV}.tar.g
> file://ntpdate \
>  "
> 
> -SRC_URI[md5sum] = "59876a9009b098ff59767ee45a88ebd2"
> -SRC_URI[sha256sum] =
> "6e84d4ddfa14b911c3ed88463af10867e1fa9b287e7b34d8a02e78be85a7c40e"
> +SRC_URI[md5sum] = "00df80a84ec9528fcfb09498075525bc"
> +SRC_URI[sha256sum] =
> "d6ab8371f9d31e594eb6922823d5ccd03dcc4e9d84b0e23ea25ac1405432f91c"
> 
>  EXTRA_OECONF += " --with-net-snmp-config=no --without-ntpsnmpd"

Hmm, you're right - it did get missed. Strangely though if I do -c cleanall 
ntp then build ntp again I don't get an error with the wrong checksum (with 
danny) :/

Cheers,
Paul
Eric BENARD - Nov. 26, 2012, 10:38 a.m.
Hi Paul,

Le Mon, 26 Nov 2012 10:34:23 +0000,
Paul Eggleton <paul.eggleton@linux.intel.com> a écrit :

> On Monday 26 November 2012 00:13:38 Eric Bénard wrote:
> > commit e15543f05bb2c321cd649b90de50d1a3d8cd1199 upgrade the recipe to
> > a newer version but didn't update the checksum so fetch is failing.
> > 
> > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > ---
> >  meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
> > b/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb index f7c5b68..0fce5ce
> > 100644
> > --- a/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
> > +++ b/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
> > @@ -8,8 +8,8 @@ SRC_URI =
> > "http://www.eecis.udel.edu/~ntp/ntp_spool/ntp4/ntp-4.2/ntp-${PV}.tar.g
> > file://ntpdate \
> >  "
> > 
> > -SRC_URI[md5sum] = "59876a9009b098ff59767ee45a88ebd2"
> > -SRC_URI[sha256sum] =
> > "6e84d4ddfa14b911c3ed88463af10867e1fa9b287e7b34d8a02e78be85a7c40e"
> > +SRC_URI[md5sum] = "00df80a84ec9528fcfb09498075525bc"
> > +SRC_URI[sha256sum] =
> > "d6ab8371f9d31e594eb6922823d5ccd03dcc4e9d84b0e23ea25ac1405432f91c"
> > 
> >  EXTRA_OECONF += " --with-net-snmp-config=no --without-ntpsnmpd"
> 
> Hmm, you're right - it did get missed. Strangely though if I do -c cleanall 
> ntp then build ntp again I don't get an error with the wrong checksum (with 
> danny) :/
> 
I also met this kind of behaviour but didn't look in depth at it : it
seems that once a package is fetched, further builds won't trigger
an error if the checksum in the recipe is wrong. 

Eric
Paul Eggleton - Nov. 26, 2012, 10:47 a.m.
On Monday 26 November 2012 11:38:53 Eric Bénard wrote:
> Hi Paul,
> 
> Le Mon, 26 Nov 2012 10:34:23 +0000,
> 
> Paul Eggleton <paul.eggleton@linux.intel.com> a écrit :
> > On Monday 26 November 2012 00:13:38 Eric Bénard wrote:
> > > commit e15543f05bb2c321cd649b90de50d1a3d8cd1199 upgrade the recipe to
> > > a newer version but didn't update the checksum so fetch is failing.
> > > 
> > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > > ---
> > > 
> > >  meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
> > > b/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb index
> > > f7c5b68..0fce5ce
> > > 100644
> > > --- a/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
> > > +++ b/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
> > > @@ -8,8 +8,8 @@ SRC_URI =
> > > "http://www.eecis.udel.edu/~ntp/ntp_spool/ntp4/ntp-4.2/ntp-${PV}.tar.g
> > > file://ntpdate \
> > > 
> > >  "
> > > 
> > > -SRC_URI[md5sum] = "59876a9009b098ff59767ee45a88ebd2"
> > > -SRC_URI[sha256sum] =
> > > "6e84d4ddfa14b911c3ed88463af10867e1fa9b287e7b34d8a02e78be85a7c40e"
> > > +SRC_URI[md5sum] = "00df80a84ec9528fcfb09498075525bc"
> > > +SRC_URI[sha256sum] =
> > > "d6ab8371f9d31e594eb6922823d5ccd03dcc4e9d84b0e23ea25ac1405432f91c"
> > > 
> > >  EXTRA_OECONF += " --with-net-snmp-config=no --without-ntpsnmpd"
> > 
> > Hmm, you're right - it did get missed. Strangely though if I do -c
> > cleanall
> > ntp then build ntp again I don't get an error with the wrong checksum
> > (with
> > danny) :/
> 
> I also met this kind of behaviour but didn't look in depth at it : it
> seems that once a package is fetched, further builds won't trigger
> an error if the checksum in the recipe is wrong.

The checksum is not verified if the .done file exists on the assumption that the 
fetch completed successfully and has already been verified; however when I did 
-c cleanall I checked - there was no .done file, so this is unexpected 
behaviour.

Cheers,
Paul

Patch

diff --git a/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb b/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
index f7c5b68..0fce5ce 100644
--- a/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
+++ b/meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
@@ -8,8 +8,8 @@  SRC_URI = "http://www.eecis.udel.edu/~ntp/ntp_spool/ntp4/ntp-4.2/ntp-${PV}.tar.g
         file://ntpdate \
 "
 
-SRC_URI[md5sum] = "59876a9009b098ff59767ee45a88ebd2"
-SRC_URI[sha256sum] = "6e84d4ddfa14b911c3ed88463af10867e1fa9b287e7b34d8a02e78be85a7c40e"
+SRC_URI[md5sum] = "00df80a84ec9528fcfb09498075525bc"
+SRC_URI[sha256sum] = "d6ab8371f9d31e594eb6922823d5ccd03dcc4e9d84b0e23ea25ac1405432f91c"
 
 EXTRA_OECONF += " --with-net-snmp-config=no --without-ntpsnmpd"