Patchwork [08/12] matchbox-panel: depend on xterm(matchbox panel contain an xterm launcher)

login
register
mail settings
Submitter Denis Carikli
Date May 13, 2011, 12:43 p.m.
Message ID <1305290588-7057-8-git-send-email-GNUtoo@no-log.org>
Download mbox | patch
Permalink /patch/3949/
State Rejected
Headers show

Comments

Denis Carikli - May 13, 2011, 12:43 p.m.
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
---
 recipes/matchbox-panel/matchbox-panel_0.9.3.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Stefan Schmidt - May 13, 2011, 6:13 p.m.
Hello.

On Fri, 2011-05-13 at 14:43, Denis 'GNUtoo' Carikli wrote:
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>

Interesting find. I never thought about it. Is the xterm launcher
enabled by default?

regards
Stefan Schmidt
Florian Boor - May 15, 2011, 8:04 p.m.
Hi,

Am 13.05.2011 14:43, schrieb Denis 'GNUtoo' Carikli:
> +RDEPENDS += "xterm"

I do not like this one. I have been using matchbox-panel for many years without
having xterm installed.

Greetings

Florian
Phil Blundell - May 15, 2011, 8:32 p.m.
On Sun, 2011-05-15 at 22:04 +0200, Florian Boor wrote:
> Hi,
> 
> Am 13.05.2011 14:43, schrieb Denis 'GNUtoo' Carikli:
> > +RDEPENDS += "xterm"
> 
> I do not like this one. I have been using matchbox-panel for many years without
> having xterm installed.

Agreed, it should be RRECOMMENDS.  Also, whatever kind of dependency is
used, it should be applied only to ${PN} and not all subpackages.

Setting plain RDEPENDS is almost always an error, and I'm fairly sure
there is a QA diagnostic for this.  So, if this kind of thing shows up
in a submitted patch it always makes me question whether the patch has
actually been tested or not.

p.

Patch

diff --git a/recipes/matchbox-panel/matchbox-panel_0.9.3.bb b/recipes/matchbox-panel/matchbox-panel_0.9.3.bb
index 092d8ba..221f0ad 100644
--- a/recipes/matchbox-panel/matchbox-panel_0.9.3.bb
+++ b/recipes/matchbox-panel/matchbox-panel_0.9.3.bb
@@ -1,5 +1,6 @@ 
 require matchbox-panel.inc
-PR ="r6"
+RDEPENDS += "xterm"
+PR ="r7"
 SRC_URI = "http://projects.o-hand.com/matchbox/sources/${PN}/0.9/${PN}-${PV}.tar.gz \
 	   file://mb-applet-battery-repaint-093.patch \
 	   file://mb-applet-system-monitor-crash.patch \