| Message ID | 20240215213705.3315438-1-tgamblin@baylibre.com |
|---|---|
| State | Accepted, archived |
| Commit | 1ce51580a23869a9c0f409446ff717d471fb60db |
| Headers | show |
| Series | patchtest-send-results: use Message-ID directly | expand |
Just wanted to note that sadly patchtest replies still aren't threaded. What are regular mail clients doing that patchtest does not? Alex On Thu, 15 Feb 2024 at 22:37, Trevor Gamblin <tgamblin@baylibre.com> wrote: > > There's no need to use regex for extracting the Message-ID field from > the patch email and mangle it by removing the angle brackets in the > process. Pull it directly from the mbox so that Patchtest's replies have > even fewer differences when compared to other replies. Also add a TODO > so that it's clear this needs adjustment when full series support is > added. > > Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com> > --- > scripts/patchtest-send-results | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/scripts/patchtest-send-results b/scripts/patchtest-send-results > index 8190fe86c32..8a3dadbd111 100755 > --- a/scripts/patchtest-send-results > +++ b/scripts/patchtest-send-results > @@ -65,7 +65,9 @@ subject_line = f"Patchtest results for {mbox_subject}" > reply_address = mbox[0]['from'] > > # extract the message ID and use that as the in-reply-to address > -in_reply_to = re.findall("<(.*)>", mbox[0]['Message-ID'])[0] > +# TODO: This will need to change again when patchtest can handle a whole > +# series at once > +in_reply_to = mbox[0]['Message-ID'] > > # the address the results email is sent from > from_address = "patchtest@automation.yoctoproject.org" > -- > 2.43.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#195705): https://lists.openembedded.org/g/openembedded-core/message/195705 > Mute This Topic: https://lists.openembedded.org/mt/104382040/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On 2024-02-16 04:35, Alexander Kanavin wrote: > Just wanted to note that sadly patchtest replies still aren't > threaded. What are regular mail clients doing that patchtest does not? Patchwork's docs say (https://patchwork.readthedocs.io/en/latest/usage/overview/#comments): |Comments are replies to a submission - either a patch or a cover letter. Unlike a Mail User Agent (MUA) like Gmail, Patchwork does not thread comments. Instead, every comment is associated with either a patch or a cover letter, and organized by date.| I'm wondering if maybe it's as simple as the subject line being too different - instead of "Patchtest results for [OE-core][PATCH 1/2] patchtest: Fix grammar in log output", maybe it just needs to reply with the exact subject line like anyone else. That being said, I haven't seen the Patchtest service send a result since that change was merged... > > Alex > > On Thu, 15 Feb 2024 at 22:37, Trevor Gamblin<tgamblin@baylibre.com> wrote: >> There's no need to use regex for extracting the Message-ID field from >> the patch email and mangle it by removing the angle brackets in the >> process. Pull it directly from the mbox so that Patchtest's replies have >> even fewer differences when compared to other replies. Also add a TODO >> so that it's clear this needs adjustment when full series support is >> added. >> >> Signed-off-by: Trevor Gamblin<tgamblin@baylibre.com> >> --- >> scripts/patchtest-send-results | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/scripts/patchtest-send-results b/scripts/patchtest-send-results >> index 8190fe86c32..8a3dadbd111 100755 >> --- a/scripts/patchtest-send-results >> +++ b/scripts/patchtest-send-results >> @@ -65,7 +65,9 @@ subject_line = f"Patchtest results for {mbox_subject}" >> reply_address = mbox[0]['from'] >> >> # extract the message ID and use that as the in-reply-to address >> -in_reply_to = re.findall("<(.*)>", mbox[0]['Message-ID'])[0] >> +# TODO: This will need to change again when patchtest can handle a whole >> +# series at once >> +in_reply_to = mbox[0]['Message-ID'] >> >> # the address the results email is sent from >> from_address ="patchtest@automation.yoctoproject.org" >> -- >> 2.43.0 >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#195705):https://lists.openembedded.org/g/openembedded-core/message/195705 >> Mute This Topic:https://lists.openembedded.org/mt/104382040/1686489 >> Group Owner:openembedded-core+owner@lists.openembedded.org >> Unsubscribe:https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] >> -=-=-=-=-=-=-=-=-=-=-=- >>
diff --git a/scripts/patchtest-send-results b/scripts/patchtest-send-results index 8190fe86c32..8a3dadbd111 100755 --- a/scripts/patchtest-send-results +++ b/scripts/patchtest-send-results @@ -65,7 +65,9 @@ subject_line = f"Patchtest results for {mbox_subject}" reply_address = mbox[0]['from'] # extract the message ID and use that as the in-reply-to address -in_reply_to = re.findall("<(.*)>", mbox[0]['Message-ID'])[0] +# TODO: This will need to change again when patchtest can handle a whole +# series at once +in_reply_to = mbox[0]['Message-ID'] # the address the results email is sent from from_address = "patchtest@automation.yoctoproject.org"
There's no need to use regex for extracting the Message-ID field from the patch email and mangle it by removing the angle brackets in the process. Pull it directly from the mbox so that Patchtest's replies have even fewer differences when compared to other replies. Also add a TODO so that it's clear this needs adjustment when full series support is added. Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com> --- scripts/patchtest-send-results | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)