Patchwork [3/3] lsb: move links from lsbsetup to here

login
register
mail settings
Submitter Kang Kai
Date Nov. 22, 2012, 3:25 a.m.
Message ID <109a6ebf14ab5d312954f371eaf3bbfbcb6fb2d0.1353553774.git.kai.kang@windriver.com>
Download mbox | patch
Permalink /patch/39449/
State Accepted
Commit 7659ad17799672d48c4d8614e830b7e60a1e971a
Headers show

Comments

Kang Kai - Nov. 22, 2012, 3:25 a.m.
Because package lsbsetup is dropped, move the links created for LSB test
to package lsb.

Signed-off-by: Kang Kai <kai.kang@windriver.com>
---
 meta/recipes-extended/lsb/lsb_4.1.bb |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)
Otavio Salvador - Nov. 22, 2012, 10:37 a.m.
On Thu, Nov 22, 2012 at 1:25 AM, Kang Kai <kai.kang@windriver.com> wrote:
> Because package lsbsetup is dropped, move the links created for LSB test
> to package lsb.
>
> Signed-off-by: Kang Kai <kai.kang@windriver.com>

This ought to be done before of dropping lsbsetup too.
Richard Purdie - Nov. 22, 2012, 10:41 a.m.
On Thu, 2012-11-22 at 08:37 -0200, Otavio Salvador wrote:
> On Thu, Nov 22, 2012 at 1:25 AM, Kang Kai <kai.kang@windriver.com> wrote:
> > Because package lsbsetup is dropped, move the links created for LSB test
> > to package lsb.
> >
> > Signed-off-by: Kang Kai <kai.kang@windriver.com>
> 
> This ought to be done before of dropping lsbsetup too.

I've queued them that way around in master-next.

Cheers,

Richard
Kang Kai - Nov. 23, 2012, 1:42 a.m.
On 2012?11?22? 18:37, Otavio Salvador wrote:
> On Thu, Nov 22, 2012 at 1:25 AM, Kang Kai<kai.kang@windriver.com>  wrote:
>> Because package lsbsetup is dropped, move the links created for LSB test
>> to package lsb.
>>
>> Signed-off-by: Kang Kai<kai.kang@windriver.com>
> This ought to be done before of dropping lsbsetup too.
>

Hi Otavio,

Thanks a lot for your comments.

About the patch of packagegroup-core-lsb, I agree with you that lsbsetup 
should be removed from the list before drop the package.

But for this patch, if do links before drop the lsbsetup, when do 
install it may warn something like 'there already a file 
${D}/${libdir}/lsb/install_initd'.

Regards,
Kai

Patch

diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
index 55ea241..01368b3 100644
--- a/meta/recipes-extended/lsb/lsb_4.1.bb
+++ b/meta/recipes-extended/lsb/lsb_4.1.bb
@@ -2,7 +2,7 @@  DESCRIPTION = "LSB support for OpenEmbedded"
 SECTION = "console/utils"
 HOMEPAGE = "http://prdownloads.sourceforge.net/lsb"
 LICENSE = "GPLv2+"
-PR = "r0"
+PR = "r1"
 
 # lsb_release needs getopt
 RDEPENDS_${PN} += "util-linux"
@@ -73,6 +73,13 @@  do_install_append(){
            install -m 0755 ${WORKDIR}/${i} ${D}${sysconfdir}/core-lsb
        done
        install -m 0755 ${WORKDIR}/init-functions ${D}/${baselib}/lsb
+
+       # creat links for LSB test
+       install -d ${D}/${libdir}/lsb
+       ln -sf ${base_sbindir}/chkconfig ${D}/${libdir}/lsb/install_initd
+       ln -sf ${base_sbindir}/chkconfig ${D}/${libdir}/lsb/remove_initd
+       ln -sf ${sbindir}/sendmail ${D}/${libdir}/sendmail
+
        if [ "${TARGET_ARCH}" = "x86_64" ];then
 	       cd ${D}
                if [ "${baselib}" != "lib64" ]; then
@@ -105,4 +112,5 @@  do_install_append(){
 }
 FILES_${PN} += "/lib64 \
                 ${base_libdir}/lsb/* \
+		${libdir}/sendmail \
                "