Patchwork insane.bbclass : Disable tests for unsafe references in binaries and scripts.

login
register
mail settings
Submitter Philip Balister
Date Nov. 21, 2012, 5:21 p.m.
Message ID <1353518473-27252-1-git-send-email-philip@balister.org>
Download mbox | patch
Permalink /patch/39417/
State Accepted
Commit 7a7f9489d32447e717b82d5b21488a3f09ef6581
Headers show

Comments

Philip Balister - Nov. 21, 2012, 5:21 p.m.
These test look for programs in / that depend on programs in /usr. After
a brief discussion in #oe, we decided these tests should be disabled so
we can focus on more serious QA issues.

If you are working on a system where / and /usr are on different partitions,
you should turn these tests back on and resolving the QA warnings.

Signed-off-by: Philip Balister <philip@balister.org>
---
 meta/classes/insane.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Paul Eggleton - Nov. 21, 2012, 5:25 p.m.
On Wednesday 21 November 2012 12:21:13 Philip Balister wrote:
> These test look for programs in / that depend on programs in /usr. After
> a brief discussion in #oe, we decided these tests should be disabled so
> we can focus on more serious QA issues.
> 
> If you are working on a system where / and /usr are on different partitions,
> you should turn these tests back on and resolving the QA warnings.
> 
> Signed-off-by: Philip Balister <philip@balister.org>
> ---
>  meta/classes/insane.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index 237ee82..c5c84b8 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -113,7 +113,7 @@ def package_qa_get_machine_dict():
> 
> 
>  # Currently not being used by default "desktop"
> -WARN_QA ?= "ldflags useless-rpaths rpaths unsafe-references-in-binaries
> unsafe-references-in-scripts staticdev libdir xorg-driver-abi textrel"
> +WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi
> textrel" ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch la2
> pkgconfig la perms dep-cmp"
> 
>  ALL_QA = "${WARN_QA} ${ERROR_QA}"

Acked-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Martin Jansa - Nov. 21, 2012, 5:26 p.m.
On Wed, Nov 21, 2012 at 12:21:13PM -0500, Philip Balister wrote:
> These test look for programs in / that depend on programs in /usr. After
> a brief discussion in #oe, we decided these tests should be disabled so
> we can focus on more serious QA issues.
> 
> If you are working on a system where / and /usr are on different partitions,
> you should turn these tests back on and resolving the QA warnings.
> 
> Signed-off-by: Philip Balister <philip@balister.org>
> ---
>  meta/classes/insane.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index 237ee82..c5c84b8 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -113,7 +113,7 @@ def package_qa_get_machine_dict():
>  
>  
>  # Currently not being used by default "desktop"
> -WARN_QA ?= "ldflags useless-rpaths rpaths unsafe-references-in-binaries unsafe-references-in-scripts staticdev libdir xorg-driver-abi textrel"
> +WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi textrel"
>  ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch la2 pkgconfig la perms dep-cmp"
>  
>  ALL_QA = "${WARN_QA} ${ERROR_QA}"

Acked-by: Martin Jansa <Martin.Jansa@gmail.com>
Otavio Salvador - Nov. 21, 2012, 5:41 p.m.
On Wed, Nov 21, 2012 at 3:21 PM, Philip Balister <philip@balister.org> wrote:
> These test look for programs in / that depend on programs in /usr. After
> a brief discussion in #oe, we decided these tests should be disabled so
> we can focus on more serious QA issues.
>
> If you are working on a system where / and /usr are on different partitions,
> you should turn these tests back on and resolving the QA warnings.
>
> Signed-off-by: Philip Balister <philip@balister.org>

+1

Patch

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 237ee82..c5c84b8 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -113,7 +113,7 @@  def package_qa_get_machine_dict():
 
 
 # Currently not being used by default "desktop"
-WARN_QA ?= "ldflags useless-rpaths rpaths unsafe-references-in-binaries unsafe-references-in-scripts staticdev libdir xorg-driver-abi textrel"
+WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi textrel"
 ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch la2 pkgconfig la perms dep-cmp"
 
 ALL_QA = "${WARN_QA} ${ERROR_QA}"