Patchwork distutils-common : Add -staticdev to PACKAGES.

login
register
mail settings
Submitter Philip Balister
Date Nov. 20, 2012, 10:58 p.m.
Message ID <1353452291-3503-1-git-send-email-philip@balister.org>
Download mbox | patch
Permalink /patch/39377/
State New
Headers show

Comments

Philip Balister - Nov. 20, 2012, 10:58 p.m.
Some python recipes may build static libraries that need packaging in
{PN}-static-dev.

This change fixes a QA error in python-numpy.

Signed-off-by: Philip Balister <philip@balister.org>
---
 meta/classes/distutils-common-base.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Stefan Herbrechtsmeier - Nov. 21, 2012, 6:03 a.m.
Am 20.11.2012 23:58, schrieb Philip Balister:
> Some python recipes may build static libraries that need packaging in
> {PN}-static-dev.
>
> This change fixes a QA error in python-numpy.
>
> Signed-off-by: Philip Balister <philip@balister.org>
> ---
>   meta/classes/distutils-common-base.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/distutils-common-base.bbclass b/meta/classes/distutils-common-base.bbclass
> index f66a5cd..36c1e83 100644
> --- a/meta/classes/distutils-common-base.bbclass
> +++ b/meta/classes/distutils-common-base.bbclass
> @@ -5,7 +5,7 @@ EXTRA_OEMAKE = ""
>   export STAGING_INCDIR
>   export STAGING_LIBDIR
>   
> -PACKAGES = "${PN}-dev ${PN}-dbg ${PN}-doc ${PN}"
> +PACKAGES = "${PN}-staticdev ${PN}-dev ${PN}-dbg ${PN}-doc ${PN}"
>   
>   FILES_${PN} = "${bindir}/* ${libdir}/* ${libdir}/${PYTHON_DIR}/*"
>   
Hi,

I post a similarly patch parallel with the python-numpy fix:
http://comments.gmane.org/gmane.comp.handhelds.openembedded.core/29575

Regards,
   Stefan
Philip Balister - Nov. 21, 2012, 12:59 p.m.
On 11/21/2012 01:03 AM, Stefan Herbrechtsmeier wrote:
> Am 20.11.2012 23:58, schrieb Philip Balister:
>> Some python recipes may build static libraries that need packaging in
>> {PN}-static-dev.
>>
>> This change fixes a QA error in python-numpy.
>>
>> Signed-off-by: Philip Balister <philip@balister.org>
>> ---
>>   meta/classes/distutils-common-base.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/distutils-common-base.bbclass
>> b/meta/classes/distutils-common-base.bbclass
>> index f66a5cd..36c1e83 100644
>> --- a/meta/classes/distutils-common-base.bbclass
>> +++ b/meta/classes/distutils-common-base.bbclass
>> @@ -5,7 +5,7 @@ EXTRA_OEMAKE = ""
>>   export STAGING_INCDIR
>>   export STAGING_LIBDIR
>> -PACKAGES = "${PN}-dev ${PN}-dbg ${PN}-doc ${PN}"
>> +PACKAGES = "${PN}-staticdev ${PN}-dev ${PN}-dbg ${PN}-doc ${PN}"
>>   FILES_${PN} = "${bindir}/* ${libdir}/* ${libdir}/${PYTHON_DIR}/*"
> Hi,
>
> I post a similarly patch parallel with the python-numpy fix:
> http://comments.gmane.org/gmane.comp.handhelds.openembedded.core/29575

Provided the:

+FILES_${PN}-staticdev += "\
+  ${PYTHON_SITEPACKAGES_DIR}/*.a \
+"

Actually catches a lot of the .a files, I prefer Stefan's version. Numpy 
still needs to to override the FILES though.

Philip

PS: WARNING, I am not a python expert, just trying to help fix QA issues 
as they come up.

>
> Regards,
>    Stefan
>

Patch

diff --git a/meta/classes/distutils-common-base.bbclass b/meta/classes/distutils-common-base.bbclass
index f66a5cd..36c1e83 100644
--- a/meta/classes/distutils-common-base.bbclass
+++ b/meta/classes/distutils-common-base.bbclass
@@ -5,7 +5,7 @@  EXTRA_OEMAKE = ""
 export STAGING_INCDIR
 export STAGING_LIBDIR
 
-PACKAGES = "${PN}-dev ${PN}-dbg ${PN}-doc ${PN}"
+PACKAGES = "${PN}-staticdev ${PN}-dev ${PN}-dbg ${PN}-doc ${PN}"
 
 FILES_${PN} = "${bindir}/* ${libdir}/* ${libdir}/${PYTHON_DIR}/*"