Patchwork [PATCHv2] gst-plugins-base: add dep on libsm and libice

login
register
mail settings
Submitter Gilbert Coville
Date Nov. 20, 2012, 10:34 p.m.
Message ID <1353450851-7252-1-git-send-email-gilbert_coville@mentor.com>
Download mbox | patch
Permalink /patch/39375/
State New
Headers show

Comments

Gilbert Coville - Nov. 20, 2012, 10:34 p.m.
If libICE exists when this package configures, libICE and libSM are
added to the list of included libraries.  Adding libsm and libice to the
list of dependencies ensures they'll be present and makes the contents
of this package more deterministic.

Signed-off-by: Gilbert Coville <gilbert_coville@mentor.com>
---
 meta/recipes-multimedia/gstreamer/gst-plugins-base_0.10.36.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Ross Burton - Nov. 21, 2012, 11:28 a.m.
On 20 November 2012 22:34, Gilbert Coville <gilbert_coville@mentor.com> wrote:
> If libICE exists when this package configures, libICE and libSM are
> added to the list of included libraries.  Adding libsm and libice to the
> list of dependencies ensures they'll be present and makes the contents
> of this package more deterministic.

I suspected this was the reason.  That's AC_PATH_XTRA being stupid as
usual.   I wonder if upstream would replace that with a PKG_CONFIG
call for x11.pc.

Grudingly Acked-By: Ross Burton <ross.burton@intel.com>

Ross

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins-base_0.10.36.bb b/meta/recipes-multimedia/gstreamer/gst-plugins-base_0.10.36.bb
index 88fa74d..2648864 100644
--- a/meta/recipes-multimedia/gstreamer/gst-plugins-base_0.10.36.bb
+++ b/meta/recipes-multimedia/gstreamer/gst-plugins-base_0.10.36.bb
@@ -6,7 +6,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
                     file://COPYING.LIB;md5=55ca817ccb7d5b5b66355690e9abc605 \
                     file://gst/ffmpegcolorspace/utils.c;beginline=1;endline=20;md5=9c83a200b8e597b26ca29df20fc6ecd0"
 
-DEPENDS += "${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxv', '', d)}"
+DEPENDS += "${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxv libsm libice', '', d)}"
 DEPENDS += "alsa-lib freetype liboil libogg libvorbis libtheora util-linux tremor"
 
 SRC_URI += "file://gst-plugins-base-tremor.patch \
@@ -15,7 +15,7 @@  SRC_URI += "file://gst-plugins-base-tremor.patch \
 SRC_URI[md5sum] = "776c73883e567f67b9c4a2847d8d041a"
 SRC_URI[sha256sum] = "2cd3b0fa8e9b595db8f514ef7c2bdbcd639a0d63d154c00f8c9b609321f49976"
 
-PR = "r5"
+PR = "r6"
 
 inherit gettext