Patchwork utils: Optimise looping in base_set_filespath

login
register
mail settings
Submitter Richard Purdie
Date Nov. 19, 2012, 11:44 p.m.
Message ID <1353368656.3709.212.camel@ted>
Download mbox | patch
Permalink /patch/39299/
State Accepted
Commit 566c0e874fc1610f3f97737b5601ef22026c918a
Headers show

Comments

Richard Purdie - Nov. 19, 2012, 11:44 p.m.
Calling split on the same expression, once per loop iteration is
inefficient and pointless, particularly in a function called by
every recipe during parsing.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

Patch

diff --git a/meta/classes/utils.bbclass b/meta/classes/utils.bbclass
index 52e511f..c1de2f6 100644
--- a/meta/classes/utils.bbclass
+++ b/meta/classes/utils.bbclass
@@ -308,10 +308,10 @@  def base_set_filespath(path, d):
     if extrapaths != "":
         path = extrapaths.split(":") + path
     # The ":" ensures we have an 'empty' override
-    overrides = (d.getVar("OVERRIDES", True) or "") + ":"
+    overrides = ((d.getVar("OVERRIDES", True) or "") + ":").split(":")
     for p in path:
         if p != "": 
-            for o in overrides.split(":"):
+            for o in overrides:
                 filespath.append(os.path.join(p, o))
     return ":".join(filespath)