Patchwork [0/2] Consolidate _FOR_BUILD variables

login
mail settings
Submitter Ross Burton
Date Nov. 9, 2012, 10:09 a.m.
Message ID <cover.1352455397.git.ross.burton@intel.com>
Download mbox
Permalink /patch/38839/
State New
Headers show

Pull-request

git://git.yoctoproject.org/poky-contrib ross/cross

Comments

Ross Burton - Nov. 9, 2012, 10:09 a.m.
Hi,

It's autotools best practise[1] to use the variables CC_FOR_BUILD etc when
building tools that are required to build the rest of the package.  A lot of
packages do this, and they all repeat the same variable assignements, so
consolidate these assignments in autotools.bbclass.

Not every instance of _FOR_BUILD has been removed from the metadata, as there
are several cases where the assignment isn't the same (added flags, mainly).

Tested with a world build of oe-core, zero buildhistory differences.

Ross

[1] http://www.sourceware.org/autobook/autobook/autobook_270.html#SEC270

The following changes since commit 78983e939ab17f02f8911c8b0d0e326b419856b9:

  lib/oe/classextend: Ensure we don't extend expressions more than once (2012-11-06 09:34:47 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib ross/cross

for you to fetch changes up to 154a30032b03a9ce269752adbf5bbec85205720e:

  meta: remove redundant _FOR_BUILD variables (2012-11-09 10:00:05 +0000)

----------------------------------------------------------------
Ross Burton (2):
      autotools: set _FOR_BUILD variables here
      meta: remove redundant _FOR_BUILD variables

 meta/classes/autotools.bbclass                 |   15 +++++++++++++++
 meta/recipes-devtools/binutils/binutils.inc    |    4 ++--
 meta/recipes-devtools/rpm/rpm_5.4.9.bb         |    1 -
 meta/recipes-extended/bash/bash.inc            |    1 -
 meta/recipes-gnome/gnome/metacity_2.30.3.bb    |    5 ++---
 meta/recipes-graphics/mutter/mutter.inc        |    5 ++---
 meta/recipes-graphics/xorg-lib/libx11.inc      |    8 ++------
 meta/recipes-kernel/systemtap/systemtap_git.bb |    4 ----
 meta/recipes-support/gmp/gmp_4.2.1.bb          |    2 --
 meta/recipes-support/gmp/gmp_5.0.5.bb          |    2 --
 10 files changed, 23 insertions(+), 24 deletions(-)

Ross Burton (2):
  autotools: set _FOR_BUILD variables here
  meta: remove redundant _FOR_BUILD variables

 meta/classes/autotools.bbclass                 |   15 +++++++++++++++
 meta/recipes-devtools/binutils/binutils.inc    |    4 ++--
 meta/recipes-devtools/rpm/rpm_5.4.9.bb         |    1 -
 meta/recipes-extended/bash/bash.inc            |    1 -
 meta/recipes-gnome/gnome/metacity_2.30.3.bb    |    5 ++---
 meta/recipes-graphics/mutter/mutter.inc        |    5 ++---
 meta/recipes-graphics/xorg-lib/libx11.inc      |    8 ++------
 meta/recipes-kernel/systemtap/systemtap_git.bb |    4 ----
 meta/recipes-support/gmp/gmp_4.2.1.bb          |    2 --
 meta/recipes-support/gmp/gmp_5.0.5.bb          |    2 --
 10 files changed, 23 insertions(+), 24 deletions(-)