Patchwork gnomebase: depend on gnome-common-native

login
register
mail settings
Submitter Ross Burton
Date Oct. 30, 2012, 11:30 a.m.
Message ID <1351596626-6603-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/38705/
State Accepted
Commit f3fc98db5233fb7c6e025a4085aad270a1f8f145
Headers show

Comments

Ross Burton - Oct. 30, 2012, 11:30 a.m.
gnome-common is a build-only dependency so we should depend on the native
variant.  This also resolves an (incorrect) GPLv3 license issue in gnome-common
at build-time.

This will also remove the pointless gnome-common-dev RRECOMMENDS in any -dev
package that uses gnomebase.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/classes/gnomebase.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Andrei Gherzan - Oct. 30, 2012, 11:29 p.m.
Acked.


On Tue, Oct 30, 2012 at 1:30 PM, Ross Burton <ross.burton@intel.com> wrote:

> gnome-common is a build-only dependency so we should depend on the native
> variant.  This also resolves an (incorrect) GPLv3 license issue in
> gnome-common
> at build-time.
>
> This will also remove the pointless gnome-common-dev RRECOMMENDS in any
> -dev
> package that uses gnomebase.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/classes/gnomebase.bbclass |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/gnomebase.bbclass
> b/meta/classes/gnomebase.bbclass
> index 19c7f71..91c476c 100644
> --- a/meta/classes/gnomebase.bbclass
> +++ b/meta/classes/gnomebase.bbclass
> @@ -7,7 +7,7 @@ GNOME_COMPRESS_TYPE ?= "bz2"
>  SECTION ?= "x11/gnome"
>  SRC_URI =
> "${GNOME_MIRROR}/${BPN}/${@gnome_verdir("${PV}")}/${BPN}-${PV}.tar.${GNOME_COMPRESS_TYPE};name=archive"
>
> -DEPENDS += "gnome-common"
> +DEPENDS += "gnome-common-native"
>
>  FILES_${PN} += "${datadir}/application-registry  \
>         ${datadir}/mime-info \
> --
> 1.7.10
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/classes/gnomebase.bbclass b/meta/classes/gnomebase.bbclass
index 19c7f71..91c476c 100644
--- a/meta/classes/gnomebase.bbclass
+++ b/meta/classes/gnomebase.bbclass
@@ -7,7 +7,7 @@  GNOME_COMPRESS_TYPE ?= "bz2"
 SECTION ?= "x11/gnome"
 SRC_URI = "${GNOME_MIRROR}/${BPN}/${@gnome_verdir("${PV}")}/${BPN}-${PV}.tar.${GNOME_COMPRESS_TYPE};name=archive"
 
-DEPENDS += "gnome-common"
+DEPENDS += "gnome-common-native"
 
 FILES_${PN} += "${datadir}/application-registry  \
 	${datadir}/mime-info \