Patchwork openssl: Use ${CFLAGS} not ${FULL_OPTIMIZATION}

login
register
mail settings
Submitter Phil Blundell
Date Oct. 29, 2012, 3:20 p.m.
Message ID <1351524020.13864.17.camel@phil-desktop>
Download mbox | patch
Permalink /patch/38667/
State Accepted
Commit e9e3285e1397cfd2d34f4eb7b5aa59311eea861d
Headers show

Comments

Phil Blundell - Oct. 29, 2012, 3:20 p.m.
The latter variable is only applicable for target builds and could
result in passing incompatible options (and/or failing to pass
required options) to ${BUILD_CC} for a virtclass-native build.

Signed-off-by: Phil Blundell <philb@gnu.org>
---
 meta/recipes-connectivity/openssl/openssl.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Saul Wold - Oct. 31, 2012, 6:56 a.m.
On 10/29/2012 08:20 AM, Phil Blundell wrote:
> The latter variable is only applicable for target builds and could
> result in passing incompatible options (and/or failing to pass
> required options) to ${BUILD_CC} for a virtclass-native build.
>
> Signed-off-by: Phil Blundell <philb@gnu.org>
> ---
>   meta/recipes-connectivity/openssl/openssl.inc |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/openssl/openssl.inc b/meta/recipes-connectivity/openssl/openssl.inc
> index 089b9a4..1b2be93 100644
> --- a/meta/recipes-connectivity/openssl/openssl.inc
> +++ b/meta/recipes-connectivity/openssl/openssl.inc
> @@ -19,7 +19,7 @@ S = "${WORKDIR}/openssl-${PV}"
>
>   AR_append = " r"
>   CFLAG = "${@base_conditional('SITEINFO_ENDIANNESS', 'le', '-DL_ENDIAN', '-DB_ENDIAN', d)} \
> -	-DTERMIO ${FULL_OPTIMIZATION} -Wall"
> +	-DTERMIO ${CFLAGS} -Wall"
>
>   # Avoid binaries being marked as requiring an executable stack (which causes
>   # issues with SELinux on the host)
>
Merged into OE-Core

Thanks
	Sau!

Patch

diff --git a/meta/recipes-connectivity/openssl/openssl.inc b/meta/recipes-connectivity/openssl/openssl.inc
index 089b9a4..1b2be93 100644
--- a/meta/recipes-connectivity/openssl/openssl.inc
+++ b/meta/recipes-connectivity/openssl/openssl.inc
@@ -19,7 +19,7 @@  S = "${WORKDIR}/openssl-${PV}"
 
 AR_append = " r"
 CFLAG = "${@base_conditional('SITEINFO_ENDIANNESS', 'le', '-DL_ENDIAN', '-DB_ENDIAN', d)} \
-	-DTERMIO ${FULL_OPTIMIZATION} -Wall"
+	-DTERMIO ${CFLAGS} -Wall"
 
 # Avoid binaries being marked as requiring an executable stack (which causes 
 # issues with SELinux on the host)