Patchwork [bitbake-devel] hob: during recipe parsing, progress bar text provides details about the process state

login
register
mail settings
Submitter Cristiana Voicu
Date Oct. 25, 2012, 1:43 p.m.
Message ID <1351172624-25566-1-git-send-email-cristiana.voicu@intel.com>
Download mbox | patch
Permalink /patch/38569/
State New
Headers show

Comments

Cristiana Voicu - Oct. 25, 2012, 1:43 p.m.
- indicating on progress bar that hob has gone from parsing
recipes to "Generating dependency tree"; this will provide
some visibility of what has caused the "stop" button state
to change

[YOCTO #3282]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
---
 bitbake/lib/bb/ui/crumbs/builder.py |   10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
Richard Purdie - Oct. 27, 2012, 8:56 a.m.
On Thu, 2012-10-25 at 16:43 +0300, Cristiana Voicu wrote:
> - indicating on progress bar that hob has gone from parsing
> recipes to "Generating dependency tree"; this will provide
> some visibility of what has caused the "stop" button state
> to change
> 
> [YOCTO #3282]
> Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
> ---
>  bitbake/lib/bb/ui/crumbs/builder.py |   10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

Merged to master, thanks.

Richard

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/builder.py b/bitbake/lib/bb/ui/crumbs/builder.py
index 2fc4a29..67d7de8 100755
--- a/bitbake/lib/bb/ui/crumbs/builder.py
+++ b/bitbake/lib/bb/ui/crumbs/builder.py
@@ -962,7 +962,10 @@  class Builder(gtk.Window):
         else:
             self.image_configuration_page.stop_button.set_sensitive(True)
 
-        self.image_configuration_page.update_progress_bar(message["title"], fraction)
+        if message["eventname"] == "TreeDataPreparationProgress":
+            self.image_configuration_page.update_progress_bar("Generating dependency tree", fraction)
+        else:
+            self.image_configuration_page.update_progress_bar(message["title"], fraction)
 
     def handler_parsing_cb(self, handler, message):
         if self.current_step != self.RCPPKGINFO_POPULATING:
@@ -973,7 +976,10 @@  class Builder(gtk.Window):
             fraction = 0.6 + 0.38 * fraction
         else:
             fraction = 0.6 * fraction
-        self.image_configuration_page.update_progress_bar(message["title"], fraction)
+        if message["eventname"] == "TreeDataPreparationProgress":
+            self.image_configuration_page.update_progress_bar("Generating dependency tree", fraction)
+        else: 
+            self.image_configuration_page.update_progress_bar(message["title"], fraction)
 
     def handler_parsing_completed_cb(self, handler, message):
         if self.current_step != self.RCPPKGINFO_POPULATING: