Patchwork [1/1] perl: update dependencies

login
register
mail settings
Submitter Kang Kai
Date Oct. 25, 2012, 9:50 a.m.
Message ID <6568219d957b11739d325f2573df9266cfe228a6.1351155183.git.kai.kang@windriver.com>
Download mbox | patch
Permalink /patch/38555/
State Accepted
Commit c65e88b3f20627d7e49e0306f336eee3fb256d1e
Headers show

Comments

Kang Kai - Oct. 25, 2012, 9:50 a.m.
Update dependencies for perl modules again. When only install
perl-module-file-glob, run perl script with "require File::Glob;" will
fail. Update dependencies to fix that.

[Yocto 3069]

Signed-off-by: Kang Kai <kai.kang@windriver.com>
---
 .../recipes-devtools/perl/perl-rdepends_5.14.2.inc |    2 ++
 meta/recipes-devtools/perl/perl_5.14.2.bb          |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
Saul Wold - Oct. 25, 2012, 2:54 p.m.
On 10/25/2012 02:50 AM, Kang Kai wrote:
> Update dependencies for perl modules again. When only install
> perl-module-file-glob, run perl script with "require File::Glob;" will
> fail. Update dependencies to fix that.
>
Is this just a point fix for the File::Glob issue?

As I was originally researching this issue it seemed to me that the 
perl_rdepends was incorrect, the script used to generate it did not 
actually work, please review the bug comment.

Are you going to look at the bigger issue?

Thanks
	Sau!

> [Yocto 3069]
>
> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> ---
>   .../recipes-devtools/perl/perl-rdepends_5.14.2.inc |    2 ++
>   meta/recipes-devtools/perl/perl_5.14.2.bb          |    2 +-
>   2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc b/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc
> index 2707fe8..39972ca 100644
> --- a/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc
> +++ b/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc
> @@ -13,8 +13,10 @@
>
>   # Some additional dependencies that the above doesn't manage to figure out
>   # Please take care that exporter depends exporter-heavy, not reverse
> +RDEPENDS_${PN}-module-dynaloader += "${PN}-module-carp"
>   RDEPENDS_${PN}-module-exporter += "${PN}-module-exporter-heavy"
>   RDEPENDS_${PN}-module-file-glob += "${PN}-module-feature"
> +RDEPENDS_${PN}-module-file-glob += "${PN}-module-file"
>   RDEPENDS_${PN}-module-file-path += "${PN}-module-cwd"
>   RDEPENDS_${PN}-module-file-spec += "${PN}-module-file-spec-unix"
>   RDEPENDS_${PN}-module-file-stat += "${PN}-module-fcntl"
> diff --git a/meta/recipes-devtools/perl/perl_5.14.2.bb b/meta/recipes-devtools/perl/perl_5.14.2.bb
> index 3ede831..1e1eb04 100644
> --- a/meta/recipes-devtools/perl/perl_5.14.2.bb
> +++ b/meta/recipes-devtools/perl/perl_5.14.2.bb
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://Copying;md5=2b4c6ffbcfcbdee469f02565f253d81a \
>   # We need gnugrep (for -I)
>   DEPENDS = "virtual/db grep-native"
>   DEPENDS += "gdbm zlib"
> -PR = "r13"
> +PR = "r14"
>
>   # 5.10.1 has Module::Build built-in
>   PROVIDES += "libmodule-build-perl"
>
Kang Kai - Oct. 26, 2012, 1:40 a.m.
On 2012?10?25? 22:54, Saul Wold wrote:
> On 10/25/2012 02:50 AM, Kang Kai wrote:
>> Update dependencies for perl modules again. When only install
>> perl-module-file-glob, run perl script with "require File::Glob;" will
>> fail. Update dependencies to fix that.
>>
> Is this just a point fix for the File::Glob issue?

Fix perl-module-dynaloader too. It didn't expose to run failed when 
update the deps among perl modules.

>
> As I was originally researching this issue it seemed to me that the 
> perl_rdepends was incorrect, the script used to generate it did not 
> actually work, please review the bug comment.
>
> Are you going to look at the bigger issue?

I'm glad to. But this may need more time.

Regards,
Kai

>
> Thanks
> Sau!
>
>> [Yocto 3069]
>>
>> Signed-off-by: Kang Kai <kai.kang@windriver.com>
>> ---
>> .../recipes-devtools/perl/perl-rdepends_5.14.2.inc | 2 ++
>> meta/recipes-devtools/perl/perl_5.14.2.bb | 2 +-
>> 2 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc 
>> b/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc
>> index 2707fe8..39972ca 100644
>> --- a/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc
>> +++ b/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc
>> @@ -13,8 +13,10 @@
>>
>> # Some additional dependencies that the above doesn't manage to 
>> figure out
>> # Please take care that exporter depends exporter-heavy, not reverse
>> +RDEPENDS_${PN}-module-dynaloader += "${PN}-module-carp"
>> RDEPENDS_${PN}-module-exporter += "${PN}-module-exporter-heavy"
>> RDEPENDS_${PN}-module-file-glob += "${PN}-module-feature"
>> +RDEPENDS_${PN}-module-file-glob += "${PN}-module-file"
>> RDEPENDS_${PN}-module-file-path += "${PN}-module-cwd"
>> RDEPENDS_${PN}-module-file-spec += "${PN}-module-file-spec-unix"
>> RDEPENDS_${PN}-module-file-stat += "${PN}-module-fcntl"
>> diff --git a/meta/recipes-devtools/perl/perl_5.14.2.bb 
>> b/meta/recipes-devtools/perl/perl_5.14.2.bb
>> index 3ede831..1e1eb04 100644
>> --- a/meta/recipes-devtools/perl/perl_5.14.2.bb
>> +++ b/meta/recipes-devtools/perl/perl_5.14.2.bb
>> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = 
>> "file://Copying;md5=2b4c6ffbcfcbdee469f02565f253d81a \
>> # We need gnugrep (for -I)
>> DEPENDS = "virtual/db grep-native"
>> DEPENDS += "gdbm zlib"
>> -PR = "r13"
>> +PR = "r14"
>>
>> # 5.10.1 has Module::Build built-in
>> PROVIDES += "libmodule-build-perl"
>>
>

Patch

diff --git a/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc b/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc
index 2707fe8..39972ca 100644
--- a/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc
+++ b/meta/recipes-devtools/perl/perl-rdepends_5.14.2.inc
@@ -13,8 +13,10 @@ 
 
 # Some additional dependencies that the above doesn't manage to figure out
 # Please take care that exporter depends exporter-heavy, not reverse
+RDEPENDS_${PN}-module-dynaloader += "${PN}-module-carp"
 RDEPENDS_${PN}-module-exporter += "${PN}-module-exporter-heavy"
 RDEPENDS_${PN}-module-file-glob += "${PN}-module-feature"
+RDEPENDS_${PN}-module-file-glob += "${PN}-module-file"
 RDEPENDS_${PN}-module-file-path += "${PN}-module-cwd"
 RDEPENDS_${PN}-module-file-spec += "${PN}-module-file-spec-unix"
 RDEPENDS_${PN}-module-file-stat += "${PN}-module-fcntl"
diff --git a/meta/recipes-devtools/perl/perl_5.14.2.bb b/meta/recipes-devtools/perl/perl_5.14.2.bb
index 3ede831..1e1eb04 100644
--- a/meta/recipes-devtools/perl/perl_5.14.2.bb
+++ b/meta/recipes-devtools/perl/perl_5.14.2.bb
@@ -7,7 +7,7 @@  LIC_FILES_CHKSUM = "file://Copying;md5=2b4c6ffbcfcbdee469f02565f253d81a \
 # We need gnugrep (for -I)
 DEPENDS = "virtual/db grep-native"
 DEPENDS += "gdbm zlib"
-PR = "r13"
+PR = "r14"
 
 # 5.10.1 has Module::Build built-in
 PROVIDES += "libmodule-build-perl"