diff mbox series

[1/4] tune-cortexa78.inc: Add cortexa78 tune, based on cortexa77

Message ID 1706743783-10659-2-git-send-email-mark.hatle@kernel.crashing.org
State Accepted, archived
Commit 6750384cbb4f8d90c8c32a85db66e8e3344d4ce6
Headers show
Series Updates for ARM tunings | expand

Commit Message

Mark Hatle Jan. 31, 2024, 11:29 p.m. UTC
From: Mark Hatle <mark.hatle@amd.com>

Signed-off-by: Mark Hatle <mark.hatle@amd.com>
Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
---
 .../include/arm/armv8-2a/tune-cortexa78.inc      | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc

Comments

Khem Raj Feb. 1, 2024, 2:09 a.m. UTC | #1
On Wed, Jan 31, 2024 at 3:29 PM Mark Hatle
<mark.hatle@kernel.crashing.org> wrote:
>
> From: Mark Hatle <mark.hatle@amd.com>
>
> Signed-off-by: Mark Hatle <mark.hatle@amd.com>
> Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
> ---
>  .../include/arm/armv8-2a/tune-cortexa78.inc      | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc
>
> diff --git a/meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc
> new file mode 100644
> index 0000000000..8c85d98ef9
> --- /dev/null
> +++ b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc
> @@ -0,0 +1,16 @@
> +#
> +# Tune Settings for Cortex-A78
> +#
> +DEFAULTTUNE                                        ?= "cortexa78"
> +
> +TUNEVALID[cortexa78] = "Enable Cortex-A78 specific processor optimizations"
> +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'cortexa78', ' -mcpu=cortex-a78', '', d)}"
> +
> +require conf/machine/include/arm/arch-armv8-2a.inc
> +
> +# Little Endian base configs
> +AVAILTUNES                                         += "cortexa78"
> +ARMPKGARCH:tune-cortexa78                           = "cortexa78"
> +TUNE_FEATURES:tune-cortexa78                        = "${TUNE_FEATURES:tune-armv8-2a-crypto} cortexa78"

I think this should be set to "aarch64 crypto cortexa78" inline with
patch I sent last week [1], otherwise it looks ok.

[1] https://lore.kernel.org/openembedded-core/20240126233141.1589013-1-raj.khem@gmail.com/
Mark Hatle Feb. 1, 2024, 2:15 a.m. UTC | #2
It should be the same as the cortexa77.inc file, but say 78..  So I've no 
problems with that change if it's in master.

--Mark

On 1/31/24 8:09 PM, Khem Raj wrote:
> On Wed, Jan 31, 2024 at 3:29 PM Mark Hatle
> <mark.hatle@kernel.crashing.org> wrote:
>>
>> From: Mark Hatle <mark.hatle@amd.com>
>>
>> Signed-off-by: Mark Hatle <mark.hatle@amd.com>
>> Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
>> ---
>>   .../include/arm/armv8-2a/tune-cortexa78.inc      | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>   create mode 100644 meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc
>>
>> diff --git a/meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc
>> new file mode 100644
>> index 0000000000..8c85d98ef9
>> --- /dev/null
>> +++ b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc
>> @@ -0,0 +1,16 @@
>> +#
>> +# Tune Settings for Cortex-A78
>> +#
>> +DEFAULTTUNE                                        ?= "cortexa78"
>> +
>> +TUNEVALID[cortexa78] = "Enable Cortex-A78 specific processor optimizations"
>> +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'cortexa78', ' -mcpu=cortex-a78', '', d)}"
>> +
>> +require conf/machine/include/arm/arch-armv8-2a.inc
>> +
>> +# Little Endian base configs
>> +AVAILTUNES                                         += "cortexa78"
>> +ARMPKGARCH:tune-cortexa78                           = "cortexa78"
>> +TUNE_FEATURES:tune-cortexa78                        = "${TUNE_FEATURES:tune-armv8-2a-crypto} cortexa78"
> 
> I think this should be set to "aarch64 crypto cortexa78" inline with
> patch I sent last week [1], otherwise it looks ok.
> 
> [1] https://lore.kernel.org/openembedded-core/20240126233141.1589013-1-raj.khem@gmail.com/
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#194545): https://lists.openembedded.org/g/openembedded-core/message/194545
> Mute This Topic: https://lists.openembedded.org/mt/104086355/3616948
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mark.hatle@kernel.crashing.org]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc
new file mode 100644
index 0000000000..8c85d98ef9
--- /dev/null
+++ b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc
@@ -0,0 +1,16 @@ 
+#
+# Tune Settings for Cortex-A78
+#
+DEFAULTTUNE                                        ?= "cortexa78"
+
+TUNEVALID[cortexa78] = "Enable Cortex-A78 specific processor optimizations"
+TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'cortexa78', ' -mcpu=cortex-a78', '', d)}"
+
+require conf/machine/include/arm/arch-armv8-2a.inc
+
+# Little Endian base configs
+AVAILTUNES                                         += "cortexa78"
+ARMPKGARCH:tune-cortexa78                           = "cortexa78"
+TUNE_FEATURES:tune-cortexa78                        = "${TUNE_FEATURES:tune-armv8-2a-crypto} cortexa78"
+PACKAGE_EXTRA_ARCHS:tune-cortexa78                  = "${PACKAGE_EXTRA_ARCHS:tune-armv8-2a-crypto} cortexa78"
+BASE_LIB:tune-cortexa78                             = "lib64"