Patchwork [1/3] gnome-icon-theme: fix icon mapping

login
register
mail settings
Submitter Andreas Müller
Date Oct. 23, 2012, 7:04 a.m.
Message ID <1350975871-26719-2-git-send-email-schnitzeltony@googlemail.com>
Download mbox | patch
Permalink /patch/38439/
State New
Headers show

Comments

Andreas Müller - Oct. 23, 2012, 7:04 a.m.
Multiple errors in log.do_install as:
Can't locate XML/Simple.pm in @INC (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at /home/andreas/tmp/oe-core-eglibc/sysroots/x86_64-linux/usr/lib/../libexec/icon-name-mapping line 12.

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
 .../recipes-gnome/gnome/gnome-icon-theme_2.31.0.bb |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
Richard Purdie - Oct. 23, 2012, 11:22 a.m.
On Tue, 2012-10-23 at 09:04 +0200, Andreas Müller wrote:
> Multiple errors in log.do_install as:
> Can't locate XML/Simple.pm in @INC (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at /home/andreas/tmp/oe-core-eglibc/sysroots/x86_64-linux/usr/lib/../libexec/icon-name-mapping line 12.
> 
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
>  .../recipes-gnome/gnome/gnome-icon-theme_2.31.0.bb |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-gnome/gnome/gnome-icon-theme_2.31.0.bb b/meta/recipes-gnome/gnome/gnome-icon-theme_2.31.0.bb
> index 8e7995b..f017b56 100644
> --- a/meta/recipes-gnome/gnome/gnome-icon-theme_2.31.0.bb
> +++ b/meta/recipes-gnome/gnome/gnome-icon-theme_2.31.0.bb
> @@ -9,7 +9,7 @@ SECTION = "x11/gnome"
>  DEPENDS = "icon-naming-utils-native glib-2.0 intltool-native"
>  RDEPENDS_${PN} = "hicolor-icon-theme"
>  RRECOMMENDS_${PN} = "librsvg-gtk"
> -PR = "r3"
> +PR = "r4"
>  
>  FILES_${PN} += "${datadir}/*"
>  
> @@ -22,5 +22,4 @@ SRC_URI[sha256sum] = "ea7e05b77ead159379392b3b275ca0c9cbacd7d936014e447cc7c5e27a
>  EXTRA_OECONF = "--disable-hicolor-check"
>  EXTRA_OECONF += "--with-iconmap=${@d.getVar('STAGING_LIBEXECDIR_NATIVE', True).replace('gnome-icon-theme', 'icon-naming-utils')}/icon-name-mapping"
>  
> -
> -inherit autotools
> +inherit autotools perlnative

Doesn't this need a DEPENDS += "libxml-simple-perl-native" or whatever
the correct name for the module is?

Cheers,

Richard
Andreas Müller - Oct. 23, 2012, 12:38 p.m.
On Tue, Oct 23, 2012 at 1:22 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> Doesn't this need a DEPENDS += "libxml-simple-perl-native" or whatever
> the correct name for the module is?

Sounds reasonable. Subsequent patch or V3?

Andreas
Richard Purdie - Oct. 23, 2012, 1:09 p.m.
On Tue, 2012-10-23 at 14:38 +0200, Andreas Müller wrote:
> On Tue, Oct 23, 2012 at 1:22 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > Doesn't this need a DEPENDS += "libxml-simple-perl-native" or whatever
> > the correct name for the module is?
> 
> Sounds reasonable. Subsequent patch or V3?

V3 please, might as well get this right and sorry I didn't realise this
before.

Cheers,

Richard

Patch

diff --git a/meta/recipes-gnome/gnome/gnome-icon-theme_2.31.0.bb b/meta/recipes-gnome/gnome/gnome-icon-theme_2.31.0.bb
index 8e7995b..f017b56 100644
--- a/meta/recipes-gnome/gnome/gnome-icon-theme_2.31.0.bb
+++ b/meta/recipes-gnome/gnome/gnome-icon-theme_2.31.0.bb
@@ -9,7 +9,7 @@  SECTION = "x11/gnome"
 DEPENDS = "icon-naming-utils-native glib-2.0 intltool-native"
 RDEPENDS_${PN} = "hicolor-icon-theme"
 RRECOMMENDS_${PN} = "librsvg-gtk"
-PR = "r3"
+PR = "r4"
 
 FILES_${PN} += "${datadir}/*"
 
@@ -22,5 +22,4 @@  SRC_URI[sha256sum] = "ea7e05b77ead159379392b3b275ca0c9cbacd7d936014e447cc7c5e27a
 EXTRA_OECONF = "--disable-hicolor-check"
 EXTRA_OECONF += "--with-iconmap=${@d.getVar('STAGING_LIBEXECDIR_NATIVE', True).replace('gnome-icon-theme', 'icon-naming-utils')}/icon-name-mapping"
 
-
-inherit autotools
+inherit autotools perlnative