From 0aa4c262ded3e9d9da8293d899cd6ec28b4f60bb Mon Sep 17 00:00:00 2001 From: Phil Blundell Date: Mon, 15 Oct 2012 11:28:00 +0100 Subject: [PATCH] insane: Don't try to run objdump on symlinks If the link is absolute then we might end up reading from a host binary or a nonexistent path, neither of which will produce useful results and may result in objdump failure and python backtrace spew. If the link does point to a binary within the installation root then we will scan the pointed-to file at some point anyway so there is no need to do it again. Signed-off-by: Phil Blundell --- meta/classes/insane.bbclass | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 2b48419..71a9a58 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -157,6 +157,9 @@ def package_qa_check_rpath(file,name, d, elf, messages): if not elf: return + if os.path.islink(file): + return + bad_dirs = [d.getVar('TMPDIR', True) + "/work", d.getVar('STAGING_DIR_TARGET', True)] bad_dir_test = d.getVar('TMPDIR', True) @@ -186,6 +189,9 @@ def package_qa_check_useless_rpaths(file, name, d, elf, messages): if not elf: return + if os.path.islink(file): + return + libdir = d.getVar("libdir", True) base_libdir = d.getVar("base_libdir", True) -- 1.7.10.4