| Message ID | 20240122162917.822825-2-r-ravikumar@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | Increase min buffers or CSI capture | expand |
Hi Rahul, Thanks for the patch. On 22/01/24 21:59, Rahul T R wrote: > This will make it easier to maintain and it will be easier if we decide > to have TI fork for gstreamer. > > Signed-off-by: Rahul T R <r-ravikumar@ti.com> > --- > .../gstreamer1.0-plugins-good_1.20.%.bbappend | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) > > diff --git a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend > index e14a3c93..7ad943f6 100644 > --- a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend > +++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend > @@ -3,25 +3,8 @@ FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:" > SRC_URI:append = " \ > file://0001-Adding-support-for-raw10-raw12-and-raw16-bayer-formats.patch \ > file://0002-Adding-support-for-bayer-formats-with-IR-component.patch \ > -" > - > -SRC_URI:append:j721s2 = " \ > file://0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \ As you are already cleaning it up, could you please also update the indexing of the patches, SRC_URI:append = " \ file://0001-Adding-support-for-raw10-raw12-and-raw16-bayer-formats.patch \ file://0002-Adding-support-for-bayer-formats-with-IR-component.patch \ file://0003-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \ file://0004-v4l2-Give-preference-to-contiguous-format-if-support.patch \ file://0005-gstv4l2object-Increase-min-buffers.patch \ ? Regards Devarsh > file://0002-v4l2-Give-preference-to-contiguous-format-if-support.patch \ > " > > -SRC_URI:append:j784s4 = " \ > - file://0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \ > - file://0002-v4l2-Give-preference-to-contiguous-format-if-support.patch \ > -" > - > -SRC_URI:append:am62axx = " \ > - file://0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \ > - file://0002-v4l2-Give-preference-to-contiguous-format-if-support.patch \ > -" > - > -SRC_URI:append:am62pxx = " \ > - file://0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \ > - file://0002-v4l2-Give-preference-to-contiguous-format-if-support.patch \ > -" > -PR:append = ".arago0" > +PR:append = ".arago1"
On 23/01/24 19:56, Devarsh Thakkar wrote: > Hi Rahul, > > Thanks for the patch. > > On 22/01/24 21:59, Rahul T R wrote: >> This will make it easier to maintain and it will be easier if we decide >> to have TI fork for gstreamer. >>> Signed-off-by: Rahul T R <r-ravikumar@ti.com> >> --- >> .../gstreamer1.0-plugins-good_1.20.%.bbappend | 19 +------------------ >> 1 file changed, 1 insertion(+), 18 deletions(-) >> >> diff --git a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend >> index e14a3c93..7ad943f6 100644 >> --- a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend >> +++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend >> @@ -3,25 +3,8 @@ FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:" >> SRC_URI:append = " \ >> file://0001-Adding-support-for-raw10-raw12-and-raw16-bayer-formats.patch \ >> file://0002-Adding-support-for-bayer-formats-with-IR-component.patch \ >> -" >> - >> -SRC_URI:append:j721s2 = " \ >> file://0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \ > As you are already cleaning it up, could you please also update the indexing > of the patches, > > SRC_URI:append = " \ > file://0001-Adding-support-for-raw10-raw12-and-raw16-bayer-formats.patch \ > file://0002-Adding-support-for-bayer-formats-with-IR-component.patch \ > file://0003-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \ > file://0004-v4l2-Give-preference-to-contiguous-format-if-support.patch \ > file://0005-gstv4l2object-Increase-min-buffers.patch \ > ? > > Regards > Devarsh Hi Devarsh, Thanks for the review ! Sure, Will fix this in v2 Regards Rahul T R >> file://0002-v4l2-Give-preference-to-contiguous-format-if-support.patch \ >> " >> >> -SRC_URI:append:j784s4 = " \ >> - file://0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \ >> - file://0002-v4l2-Give-preference-to-contiguous-format-if-support.patch \ >> -" >> - >> -SRC_URI:append:am62axx = " \ >> - file://0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \ >> - file://0002-v4l2-Give-preference-to-contiguous-format-if-support.patch \ >> -" >> - >> -SRC_URI:append:am62pxx = " \ >> - file://0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \ >> - file://0002-v4l2-Give-preference-to-contiguous-format-if-support.patch \ >> -" >> -PR:append = ".arago0" >> +PR:append = ".arago1"
diff --git a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend index e14a3c93..7ad943f6 100644 --- a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend +++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend @@ -3,25 +3,8 @@ FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:" SRC_URI:append = " \ file://0001-Adding-support-for-raw10-raw12-and-raw16-bayer-formats.patch \ file://0002-Adding-support-for-bayer-formats-with-IR-component.patch \ -" - -SRC_URI:append:j721s2 = " \ file://0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \ file://0002-v4l2-Give-preference-to-contiguous-format-if-support.patch \ " -SRC_URI:append:j784s4 = " \ - file://0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \ - file://0002-v4l2-Give-preference-to-contiguous-format-if-support.patch \ -" - -SRC_URI:append:am62axx = " \ - file://0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \ - file://0002-v4l2-Give-preference-to-contiguous-format-if-support.patch \ -" - -SRC_URI:append:am62pxx = " \ - file://0001-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \ - file://0002-v4l2-Give-preference-to-contiguous-format-if-support.patch \ -" -PR:append = ".arago0" +PR:append = ".arago1"
This will make it easier to maintain and it will be easier if we decide to have TI fork for gstreamer. Signed-off-by: Rahul T R <r-ravikumar@ti.com> --- .../gstreamer1.0-plugins-good_1.20.%.bbappend | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-)