Patchwork kernel.bbclass: Do not chdir to /boot before running update-alternatives

login
register
mail settings
Submitter Holger Hans Peter Freyther
Date Oct. 12, 2012, 6:01 p.m.
Message ID <1350064876-11475-1-git-send-email-holger@moiji-mobile.com>
Download mbox | patch
Permalink /patch/38129/
State Accepted
Commit c77ca9ee901468c93570b5264b226f7d17a41c16
Headers show

Comments

Holger Hans Peter Freyther - Oct. 12, 2012, 6:01 p.m.
The symlink from uImage-3... to uImage is not created at image creation
time and not properly update on kernel upgrades. This is fixed by removing
the chdir. The other users of update-alternative do not change the directory
before calling it.
---
 meta/classes/kernel.bbclass |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Holger Freyther - Oct. 21, 2012, 7:42 a.m.
Holger Hans Peter Freyther <holger@...> writes:

> 
> The symlink from uImage-3... to uImage is not created at image creation
> time and not properly update on kernel upgrades. This is fixed by removing
> the chdir. The other users of update-alternative do not change the directory
> before calling it.

Hi,

this patch has not been merged, nor has it received any comments. The symlink
creation for uImage is broken right now and I would be very happy if it could
be fixed.

holger
Richard Purdie - Oct. 22, 2012, 3:51 p.m.
On Sun, 2012-10-21 at 07:42 +0000, Holger Freyther wrote:
> Holger Hans Peter Freyther <holger@...> writes:
> 
> > 
> > The symlink from uImage-3... to uImage is not created at image creation
> > time and not properly update on kernel upgrades. This is fixed by removing
> > the chdir. The other users of update-alternative do not change the directory
> > before calling it.
> 
> Hi,
> 
> this patch has not been merged, nor has it received any comments. The symlink
> creation for uImage is broken right now and I would be very happy if it could
> be fixed.

Merged to master, thanks.

Richard

Patch

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 36bc3c7..28b1e3e 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -245,11 +245,11 @@  do_savedefconfig[nostamp] = "1"
 addtask savedefconfig after do_configure
 
 pkg_postinst_kernel-base () {
-	cd /${KERNEL_IMAGEDEST}; update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
+	update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
 }
 
 pkg_postrm_kernel-base () {
-	cd /${KERNEL_IMAGEDEST}; update-alternatives --remove ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} || true
+	update-alternatives --remove ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} || true
 }
 
 inherit cml1