Patchwork [0/2] perl: fix @INC, v2

login
mail settings
Submitter Tom Zanussi
Date Oct. 10, 2012, 12:48 a.m.
Message ID <cover.1349829329.git.tom.zanussi@intel.com>
Download mbox
Permalink /patch/38045/
State New
Headers show

Pull-request

git://git.yoctoproject.org/poky-contrib.git tzanussi/bug-3099-fix

Comments

Tom Zanussi - Oct. 10, 2012, 12:48 a.m.
From: Tom Zanussi <tom.zanussi@intel.com>

This fixes the bug reported by Kang Kai in a way that allows
perf scripting to continue to work.

Before this patch, @INC on the target would contain a native path:

   @INC:
     /etc/perl
     /usr/lib/perl/site_perl/5.14.2/
     /usr/lib/perl/site_perl/5.14.2
     /usr/lib/perl/vendor_perl/5.14.2/
     /usr/lib/perl/vendor_perl/5.14.2
     /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/
     /usr/lib/perl/5.14.2
     /usr/local/lib/site_perl
     /usr/lib/perl/5.14.2
     .

Kang Kai's patch reverted the problem that caused the native path
to appear, but also caused perf to report that scripting wasn't
supported.

With this patchset, the native path is gone:

  Built under linux
  Compiled at Oct  9 2012 18:40:15
  @INC:
    /etc/perl
    /usr/lib/perl/site_perl/5.14.2/
    /usr/lib/perl/site_perl/5.14.2
    /usr/lib/perl/vendor_perl/5.14.2/
    /usr/lib/perl/vendor_perl/5.14.2
    /usr/lib/perl/5.14.2/
    /usr/lib/perl/5.14.2
    /usr/local/lib/site_perl
    /usr/lib/perl/5.14.2
    .

and the perf Perl binding continues to work:

root@crownbay:~# perf script rwtop

read counts by pid:

   pid                  comm     # reads   bytes_req  bytes_read
------  --------------------  ----------  ----------  ----------
  1524  perf                        5629      213712      213648
  1508  dropbear                       8      131000         607

write counts by pid:

   pid                  comm    # writes  bytes_written
------  --------------------  ----------  -------------
  1522  perf                          11         845320
  1508  dropbear                       8            944

Tested on qemux86 and crownbay.

The following changes since commit 2c3e8280e67721d42d4be48a8e2c1e9ce9bb89fd:

  bitbake: hob/imageconfigurationpage: a 'hob-image' appears listed in the base image combo box (2012-10-08 16:23:34 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib.git tzanussi/bug-3099-fix
  http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/bug-3099-fix

Tom Zanussi (2):
  perl: add archlib_exp variable used to generate ARCHLIB_EXP in
    config.h
  perl: use archlib_exp config.sh variable

 meta/recipes-devtools/perl/perl-5.14.2/config.sh          |  1 +
 .../perl/perl-5.14.2/perl-archlib-exp.patch               | 15 +++++++++++++++
 meta/recipes-devtools/perl/perl_5.14.2.bb                 |  3 ++-
 3 files changed, 18 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/perl/perl-5.14.2/perl-archlib-exp.patch
Richard Purdie - Oct. 10, 2012, 2:14 p.m.
On Tue, 2012-10-09 at 19:48 -0500, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> This fixes the bug reported by Kang Kai in a way that allows
> perf scripting to continue to work.
> 
> Before this patch, @INC on the target would contain a native path:
> 
>    @INC:
>      /etc/perl
>      /usr/lib/perl/site_perl/5.14.2/
>      /usr/lib/perl/site_perl/5.14.2
>      /usr/lib/perl/vendor_perl/5.14.2/
>      /usr/lib/perl/vendor_perl/5.14.2
>      /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/
>      /usr/lib/perl/5.14.2
>      /usr/local/lib/site_perl
>      /usr/lib/perl/5.14.2
>      .
> 
> Kang Kai's patch reverted the problem that caused the native path
> to appear, but also caused perf to report that scripting wasn't
> supported.
> 
> With this patchset, the native path is gone:
> 
>   Built under linux
>   Compiled at Oct  9 2012 18:40:15
>   @INC:
>     /etc/perl
>     /usr/lib/perl/site_perl/5.14.2/
>     /usr/lib/perl/site_perl/5.14.2
>     /usr/lib/perl/vendor_perl/5.14.2/
>     /usr/lib/perl/vendor_perl/5.14.2
>     /usr/lib/perl/5.14.2/
>     /usr/lib/perl/5.14.2
>     /usr/local/lib/site_perl
>     /usr/lib/perl/5.14.2
>     .
> 
> and the perf Perl binding continues to work:
> 
> root@crownbay:~# perf script rwtop
> 
> read counts by pid:
> 
>    pid                  comm     # reads   bytes_req  bytes_read
> ------  --------------------  ----------  ----------  ----------
>   1524  perf                        5629      213712      213648
>   1508  dropbear                       8      131000         607
> 
> write counts by pid:
> 
>    pid                  comm    # writes  bytes_written
> ------  --------------------  ----------  -------------
>   1522  perf                          11         845320
>   1508  dropbear                       8            944
> 
> Tested on qemux86 and crownbay.
> 
> The following changes since commit 2c3e8280e67721d42d4be48a8e2c1e9ce9bb89fd:
> 
>   bitbake: hob/imageconfigurationpage: a 'hob-image' appears listed in the base image combo box (2012-10-08 16:23:34 +0100)
> 
> are available in the git repository at:
> 
>   git://git.yoctoproject.org/poky-contrib.git tzanussi/bug-3099-fix
>   http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/bug-3099-fix
> 
> Tom Zanussi (2):
>   perl: add archlib_exp variable used to generate ARCHLIB_EXP in
>     config.h
>   perl: use archlib_exp config.sh variable

I've taken these but I didn't like them being two commits, or the lack
of information in the patch header. I therefore tweaked it before
applying.

Cheers,

Richard
Tom Zanussi - Oct. 10, 2012, 2:27 p.m.
On Wed, 2012-10-10 at 15:14 +0100, Richard Purdie wrote:
> On Tue, 2012-10-09 at 19:48 -0500, tom.zanussi@intel.com wrote:
> > From: Tom Zanussi <tom.zanussi@intel.com>
> > 
> > This fixes the bug reported by Kang Kai in a way that allows
> > perf scripting to continue to work.
> > 
> > Before this patch, @INC on the target would contain a native path:
> > 
> >    @INC:
> >      /etc/perl
> >      /usr/lib/perl/site_perl/5.14.2/
> >      /usr/lib/perl/site_perl/5.14.2
> >      /usr/lib/perl/vendor_perl/5.14.2/
> >      /usr/lib/perl/vendor_perl/5.14.2
> >      /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/
> >      /usr/lib/perl/5.14.2
> >      /usr/local/lib/site_perl
> >      /usr/lib/perl/5.14.2
> >      .
> > 
> > Kang Kai's patch reverted the problem that caused the native path
> > to appear, but also caused perf to report that scripting wasn't
> > supported.
> > 
> > With this patchset, the native path is gone:
> > 
> >   Built under linux
> >   Compiled at Oct  9 2012 18:40:15
> >   @INC:
> >     /etc/perl
> >     /usr/lib/perl/site_perl/5.14.2/
> >     /usr/lib/perl/site_perl/5.14.2
> >     /usr/lib/perl/vendor_perl/5.14.2/
> >     /usr/lib/perl/vendor_perl/5.14.2
> >     /usr/lib/perl/5.14.2/
> >     /usr/lib/perl/5.14.2
> >     /usr/local/lib/site_perl
> >     /usr/lib/perl/5.14.2
> >     .
> > 
> > and the perf Perl binding continues to work:
> > 
> > root@crownbay:~# perf script rwtop
> > 
> > read counts by pid:
> > 
> >    pid                  comm     # reads   bytes_req  bytes_read
> > ------  --------------------  ----------  ----------  ----------
> >   1524  perf                        5629      213712      213648
> >   1508  dropbear                       8      131000         607
> > 
> > write counts by pid:
> > 
> >    pid                  comm    # writes  bytes_written
> > ------  --------------------  ----------  -------------
> >   1522  perf                          11         845320
> >   1508  dropbear                       8            944
> > 
> > Tested on qemux86 and crownbay.
> > 
> > The following changes since commit 2c3e8280e67721d42d4be48a8e2c1e9ce9bb89fd:
> > 
> >   bitbake: hob/imageconfigurationpage: a 'hob-image' appears listed in the base image combo box (2012-10-08 16:23:34 +0100)
> > 
> > are available in the git repository at:
> > 
> >   git://git.yoctoproject.org/poky-contrib.git tzanussi/bug-3099-fix
> >   http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/bug-3099-fix
> > 
> > Tom Zanussi (2):
> >   perl: add archlib_exp variable used to generate ARCHLIB_EXP in
> >     config.h
> >   perl: use archlib_exp config.sh variable
> 
> I've taken these but I didn't like them being two commits, or the lack
> of information in the patch header. I therefore tweaked it before
> applying.
> 

OK, thanks, sorry to miss those things, will keep it in mind for next
time...

Tom

> Cheers,
> 
> Richard
>