diff mbox series

[v2] tune-core2: Update qemu cpu to supported model

Message ID 20240117202923.29341-1-simone.p.weiss@posteo.com
State Accepted, archived
Commit f2383a2bff3eb756740ecaf48147bea89303e443
Headers show
Series [v2] tune-core2: Update qemu cpu to supported model | expand

Commit Message

Simone Weiß Jan. 17, 2024, 8:29 p.m. UTC
From: Simone Weiß <simone.p.weiss@posteo.com>

Fixes [YOCTO #12388]

QEMUs documentation does recommend to not use n270 and core2duo as
an argument to -cpu anymore. See also the QEMU documentation for this at
[0].
Update therefore the QEMU cpu option for the core2duo tune to Nehalam.
Tested it locally with QEMU and KVM.

[0]: https://qemu-project.gitlab.io/qemu/system/qemu-cpu-models.html#other-non-recommended-x86-cpus

Signed-off-by: Simone Weiß <simone.p.weiss@posteo.com>
---
 meta/conf/machine/include/x86/tune-core2.inc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Simone Weiß Jan. 25, 2024, 6:10 a.m. UTC | #1
References are now added, as requested in v2. Is more still missing?
Khem Raj Jan. 25, 2024, 6:39 a.m. UTC | #2
On Wed, Jan 24, 2024 at 10:10 PM Simone Weiß <simone.p.weiss@posteo.com> wrote:
>
> References are now added, as requested in v2. Is more still missing?

We do not send explicit notification on patches being accepted,
Usually we comment on the patch if there is some
improvement needed. So its good to check master branch or master-next
and poky-contrib/abelloni/master-next during staging
for status of the patch

This one is already applied to master see [1]

[1] https://git.yoctoproject.org/poky-contrib/commit/?h=abelloni/master-next&id=97fd704adcfcad439c5e4af390916434da07da98

>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#194306): https://lists.openembedded.org/g/openembedded-core/message/194306
> Mute This Topic: https://lists.openembedded.org/mt/103794943/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/conf/machine/include/x86/tune-core2.inc b/meta/conf/machine/include/x86/tune-core2.inc
index 97b7c1b188..082fd4efc3 100644
--- a/meta/conf/machine/include/x86/tune-core2.inc
+++ b/meta/conf/machine/include/x86/tune-core2.inc
@@ -21,18 +21,18 @@  TUNE_FEATURES:tune-core2-32 = "${TUNE_FEATURES:tune-x86} core2"
 BASE_LIB:tune-core2-32 = "lib"
 TUNE_PKGARCH:tune-core2-32 = "core2-32"
 PACKAGE_EXTRA_ARCHS:tune-core2-32 = "${PACKAGE_EXTRA_ARCHS:tune-i686} core2-32"
-QEMU_EXTRAOPTIONS_core2-32 = " -cpu n270"
+QEMU_EXTRAOPTIONS_core2-32 = " -cpu Nehalem,check=false"
 
 AVAILTUNES += "core2-64"
 TUNE_FEATURES:tune-core2-64 = "${TUNE_FEATURES:tune-x86-64} core2"
 BASE_LIB:tune-core2-64 = "lib64"
 TUNE_PKGARCH:tune-core2-64 = "core2-64"
 PACKAGE_EXTRA_ARCHS:tune-core2-64 = "${PACKAGE_EXTRA_ARCHS:tune-x86-64} core2-64"
-QEMU_EXTRAOPTIONS_core2-64 = " -cpu core2duo"
+QEMU_EXTRAOPTIONS_core2-64 = " -cpu Nehalem,check=false"
 
 AVAILTUNES += "core2-64-x32"
 TUNE_FEATURES:tune-core2-64-x32 = "${TUNE_FEATURES:tune-x86-64-x32} core2"
 BASE_LIB:tune-core2-64-x32 = "libx32"
 TUNE_PKGARCH:tune-core2-64-x32 = "core2-64-x32"
 PACKAGE_EXTRA_ARCHS:tune-core2-64-x32 = "${PACKAGE_EXTRA_ARCHS:tune-x86-64-x32} core2-64-x32"
-QEMU_EXTRAOPTIONS_core2-64-x32 = " -cpu core2duo"
+QEMU_EXTRAOPTIONS_core2-64-x32 = " -cpu Nehalem,check=false"