Patchwork [RFC] pkgconfig: Drop automatic pkgconfig RDEPENDS

login
register
mail settings
Submitter Richard Purdie
Date Oct. 8, 2012, 3:50 p.m.
Message ID <1349711421.15658.121.camel@ted>
Download mbox | patch
Permalink /patch/37929/
State Accepted
Commit 8f41b69578eef5ea750e8f93dcd9d37375ce7d88
Headers show

Comments

Richard Purdie - Oct. 8, 2012, 3:50 p.m.
Just because a recipe uses pkgconfig, it doesn't mean that it's -dev
package should RDEPENDS on pkgconfig. I can understand the thinking
that lead to this but it makes sense to be able to install the package
when pkgconfig hasn't been built.

Currently you can also get failures where pkgconfig wasn't built yet
a -dev package is included that depends on it leading to rootfs failures.

I considered making this a RRECOMMENDS but it should probably be an
RSUGGESTS at best given the tenuous pkgconfig requirement any given
-dev package has. In the end I decided we might as well just remove it.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
--
cgit 0.9.0.1
Mark Hatle - Oct. 8, 2012, 5:36 p.m.
On 10/8/12 10:50 AM, Richard Purdie wrote:
> Just because a recipe uses pkgconfig, it doesn't mean that it's -dev
> package should RDEPENDS on pkgconfig. I can understand the thinking
> that lead to this but it makes sense to be able to install the package
> when pkgconfig hasn't been built.
>
> Currently you can also get failures where pkgconfig wasn't built yet
> a -dev package is included that depends on it leading to rootfs failures.
>
> I considered making this a RRECOMMENDS but it should probably be an
> RSUGGESTS at best given the tenuous pkgconfig requirement any given
> -dev package has. In the end I decided we might as well just remove it.

I believe the rpmdeps stuff will also add a runtime pkgconfig dependency if it 
encounters a .pc file during processing.

I know this was debated in the past on various workstation/server distros and 
the end result came about because it was cheaper to include pkgconfig when a 
-dev package had a .pc file in it, then support users who couldn't figure out 
how to properly compiler the stuff on their own.

If we want to change that behavior, then we'll likely have to filter it later as 
well.

--Mark

> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/classes/pkgconfig.bbclass b/meta/classes/pkgconfig.bbclass
> index 5908b7f..ad1f84f 100644
> --- a/meta/classes/pkgconfig.bbclass
> +++ b/meta/classes/pkgconfig.bbclass
> @@ -1,7 +1,2 @@
>   DEPENDS_prepend = "pkgconfig-native "
>
> -PKGCONFIGRDEP = "pkgconfig"
> -PKGCONFIGRDEP_virtclass-native = ""
> -PKGCONFIGRDEP_virtclass-nativesdk = "nativesdk-pkgconfig"
> -
> -RDEPENDS_${PN}-dev += "${PKGCONFIGRDEP}"
> --
> cgit 0.9.0.1
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/classes/pkgconfig.bbclass b/meta/classes/pkgconfig.bbclass
index 5908b7f..ad1f84f 100644
--- a/meta/classes/pkgconfig.bbclass
+++ b/meta/classes/pkgconfig.bbclass
@@ -1,7 +1,2 @@ 
 DEPENDS_prepend = "pkgconfig-native "
 
-PKGCONFIGRDEP = "pkgconfig"
-PKGCONFIGRDEP_virtclass-native = ""
-PKGCONFIGRDEP_virtclass-nativesdk = "nativesdk-pkgconfig"
-
-RDEPENDS_${PN}-dev += "${PKGCONFIGRDEP}"